https://bugzilla.wikimedia.org/show_bug.cgi?id=29329
Web browser: ---
Bug #: 29329
Summary: iframe-specific assumptions in other WikiEditor
modules
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: WikiEditor
AssignedTo: tpars...@wikimedia.org
ReportedBy: br...@wikimedia.org
CC: roan.katt...@gmail.com
Classification: Unclassified
Found while testing out stuff w/ bug 29328... This iframe-specific code gets
called from the WikiEditor toolbar module:
if ( context.$iframe !== undefined ) {
context.$iframe[0].contentWindow.focus();
}
The actual text insertion is abstracted via jquery.textSelection (but not
perfectly -- see bug 29328!) but the focus isn't. Probably needs to be made
into a function on the WikiEditor context object, so the iframe extension can
override it.
There are probably others...
* dialogs: explicit code to trigger iframe initialization... seems like this
should be pushed back a level so we just tell WikiEditor to load & init the
extension if not already loaded?
* dialogs.config: another focus() hack, and a special keypress binding with the
search/replace dialog, which probably just needs to be able to grab an
appropriate element to bind on which could then be done generically
* templateEditor pokes some data stuff on the $iframe, but that may be ok as
it's totally dependent on the iframe thing anyway.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
