https://bugzilla.wikimedia.org/show_bug.cgi?id=44875
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Blocks||47054
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=44875
Ċ½eljko Filipin zfili...@wikimedia.org changed:
What|Removed |Added
CC|zfili...@wikimedia.org |
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=44875
Antoine hashar Musso has...@free.fr changed:
What|Removed |Added
Priority|Unprioritized |Normal
https://bugzilla.wikimedia.org/show_bug.cgi?id=44875
--- Comment #5 from Matthew Flaschen mflasc...@wikimedia.org ---
You're right. The error message is not consistent with the actual behavior.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for
https://bugzilla.wikimedia.org/show_bug.cgi?id=44875
--- Comment #4 from Antoine hashar Musso has...@free.fr ---
Ah thanks for looking in codesniffer rules!
The Generic.PHP.CharacterBeforePHPOpeningTag rule looks almost like something
we could use. Unfortunately it complains whenever the
https://bugzilla.wikimedia.org/show_bug.cgi?id=44875
--- Comment #1 from Antoine hashar Musso has...@free.fr ---
Maybe something as lame as:
grep --perl-regexp '\s+\\?php' -R mediawiki/core
But that in turns return a tn of false positive since we have templates
using ?php :-D
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=44875
--- Comment #2 from Chad H. innocentkil...@gmail.com ---
(In reply to comment #1)
But that in turns return a tn of false positive since we have templates
using ?php :-D
Yeah, I was going to say, you'd want to check the first line only or
https://bugzilla.wikimedia.org/show_bug.cgi?id=44875
--- Comment #3 from Matthew Flaschen mflasc...@wikimedia.org ---
Yeah, I meant the first line, just forgot to say it.
I found a good way to do it. The relevant CodeSniffer rule is
Generic.PHP.CharacterBeforePHPOpeningTag.
I tested it with:
