https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Nemo federicol...@tiscali.it changed:
What|Removed |Added
CC||federicol...@tiscali.it
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #19 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 107112 had a related patch set uploaded by MarkAHershberger:
Changed FOR UPDATE handling in Postgresql
https://gerrit.wikimedia.org/r/107112
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 69767 merged by jenkins-bot:
Changed FOR UPDATE handling in Postgresql
https://gerrit.wikimedia.org/r/69767
--
You are receiving this mail because:
You are the
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #21 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 107112 merged by jenkins-bot:
Changed FOR UPDATE handling in Postgresql
https://gerrit.wikimedia.org/r/107112
--
You are receiving this mail because:
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Tyler Romeo tylerro...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Nemo federicol...@tiscali.it changed:
What|Removed |Added
CC||gla...@hallowelt.biz,
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Marcin Cieślak marcin.cies...@gmail.com changed:
What|Removed |Added
Blocks||57724
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 69767 restored by Parent5446:
Changed FOR UPDATE handling in Postgresql
Reason:
Why was this abandoned? It's my change.
https://gerrit.wikimedia.org/r/69767
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #16 from Fred Houweling f...@houweling.com.au ---
I agree with Marc,
It is broken the wrong way, there is still an issue that needs to be resolved.
(In reply to comment #15)
(In reply to comment #10)
PostgreSQL has an
extended
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 69767 abandoned by coren:
Changed FOR UPDATE handling in Postgresql
Reason:
Worked only because it was broken the right way. :-)
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #15 from Marc A. Pelletier m...@uberbox.org ---
(In reply to comment #10)
PostgreSQL has an
extended FOR UPDATE syntax. You can do FOR UPDATE OF mytable, which will
only
lock that table.
Hmm, no. FOR UPDATE OF isn't a postgres
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Keywords|patch-in-gerrit |
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Marcin Cieślak marcin.cies...@gmail.com changed:
What|Removed |Added
Blocks||49523
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Marcin Cieślak marcin.cies...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Marcin Cieślak marcin.cies...@gmail.com changed:
What|Removed |Added
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Pierre Bourdon delr...@gmail.com changed:
What|Removed |Added
CC||delr...@gmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Related URL: https://gerrit.wikimedia.org/r/69767 (Gerrit Change
I1ac587ac39f448b9e7f4befb44826b43044ad6f0)
--
You are receiving this mail because:
You are the
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #3 from Fred Houweling f...@houweling.com.au ---
Thanks Andre,
I did as you suggested.
https://gerrit.wikimedia.org/r/#/c/68143/
Regards
Fred
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Tyler Romeo tylerro...@gmail.com changed:
What|Removed |Added
CC||tylerro...@gmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #5 from OverlordQ overlo...@gmail.com ---
The problem is that PG *does* support FOR UPDATE, just limits it to cases that
make sense.
Why is the userJoinCond a LEFT JOIN when you're fetching rows for logged-in
users which should
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #6 from Tyler Romeo tylerro...@gmail.com ---
(In reply to comment #5)
The problem is that PG *does* support FOR UPDATE, just limits it to cases
that
make sense.
Then maybe an exception should be thrown instead, as a warning to
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Keywords|patch, patch-need-review|patch-in-gerrit
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
db duplicate...@googlemail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #8 from Tyler Romeo tylerro...@gmail.com ---
(In reply to comment #7)
That is wrong, because there is a rev_user = 0 on the join condition, so this
is false for anon editing. The query should always find a user row.
on the join
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #9 from Fred Houweling f...@houweling.com.au ---
Hi Thanks all for exploring options,
Some related discussions I found when researching the error:
http://www.postgresql.org/docs/9.1/interactive/sql-select.html#SQL-FOR-UPDATE-SHARE
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #10 from Tyler Romeo tylerro...@gmail.com ---
OK, so with all of this, I also noticed one more thing: PostgreSQL has an
extended FOR UPDATE syntax. You can do FOR UPDATE OF mytable, which will only
lock that table.
With that in
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Keywords||patch,
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
--- Comment #1 from Fred Houweling f...@houweling.com.au ---
i patched my Revision.php in the includes directory (1.21.1) with the
following:
# diff Revision.php.org Revision.php
355a356
global $wgDBtype;
363c364,366
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Priority|Unprioritized |High
29 matches
Mail list logo
