[Bug 47518] Thumbnails that are inline should break paragraphs

2013-07-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 C. Scott Ananian wikime...@cscott.net changed: What|Removed |Added Assignee|mtrac...@member.fsf.org

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Component|JS/General |General ---

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-06-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 ssas...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #14 from ssas...@wikimedia.org --- To further clarify: 123 figure/ 456 and p123/p figure/ p456/p render identically in the browser modulo any CSS styles set on p-tags. We verified this on en.wp.org and the difference is in a small

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #10 from Inez Korczyński i...@wikia-inc.com --- In VE we create new DOMDocument from htmldom that we receive from Parsoid and we don't want browser to modify it (break the flow) cause based on that DOMDocument we create our data

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #11 from Gabriel Wicke gwi...@wikimedia.org --- (In reply to comment #10) In VE we create new DOMDocument from htmldom that we receive from Parsoid and we don't want browser to modify it (break the flow) cause based on that

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #12 from Inez Korczyński i...@wikia-inc.com --- I so no reason to keep Parsoid and Parser outputs inconsistent for that case. Output 123figure/456 and p123/pfigure/p456/p will render differently in browser - and we want to avoid

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #13 from Gabriel Wicke gwi...@wikimedia.org --- (In reply to comment #12) I so no reason to keep Parsoid and Parser outputs inconsistent for that case. Output 123figure/456 and p123/pfigure/p456/p will render differently in

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 Mark Holmquist mtrac...@member.fsf.org changed: What|Removed |Added CC|

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #5 from Inez Korczyński i...@wikia-inc.com --- I agree with what Mark said in the first comment: Lorem [[File:Blargh|thumb]] ipsum should produce pLorem/p !--Thumbnail goes here-- pipsum/p Actually the most common usage that I

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #6 from Gabriel Wicke gwi...@wikimedia.org --- I tried ignoring figure and figcaption elements in the ParagraphWrapper: var isBlockToken = Util.isBlockToken(token) token.name !== 'figure' token.name

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 C. Scott Ananian mediaw...@cscott.net changed: What|Removed |Added CC|

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #8 from Gabriel Wicke gwi...@wikimedia.org --- See my comment above: Ours doesn't (HTML5 lib), FF's does. -- You are receiving this mail because: You are on the CC list for the bug. ___

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #9 from ssas...@wikimedia.org --- This should be possible to fix -- but requires additional tweaking of the p-wrapper. Tweaking the 'isBlockToken' by itself is insufficient since the output is wrapping everything in a single para

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-05-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Priority|Normal |Low -- You are

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-04-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/60378 (Gerrit Change I47ac2c0e73331bb6829427d58138984337df14e0) -- You are receiving this mail because: You are on the CC

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-04-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #2 from ssas...@wikimedia.org --- Ignore this -- I used the wrong bug id in the commit message. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l

[Bug 47518] Thumbnails that are inline should break paragraphs

2013-04-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47518 --- Comment #3 from Gabriel Wicke gwi...@wikimedia.org --- There is a trade-off between round-tripping and ease of editing / conformance to the PHP parser behavior here. You are right that the PHP parser creates two paragraphs, so it might make