[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|---

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #17 from Gerrit Notification Bot --- Change 119087 merged by jenkins-bot: Clarified the default link for image insertion. https://gerrit.wikimedia.org/r/119087 -- You are receiving this mail because: You are on the CC list for th

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #16 from Gerrit Notification Bot --- Change 119087 had a related patch set uploaded by Cscott: Clarified the default link for image insertion. https://gerrit.wikimedia.org/r/119087 -- You are receiving this mail because: You are

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 Gerrit Notification Bot changed: What|Removed |Added Status|RESOLVED|PATCH_TO_REVIEW Reso

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #14 from C. Scott Ananian --- mooeypoo and I tried to reproduce without success. the code looks correct: the link option is suppressed iff a[href] == img[resource]. Both of these should be local relative URLs, since the only way

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #13 from C. Scott Ananian --- Ok, from looking at the code I can confirm that the link= attribute should be suppressed iff the img[resource] attribute is equal to the a[href]. I'm guessing that autocommons is screwing with this? -

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #12 from C. Scott Ananian --- Hm, I note that the DOM spec describes "resource attribute on image" this way: > link to image resource page. TODO: what to use for images from commons? I'm guessing this is the root of the problem.

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian changed: What|Removed |Added Blocks||54844 -- You are receiving this ma

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #11 from C. Scott Ananian --- Hm, maybe this only occurs with images from commons now? Can you confirm that, James? It would be helpful to see exactly what VE is giving to Parsoid for new images, and how you are indicating that th

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-02-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 James Forrester changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Bug 49844] Images: New images get a link=… set whether or not they need it

2014-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug 49844] Images: New images get a link=… set whether or not they need it

2013-12-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #8 from C. Scott Ananian --- This should be fixed by https://gerrit.wikimedia.org/r/103082 (if it wasn't already fixed). Should be verified fixed by the VE team once this lands (and their local workaround reverted?). -- You are r

[Bug 49844] Images: New images get a link=… set whether or not they need it

2013-09-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian changed: What|Removed |Added CC||canan...@wikimedia.org As

[Bug 49844] Images: New images get a link=… set whether or not they need it

2013-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 Andre Klapper changed: What|Removed |Added Component|JS/General |General --- Comment #6 from Andre Klap

[Bug 49844] Images: New images get a link=… set whether or not they need it

2013-06-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 Gabriel Wicke changed: What|Removed |Added Priority|High|Normal -- You are receiving this mail

[Bug 49844] Images: New images get a link=… set whether or not they need it

2013-06-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #5 from James Forrester --- This is worked around (albeit with potentially a bit of a hack) in VisualEditor, so not so important now from VisualEditor's POV. -- You are receiving this mail because: You are on the CC list for the b

[Bug 49844] Images: New images get a link=… set whether or not they need it

2013-06-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 James Forrester changed: What|Removed |Added CC||i...@wikia-inc.com --- Comment #4 fr

[Bug 49844] Images: New images get a link=… set whether or not they need it

2013-06-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #3 from Gerrit Notification Bot --- Related URL: https://gerrit.wikimedia.org/r/70551 (Gerrit Change I75dbbfdd248a6f5696252ef3a2d7ca6ede0fa156) -- You are receiving this mail because: You are on the CC list for the bug. __

[Bug 49844] Images: New images get a link=… set whether or not they need it

2013-06-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 ssas...@wikimedia.org changed: What|Removed |Added Summary|Parsoid: New images get a |Images: New images get a