https://bugzilla.wikimedia.org/show_bug.cgi?id=55463

--- Comment #1 from Krinkle <krinklem...@gmail.com> ---
This is because LiquidThreads is relying on core edit.preview.js to bind the
click handler on the document.body.

I'll undo that part of the optimisation for now but this is really something
that LQT should fix.

A click handler on an element by the ID of '#wpPreview' is not a public API and
LQT has no business in trying to hijack that click.

The reason LQT could do this until now is because it basically reproduces most
of the EditPage HTML (including the exact HTML IDs and classes on buttons and
other form fields), except for the 'id="editform"' attribute on the form
element.

At first I thought adding that ID wouldn't help (since LQT creates it
dynamically and the core js would've already run) but actually it would fix it
because LQT loads the core javascript manually. It does need to take care to
re-use that element once bound, but that shouldn't be a problem.

In the short to medium term LQT developers should either not re-use this core
javascript file and just write a few lines that do the same, or write a patch
in core to make it a proper javascript interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to