https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 134049 merged by jenkins-bot:
(bug 56849) Deprecate dangerous edittime-based content update functions
https://gerrit.wikimedia.org/r/134049
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #11 from Adam Wight s...@ludd.net ---
Aha: so the 'redirect' thing was introduced to satisfy bug 24330, but along the
way the appendtext or prependtext requirement was lost in implementation,
commit 9f025aeb.
IMO this is a
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #12 from Adam Wight s...@ludd.net ---
@ASchulz: It looks like the CAS logic you suggested has already been
implemented, in WikiPage::updateRevisionOn(). I'm trying to provide the
$lastRevision param whenever possible, which should
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #13 from Adam Wight s...@ludd.net ---
I'm still working on the main patch, but these predecessors are ready for
review:
https://gerrit.wikimedia.org/r/#/c/133955 (also tracking under bug 24330)
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 134049 had a related patch set uploaded by Adamw:
(bug 56849) Deprecate dangerous edittime-based content update functions
https://gerrit.wikimedia.org/r/134049
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Adam Wight s...@ludd.net changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |ASSIGNED
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #10 from Adam Wight s...@ludd.net ---
I came across something disturbing while exploring the oldid fix: apparently,
there is a 'redirect' parameter to the edit action that allows a page save to
change the contents of the redirected
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #9 from Adam Wight s...@ludd.net ---
@aklapper: Thanks for linking the related bugs! I'm expanding my earlier patch
to clean up oldid handling and implement compare-and-swap as @aschulz suggests.
I expect that will resolve bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #7 from Andre Klapper aklap...@wikimedia.org ---
Patch didn't pass jenkins-bot.
Anybody planning to pick up the work on this again?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #8 from Andre Klapper aklap...@wikimedia.org ---
Plus wondering if fixing this would influence bug 53646, bug 53446, bug 42163.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #6 from Andre Klapper aklap...@wikimedia.org ---
Patch didn't pass jenkins-bot.
Anybody planning to pick up the work on this again?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Adam Wight s...@ludd.net changed:
What|Removed |Added
CC||s...@ludd.net
--- Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Jeroen De Dauw jeroen_ded...@yahoo.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Bartosz Dziewoński matma@gmail.com changed:
What|Removed |Added
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Aaron Schulz aschulz4...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Priority|Unprioritized |High
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #2 from Adam Wight s...@ludd.net ---
The solution should go beyond the above patch. Ideally, we remove the cheesy
timestamp check and rely entirely on an atomic update attempt. If that fails
due to a conflict, perhaps
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Nemo federicol...@tiscali.it changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Nemo federicol...@tiscali.it changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
--- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 94584 had a related patch set uploaded by Adamw:
(bug 56849) Pass true oldid for atomic page save
https://gerrit.wikimedia.org/r/94584
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
22 matches
Mail list logo
