https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135563 merged by Aaron Schulz:
Changed $article to be instance of WikiPage
https://gerrit.wikimedia.org/r/135563
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Florian florian.schmidt.wel...@t-online.de changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
glen...@gmail.com changed:
What|Removed |Added
CC||glen...@gmail.com
--- Comment #9
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #10 from glen...@gmail.com ---
If I do this:
if ( $page instanceof FlaggableWikiPage ) {
$article = $page;
} elseif ( $page instanceof WikiPage ) {
$article =
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Florian florian.schmidt.wel...@t-online.de changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #12 from glen...@gmail.com ---
(In reply to Florian from comment #11)
Because var article is an instance of class Artcile:
$article = new Article( $title );
Sorry, I wasn't clear. I know that, I just don't know why this class is
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #13 from Florian florian.schmidt.wel...@t-online.de ---
I haven't installed FlaggedRevs, so can maybe someone change simple Article to
WikiPage?
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #14 from glen...@gmail.com ---
Is it fairly safe to do so?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #15 from Florian florian.schmidt.wel...@t-online.de ---
If i were you, i would test this on a testwiki ;) But normally it's safe :) If
i have time, i will install flaggedrev and look :)
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #16 from Florian florian.schmidt.wel...@t-online.de ---
I have tested it now, seems to be the right change. I will commit it soon and
then we see, what the project owners say to it, if i'm right, that we can
simply change the class
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135563 had a related patch set uploaded by Florianschmidtwelzow:
Changed $article to be instance of WikiPage
https://gerrit.wikimedia.org/r/135563
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #18 from glen...@gmail.com ---
Nice, I tested it as well locally, and it seemed to work (although I only had
one page).
I will try it in production now, after I confirm that we have a backup.
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #19 from glen...@gmail.com ---
It seems to have worked fine. +1
Thanks for your help!
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Priority|Unprioritized |Normal
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Severity|critical|major
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #7 from Piotr piotr.kry...@wp.pl ---
Hi Andre,
This is the result from relative paths:
yoga:/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance
# php reviewAllPages.php --conf
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Summary|reviewAllPages.php doesn't
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #5 from Piotr piotr.kry...@wp.pl ---
PHP Notice was fixed.
ReviewAllPages.php still return message: First argument must be a Title or
WikiPage. and backtrace as in previous posts.
Could You please look at it?
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #4 from Piotr piotr.kry...@wp.pl ---
Hi Andre,
I have asked on it and http://www.mediawiki.org/wiki/Extension_talk:FlaggedRevs
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #3 from Andre Klapper aklap...@wikimedia.org ---
Hi Piotr, have you asked on https://www.mediawiki.org/wiki/Project:Support_desk
yet?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Piotr piotr.kry...@wp.pl changed:
What|Removed |Added
Version|unspecified |REL1_21 branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
23 matches
Mail list logo
