https://bugzilla.wikimedia.org/show_bug.cgi?id=68341
Bug ID: 68341
Summary: EventLogging dependency isn't so optional
Product: MediaWiki extensions
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Popups
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: mtrac...@member.fsf.org
CC: pandiculat...@gmail.com, psax...@wikimedia.org,
yuvipa...@gmail.com
Web browser: ---
Mobile Platform: ---
Looking through the code briefly, it looks like Popups conditionally loads the
schema module that EL uses, but loads the ext.popups.eventlogging.js
unconditionally and uses the functions defined there without any conditions as
well.
I'd suggest putting a check for the EventLogging library in front of the call
to mw.eventLog.logEvent() in that file...at the very least. Hopefully avoid
loading the file at all if EL is turned off.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
