[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 150202 had a related patch set uploaded by Thiemo Mättig (WMDE): Add UnDeserializableValue to DataModelSerializationRoundtripTest

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|RESOLVED

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 150202 merged by jenkins-bot: Add UnDeserializableValue to DataModelSerializationRoundtripTest https://gerrit.wikimedia.org/r/150202 -- You are receiving this

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 tobias.gritschac...@wikimedia.de changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #5 from Daniel Kinzler daniel.kinz...@wikimedia.de --- (In reply to Jeroen De Dauw from comment #3) Wow, this has 8 points? Nice. That means I can now take a day off I guess :) Well, just killing it makes it a lot easier, the 8

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Jeroen De Dauw jeroen_ded...@yahoo.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Daniel Kinzler daniel.kinz...@wikimedia.de changed: What|Removed |Added Priority|Unprioritized |High

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Lydia Pintscher lydia.pintsc...@wikimedia.de changed: What|Removed |Added CC|

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Lydia Pintscher lydia.pintsc...@wikimedia.de changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #2 from Jeroen De Dauw jeroen_ded...@yahoo.com --- The hash is not part of the value, this should never have been done by the deserializer. Killed by https://github.com/wmde/WikibaseDataModelSerialization/pull/72 -- You are

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #3 from Jeroen De Dauw jeroen_ded...@yahoo.com --- Wow, this has 8 points? Nice. That means I can now take a day off I guess :) -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #4 from Jeroen De Dauw jeroen_ded...@yahoo.com --- While this fixes the issue at hand, the way the snak hash is implemented sucks. Created a ticket https://github.com/wmde/WikibaseDataModel/issues/130 -- You are receiving this

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Jeroen De Dauw jeroen_ded...@yahoo.com changed: What|Removed |Added Status|ASSIGNED