https://bugzilla.wikimedia.org/show_bug.cgi?id=73672
Bug ID: 73672 Summary: Have vagrant provision run composer install Product: MediaWiki-Vagrant Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: Unprioritized Component: General Assignee: wikibugs-l@lists.wikimedia.org Reporter: gti...@wikimedia.org CC: dduv...@wikimedia.org, o...@wikimedia.org, yuvipa...@gmail.com Web browser: --- Mobile Platform: --- After running git pull on the /vagrant/mediawiki directory, I got this error: Fatal error: Class 'Cdb\Reader' not found in /vagrant/mediawiki/includes/cache/LocalisationCache.php on line XXX and while the reason was easy to guess (Cdb has been vendorized), I wasted some time figuring out what to do to update it (vagrant provision, vagrant reload, setup.sh, git pull on the vagrant repo...) as I thought the vendor directory is maintained by vagrant. I can see the logic in not updating automatically, as MediaWiki and extension code is also not updated automatically after the initial install; still I wonder if vagrant provision should always re-run composer install so that users have to remember one less thing. composer install does not touch already installed libraries, so no code gets updated without the user's consent, it just the ones which have been added to mediawiki/composer.json, and have not been installed at all yet. That seems fairly harmless to me, and in line with the general logic of vagrant doing the first install and not touching anything after that. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l