[Maniphest] [Changed CC] T815: Upstream Bugzilla XML-RPC API issue creates invalid XML our workaround hack damages attachments - hence apply our hack only on text comment output

2014-10-25 Thread Joe
Joe added a subscriber: Joe. Joe added a comment. I agree with petrb, although I think we should write a script that fetches comments text from the db, sanitize it in a sane language (not SQL), and update the comment. Should be easy doable and it's probably the right thing to do - but! Did

[Maniphest] [Changed CC] T815: Upstream Bugzilla XML-RPC API issue creates invalid XML our workaround hack damages attachments - hence apply our hack only on text comment output

2014-10-25 Thread valhallasw
valhallasw added a subscriber: valhallasw. valhallasw added a comment. Would it be an option to change ``` if (ref $initial eq '') { $initial =~ s/([\x01-\x08\x0b\x0c\x0f-\x1f])/sprintf \\x%02x,ord($1)/ge; } ``` to ``` if (ref $initial eq '') { $initial =~

[Maniphest] [Changed CC] T815: Upstream Bugzilla XML-RPC API issue creates invalid XML our workaround hack damages attachments - hence apply our hack only on text comment output

2014-10-24 Thread Qgil
Qgil added a subscriber: Amire80. TASK DETAIL https://phabricator.wikimedia.org/T815 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Qgil Cc: wikibugs-l, chasemp, Dzahn, QChris, Aklapper, Qgil, luser, Amire80

[Maniphest] [Changed CC] T815: Upstream Bugzilla XML-RPC API issue creates invalid XML our workaround hack damages attachments - hence apply our hack only on text comment output

2014-10-24 Thread jayvdb
jayvdb added a subscriber: jayvdb. TASK DETAIL https://phabricator.wikimedia.org/T815 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: jayvdb Cc: wikibugs-l, chasemp, Dzahn, QChris, Aklapper, Qgil, luser, Amire80, jayvdb

[Maniphest] [Changed CC] T815: Upstream Bugzilla XML-RPC API issue creates invalid XML our workaround hack damages attachments - hence apply our hack only on text comment output

2014-10-24 Thread Liuxinyu970226
Liuxinyu970226 added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T815 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Liuxinyu970226 Cc: wikibugs-l, chasemp, Dzahn, QChris, Aklapper, Qgil,

[Maniphest] [Changed CC] T815: Upstream Bugzilla XML-RPC API issue creates invalid XML our workaround hack damages attachments - hence apply our hack only on text comment output

2014-10-24 Thread Qgil
Qgil added a subscriber: Petrb. Qgil added a comment. Petr Bena via lists.wikimedia.org @petrb ? 2:20 PM (2 hours ago) to Wikimedia After short investigation the answer is pretty straight forward and explained in https://bugzilla.mozilla.org/show_bug.cgi?id=839023 quoting: U+-U+001F are

[Maniphest] [Changed CC] T815: Upstream Bugzilla XML-RPC API issue creates invalid XML our workaround hack damages attachments - hence apply our hack only on text comment output

2014-10-24 Thread ttkciar
ttkciar added a subscriber: ttkciar. ttkciar added a comment. Jeff Gage asked me to take a look on this problem. Here's a workaround, but it's a bit icky: ``` *** xmlrpc.cgi 2014-10-24 17:16:49.137457470 -0700 --- xmlrpc.cgi 2014-10-24 20:54:20.652451329 -0700 *** use