[Bug 58934] Fatal error: Call to a member function getPrefixedText() on a non-object at SpecialGlobalBlock.php on line 278
https://bugzilla.wikimedia.org/show_bug.cgi?id=58934 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 105889 had a related patch set uploaded by Tim Starling: Title::makeTitleSafe can return null https://gerrit.wikimedia.org/r/105889 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58934] Fatal error: Call to a member function getPrefixedText() on a non-object at SpecialGlobalBlock.php on line 278
https://bugzilla.wikimedia.org/show_bug.cgi?id=58934 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 105889 merged by jenkins-bot: Title::makeTitleSafe can return null https://gerrit.wikimedia.org/r/105889 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59753] New: Double-width brackets not fully parsed in pipe trick
https://bugzilla.wikimedia.org/show_bug.cgi?id=59753 Web browser: --- Bug ID: 59753 Summary: Double-width brackets not fully parsed in pipe trick Product: MediaWiki Version: 1.22.0 Hardware: All OS: All Status: NEW Severity: minor Priority: Unprioritized Component: Parser Assignee: wikibugs-l@lists.wikimedia.org Reporter: robinhoo...@live.ca Classification: Unclassified Mobile Platform: --- The following four links should all parse the same, but there's a missing check in Parser.php for double-width brackets prior to a single- or double-width comma. (Even if the namespace doesn't exist, copy-pasting these to any wiki should illustrate the problem.) * [[ns:page (context), context|]] * [[ns:page (context)， context|]] * [[ns:page （context）, context|]] * [[ns:page （context）， context|]] -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59750] Modules should export with their dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=59750 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low --- Comment #1 from Brad Jorsch bjor...@wikimedia.org --- Considering that dependencies can easily depend on the arguments passed to the #invoke, this seems rather difficult to pull off generally. It should more-or-less work if the module has a doc page that includes example invokes, though. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57866] Causes Incorrect password entered error when the account is globally locked
https://bugzilla.wikimedia.org/show_bug.cgi?id=57866 --- Comment #12 from Brad Jorsch bjor...@wikimedia.org --- (In reply to comment #11) The CentralAuth system was working as intended. Only if by working as intended you mean giving a misleading error message that sent people in the wrong direction trying to figure out why the user couldn't log in. The only thing changed here was the error message displayed to the user when their account is globally locked. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45539] Bugzilla's 'shell' keyword is too general
https://bugzilla.wikimedia.org/show_bug.cgi?id=45539 This, that and the other at.li...@live.com.au changed: What|Removed |Added CC||at.li...@live.com.au --- Comment #13 from This, that and the other at.li...@live.com.au --- (from bug 59711) I think the shell keyword should only be used for things that volunteers can't submit to gerrit, like requests to run maintenance script. That way it would help to focus what bugs the shell users themselves need to go and work on. Patches written by volunteers go to the Gerrit review queue, and the bugs have PATCH_TO_REVIEW status, so the shell keyword is redundant and needless for these bugs. I guess it is up to the shell users to decide how their keyword is used. It should reflect their workflow. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20523] Enable PovWatch on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=20523 This, that and the other at.li...@live.com.au changed: What|Removed |Added CC||at.li...@live.com.au Resolution|LATER |WONTFIX --- Comment #8 from This, that and the other at.li...@live.com.au --- Moving to WONTFIX: the community consensus of 2009 is no longer applicable today. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14277] Commons should have CM prefix that redirects to Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=14277 This, that and the other at.li...@live.com.au changed: What|Removed |Added CC||at.li...@live.com.au Resolution|LATER |WONTFIX --- Comment #10 from This, that and the other at.li...@live.com.au --- Moving old LATER bugs to appropriate resolutions. This issue is old and no longer relevant today. COM: is used across Commons as a namesacpe prefix shortcut. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13530] Apple-touch-icons on Wikimania sites have wrong link and do not exist at all
https://bugzilla.wikimedia.org/show_bug.cgi?id=13530 This, that and the other at.li...@live.com.au changed: What|Removed |Added CC||at.li...@live.com.au Resolution|LATER |WORKSFORME --- Comment #4 from This, that and the other at.li...@live.com.au --- Now working. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14626] mergehistory permission on Danish Wikipedia
https://bugzilla.wikimedia.org/show_bug.cgi?id=14626 This, that and the other at.li...@live.com.au changed: What|Removed |Added Status|RESOLVED|REOPENED CC||at.li...@live.com.au Resolution|LATER |--- --- Comment #4 from This, that and the other at.li...@live.com.au --- Moving old LATER bugs to appropriate resolutions. What is supposed to be enabled here? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57866] Causes Incorrect password entered error when the account is globally locked
https://bugzilla.wikimedia.org/show_bug.cgi?id=57866 --- Comment #13 from Bsadowski1 bsadowski1wikipe...@gmail.com --- No, I meant that *technically* it was working as it should have been. Locking has been primarily been used to keep out spambots and long-term abusers/vandals. What does new one look like, by the way? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59656] Better descriptions from showJobs.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=59656 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #1 from Bawolff (Brian Wolff) bawolff...@gmail.com --- I'm not sure. The script is meant for system administrators not users. It might be more appropriate to document this info on mw.org -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58435] Oracle: installer fails to create the main page; external links cause database error
https://bugzilla.wikimedia.org/show_bug.cgi?id=58435 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 105243 merged by jenkins-bot: Add sequence support for externallinks table https://gerrit.wikimedia.org/r/105243 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59754] New: Flow not respecting IP blocks on mediawiki.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=59754 Web browser: --- Bug ID: 59754 Summary: Flow not respecting IP blocks on mediawiki.org Product: MediaWiki extensions Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: Unprioritized Component: Flow Assignee: wikibugs-l@lists.wikimedia.org Reporter: b...@mzmcbride.com CC: ebernhard...@wikimedia.org, oke...@wikimedia.org, pandiculat...@gmail.com, sp...@wikimedia.org Classification: Unclassified Mobile Platform: --- Flow seems to not be respecting IP blocks. From [[mw:Special:RecentChanges]] (reverse chronological order): --- (topic) . . Talk:Sandbox; 05:27 . . 91.200.13.41 (talk) added a comment. (topic | post) . . Talk:Sandbox; 05:27 . . 91.200.13.41 (talk) created the topic pEXZhwJpPO. (topic | history) . . Talk:Sandbox; 05:26 . . PiRSquared17 hid the topic (junk). (topic | history) . . Talk:Sandbox; 05:26 . . PiRSquared17 hid a comment (spam ). (diff | hist) . . m Developer access; 05:25 . . (-5) . . Shirayuki (talk | contribs) (Undo revision 878987 by 210.22.145.214 (talk)) (topic | history) . . Talk:Sandbox; 05:25 . . Jasper Deng deleted the topic (spam). (diff | hist) . . m Developer access; 05:25 . . (-20) . . Shirayuki (talk | contribs) (Undo revision 878995 by 1.38.16.80 (talk)) (topic) . . Talk:Sandbox; 05:24 . . 91.200.13.41 (talk) added a comment. (topic | post) . . Talk:Sandbox; 05:24 . . 91.200.13.41 (talk) created the topic DjZaciUdjUX. (Block log); 05:23 . . Rschen7754 (talk | contribs) changed block settings for 91.200.13.41 (talk) with an expiry time of 05:05, 7 February 2014 (account creation blocked) (spam ?) (diff | hist) . . MediaWiki:Spam-blacklist; 05:21 . . (+11) . . Jasper Deng (talk | contribs) (emergency measure) (topic) . . Talk:Sandbox; 05:21 . . 91.200.13.41 (talk) added a comment. (topic | post) . . Talk:Sandbox; 05:21 . . 91.200.13.41 (talk) created the topic NKOYdUfztPPMJWC. --- -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59755] New: Flow not respecting spam blacklist on mediawiki.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=59755 Web browser: --- Bug ID: 59755 Summary: Flow not respecting spam blacklist on mediawiki.org Product: MediaWiki extensions Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: Unprioritized Component: Flow Assignee: wikibugs-l@lists.wikimedia.org Reporter: b...@mzmcbride.com CC: ebernhard...@wikimedia.org, oke...@wikimedia.org, pandiculat...@gmail.com, sp...@wikimedia.org Classification: Unclassified Mobile Platform: --- Flow apparently doesn't respect the [[mw:MediaWiki:Spam-blacklist]]. Eep. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59755] Flow not respecting spam blacklist on mediawiki.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=59755 --- Comment #1 from Oliver Keyes oke...@wikimedia.org --- Already a known; being fixed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59754] Flow not respecting IP blocks on mediawiki.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=59754 --- Comment #1 from Bingle bingle-ad...@wikimedia.org --- The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/692, but people from the community are welcome to contribute here and in Gerrit. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59006] Write a redis token driver for keystone
https://bugzilla.wikimedia.org/show_bug.cgi?id=59006 Ryan Lane rlan...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Ryan Lane rlan...@gmail.com --- I've added it to the repo and added puppet config for this. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59755] Flow not respecting spam blacklist on mediawiki.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=59755 --- Comment #2 from Bingle bingle-ad...@wikimedia.org --- The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/693, but people from the community are welcome to contribute here and in Gerrit. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59756] New: Flow does not update link tables
https://bugzilla.wikimedia.org/show_bug.cgi?id=59756 Web browser: --- Bug ID: 59756 Summary: Flow does not update link tables Product: MediaWiki extensions Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: Flow Assignee: wikibugs-l@lists.wikimedia.org Reporter: bawolff...@gmail.com CC: ebernhard...@wikimedia.org, oke...@wikimedia.org, pandiculat...@gmail.com, sp...@wikimedia.org Classification: Unclassified Mobile Platform: --- Flow does not seem to update links tables (tested with external links, and imagelinks). This means 2 things: *Pages that link here, image usage, etc won't work *When someone edits something else in the wiki (upload new version of a photo, delete a page [changing it to a redlink]), the page won't have its cache purged (I'm assuming that flow actually caches stuff, and that it hasn't totally re-implemented its own version of linkstables or something crazy like that). Example: https://www.mediawiki.org/w/index.php?title=Talk:Sandboxworkflow=050dacf79dbcc14b3c5090b11c2789df#flow-post-050dacfb4dca37944c8c842b2b782866 includes a picture but the usage is not recorded at https://www.mediawiki.org/wiki/File:Horses_of_the_Household_Cavalry_Mounted_Division_Exercising_on_the_Beaches_of_North_Norfolk_MOD_45156138.jpg#filelinks -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59756] Flow does not update link tables
https://bugzilla.wikimedia.org/show_bug.cgi?id=59756 --- Comment #1 from Bingle bingle-ad...@wikimedia.org --- The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/694, but people from the community are welcome to contribute here and in Gerrit. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59756] Flow does not update link tables
https://bugzilla.wikimedia.org/show_bug.cgi?id=59756 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Guess this is mostly a dupe *** This bug has been marked as a duplicate of bug 57512 *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57512] Flow: Special:WhatLinksHere doesn't register links from Flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=57512 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #2 from Bawolff (Brian Wolff) bawolff...@gmail.com --- *** Bug 59756 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57512] Flow: Special:WhatLinksHere doesn't register links from Flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=57512 --- Comment #3 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Duplicate of this bug: 59756 Not a precise dupe, but same cause, so I'll repeat my description from the other bug: Flow does not seem to update links tables (tested with external links, and imagelinks). This means 2 things: *Pages that link here, image usage, etc won't work *When someone edits something else in the wiki (upload new version of a photo, delete a page [changing it to a redlink]), the page won't have its cache purged (I'm assuming that flow actually caches stuff, and that it hasn't totally re-implemented its own version of linkstables or something crazy like that). Example: https://www.mediawiki.org/w/index.php?title=Talk:Sandboxworkflow=050dacf79dbcc14b3c5090b11c2789df#flow-post-050dacfb4dca37944c8c842b2b782866 includes a picture but the usage is not recorded at https://www.mediawiki.org/wiki/File:Horses_of_the_Household_Cavalry_Mounted_Division_Exercising_on_the_Beaches_of_North_Norfolk_MOD_45156138.jpg#filelinks -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57512] Flow not storing database *links (pagelinks, categorylinks, imagelinks, etc.)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57512 MZMcBride b...@mzmcbride.com changed: What|Removed |Added CC||b...@mzmcbride.com Summary|Flow: Special:WhatLinksHere |Flow not storing database |doesn't register links from |*links (pagelinks, |Flow|categorylinks, imagelinks, ||etc.) --- Comment #4 from MZMcBride b...@mzmcbride.com --- I believe this issue applies to all *links, so I've adjusted the bug summary. Without objection, this bug may turn into a tracking bug. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 --- Comment #11 from Nemo federicol...@tiscali.it --- (In reply to comment #10) (In reply to comment #8) For clarity, the current plan is Niklas' option 1 as per bug 46579 comment 17. Is it? 86b54375de7e, which was merged half a year ago, takes a completely different direction. That's only temporary, doing everything at once was too much. Anyway, if that option would be implemented, [...] then MediaWiki:Licenses should be moved to MediaWiki:Licenses/en. Yep, it should. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17553] LQT Call to a member function ... on a non-object at different places
https://bugzilla.wikimedia.org/show_bug.cgi?id=17553 Nemo federicol...@tiscali.it changed: What|Removed |Added Depends on||59757 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59757] New: Fatal error: Call to a member function getPrefixedText() on a non-object in Hooks.php on line 671
https://bugzilla.wikimedia.org/show_bug.cgi?id=59757 Web browser: --- Bug ID: 59757 Summary: Fatal error: Call to a member function getPrefixedText() on a non-object in Hooks.php on line 671 Product: MediaWiki extensions Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: LiquidThreads Assignee: wikibugs-l@lists.wikimedia.org Reporter: federicol...@tiscali.it CC: agarr...@wikimedia.org, jforres...@wikimedia.org Blocks: 17553 Classification: Unclassified Mobile Platform: --- I had this when importing the XML at bug 59739: Fatal error: Call to a member function getPrefixedText() on a non-object in /www/dev.translatewiki.net/w/extensions/LiquidThreads/classes/Hooks.php on line 671 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53015] Font support (tracker)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53015 Nemo federicol...@tiscali.it changed: What|Removed |Added Depends on||58203 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58203] Add railway-sans font for use on wikimania2014 wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=58203 Nemo federicol...@tiscali.it changed: What|Removed |Added CC||federicol...@tiscali.it Blocks||53015 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57811] Implementing volunteer testing tracking framework
https://bugzilla.wikimedia.org/show_bug.cgi?id=57811 Nemo federicol...@tiscali.it changed: What|Removed |Added CC||federicol...@tiscali.it, ||has...@free.fr, ||innocentkil...@gmail.com, ||krinklem...@gmail.com Component|Extensions requests |Continuous integration Product|MediaWiki extensions|Wikimedia -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45529] use composite indexes for efficient term search
https://bugzilla.wikimedia.org/show_bug.cgi?id=45529 --- Comment #10 from Sean Pringle sprin...@wikimedia.org --- Pulled from db1021 with the old wb_% indexes after a few hours of activity: +--++-++ | TABLE_SCHEMA | TABLE_NAME | INDEX_NAME | ROWS_READ | +--++-++ | wikidatawiki | wb_terms | tmp1| 905372478 | | wikidatawiki | wb_terms | wb_terms_entity_id | 1284769088 | | wikidatawiki | wb_terms | wb_terms_text | 365238 | | wikidatawiki | wb_terms | wb_terms_language | 85815191 | | wikidatawiki | wb_terms | wb_terms_search_key | 80851 | +--++-++ (tmp1 is roughly eqivalent to the proposed terms_search composite index) Turns out we need to keep some indexes with term_entity_id, term_text, and term_search_key in left-most positions, plus avoid having massive indexes (22G already, more for the new composites) except where Index Condition Pushdown (ICP) is useful. Therefore I propose these indexes instead: -- Some wb_terms queries not listed in the bug report use term_entity_id=N -- which is good selectivity. CREATE INDEX /*i*/terms_entity ON /*_*/wb_terms (term_entity_id); -- When any wb_terms query includes a search on term_text greater than -- four or five leading characters a simple index on term_text and -- language is often better than the proposed composite indexes. Note -- that it's fine to have term_language second as MariaDB still uses -- the entire key length even with LIKE '...%' on term_text. CREATE INDEX /*i*/terms_text ON /*_*/wb_terms (term_text, term_language); -- Same idea as above for terms_search_key. Not so much traffic as -- term_text but enough to be useful. CREATE INDEX /*i*/terms_search_key ON /*_*/wb_terms (term_search_key, term_language); -- The getMatchingIDs query is horrible when it has just one or two -- leading characters on term_search_key. This index is slightly -- different to the proposed term_search for better selectivity -- while still allowing ICP for short string values. CREATE INDEX /*i*/terms_search ON /*_*/wb_terms (term_language, term_entity_id, term_type, term_search_key(16)); The above indexes give reasonable performance on all wb_terms queries I can find and seems suitably generic enough for tables.sql. However, for wikidatawiki in production it's still not fast enough for all fringe cases due to the sheer dataset size. So, on db1026 I've partitioned wb_terms based on hash(term_language). This: 1) Lets the optimizer use partition pruning like a free first-stage index on term_language (because we use equality for term_language clauses). Reduces the number of rows read for many of our queries except those already using ICP. 2) Allows terms_text and terms_search_key to drop the second term_language field for slightly smaller footprints with comparable performance due to (1). More stuff fits in the buffer pool for longer, basically. 3) Speeds up writes to wb_terms on the slave because insert/update/delete only touches the smaller indexes in the relevant partition rather than the entire btrees (this is only a slight benefit, but I figure every bit to help reduce replag...) CREATE TABLE wb_terms ( ... KEY terms_entity (term_entity_id), KEY terms_text (term_text), KEY terms_search_key (term_search_key), KEY terms_search (term_language,term_entity_type,term_type,term_search_key(16)) ) ENGINE=InnoDB PARTITION BY KEY (term_language) PARTITIONS 16 Note that I left term_language in terms_search despite the partitions because getMatchingIDs query still benefits from ICP when term_search_key is used with a poorly performing short prefix: LIKE 'a%'. Partitions aren't suitable for tables.sql as we still say we support MySQL 5.0+, but I think it's worthwhile for this particular table on WMF production slaves. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
