[Bug 19474] Geshi CSS styles not included in Code Review

2011-03-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=19474

--- Comment #5 from Reedy s...@reedyboy.net 2011-03-19 01:37:50 UTC ---
(In reply to comment #3)
 The HTML output for comments is fetched via $wgOut-parse(), which throws away
 any head items or ResourceLoader modules specified in the ParserOutput object.
 
 Without redoing the entire output code for the code review pages, this might
 work:
 
 * change out $wgOut-parse() for 
 * call $wgOut-addParserOutputNoText($parserOutput) to add styles/etc
 ** note this will pass through language links and category links as well.
 Alternate: just do the head items/addModules but this feels icky. 
 * fetch the HTML with $parserOutput-getText() and use as before

Care to elaborate a bit more Brion?

Was just looking at this, and the idea doesn't seem complete...

ie Which parser output instance you are using, etc

Ta! :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 19474] Geshi CSS styles not included in Code Review

2011-02-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=19474

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 CC||s...@reedyboy.net

--- Comment #4 from Reedy s...@reedyboy.net 2011-02-25 16:05:40 UTC ---
*** Bug 27710 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 19474] Geshi CSS styles not included in Code Review

2011-01-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=19474

--- Comment #3 from Brion Vibber br...@pobox.com 2011-01-22 18:19:54 UTC ---
The HTML output for comments is fetched via $wgOut-parse(), which throws away
any head items or ResourceLoader modules specified in the ParserOutput object.

Without redoing the entire output code for the code review pages, this might
work:

* change out $wgOut-parse() for 
* call $wgOut-addParserOutputNoText($parserOutput) to add styles/etc
** note this will pass through language links and category links as well.
Alternate: just do the head items/addModules but this feels icky. 
* fetch the HTML with $parserOutput-getText() and use as before

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 19474] Geshi CSS styles not included in Code Review

2010-10-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=19474

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 AssignedTo|jschulz_4...@msn.com|wikibug...@lists.wikimedia.
   ||org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 19474] Geshi CSS styles not included in Code Review

2009-08-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=19474





--- Comment #2 from Niklas Laxström niklas.laxst...@gmail.com  2009-08-05 
06:40:01 UTC ---
When using source tags in review comments, they are not coloured.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 19474] Geshi CSS styles not included in Code Review

2009-08-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=19474


Brion Vibber br...@wikimedia.org changed:

   What|Removed |Added

 CC||br...@wikimedia.org




--- Comment #1 from Brion Vibber br...@wikimedia.org  2009-08-04 21:52:21 UTC 
---
Not sure I understand this; geshi syntax highlighting isn't used on this page
that I can see, so it's not surprising that the geshi styles aren't being
pulled in?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l