[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
CC||krinklem...@gmail.com
--- Comment #14 from Krinkle krinklem...@gmail.com ---
https://gerrit.wikimedia.org/r/#/c/113518/
(Mormegil Jul 11 18:04)
Patch Set 8:
This change broke all inline coordinates on cswiki (until I fixed the
template) because of a small wikitext interpretation change. Formerly,
“{{#switch:x|y=z|#default}}” would render empty, while currently, it
renders as “#default”. The input wikitext is arguably wrong (an equal sign
is missing there, it should be “...|#default=}}”), and it is debatable
what is _better_ behavior in that case. However, forgetting an equal sign is
an easy error to make, especially when it used to work fine.
The original behavior was more or less a random byproduct, I’d say. (Keeping
$test from “$mwDefault-matchStartAndRemove( $test )” to be used in the
final “return $test;”.) The current behavior is arguably more logical, but
in the name of backwards (bug-for-bug?) compatibility, we might want to do
“$lastItem = $decodedTest” next to “$defaultFound = true;”... Dunno.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
--- Comment #12 from Jesús Martínez Novo (Ciencia Al Poder)
martinezn...@gmail.com ---
Is there a bug open about {{#language:}} causing HTTP 500 errors? because the
true error is #language, not what has been fixed here. Under any circumstances
should a parser function throw an unhandled exception based on user input.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
--- Comment #13 from Jesús Martínez Novo (Ciencia Al Poder)
martinezn...@gmail.com ---
I've filed bug 67241 about the {{#language:}} issue, which I was unable to
reproduce locally.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
CC||martinezn...@gmail.com
See Also||https://bugzilla.wikimedia.
||org/show_bug.cgi?id=67196
Resolution|--- |FIXED
--- Comment #10 from Jesús Martínez Novo (Ciencia Al Poder)
martinezn...@gmail.com ---
How convenient :) Someone just reported this issue with PAGESINCATEGORY (now
filed as bug 67196)
The problem is really {{PAGENAME}}, although I'm thinking it was done to
prevent breaking HTML output when using {{PAGENAME}} inside HTML attributes
(for example, title=Explanation of {{PAGENAME}})
I'm wondering if this entity decoding should be done case by case or could be
done for all parser functions parameters?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
--- Comment #11 from Philippe Verdy verd...@wanadoo.fr ---
The problem affects templates trying to map a subpagename as a language code.
Currently {{#language:code1|code2}} causes a fatal server error (HTTP error
500) and all pages using that that template whose subpage name may contain an
ASCII single or quote quote or an ampersand: {{SUBPAGENAME}} HTML encodes these
characters with entities, and when this is used in the value of code2 above,
this will break.
To avoid this issue, we need a way to test if a subpagename can be a valid
language code before trying to use {{#language:}}.
One way to test it includes comparing the (SUB)PAGENAME with the result of
#titleparts, using a #ifeq: parser function call.
But if #ifeq: is HTML-decoding its compared items, it will alway reply that the
(SUB)PAGENAME and #titleparts are equal, so it will no longer be alble to
detect invalid language codes. As a result we'll get HTTP error 500 at amny
random pages using some templates when viewing a subpage including that
template and whose subpagename contains an apostrophe-quote, or double quote,
or a few other characters.
An alternative would require using a Lua module for testing the validity of
language codes. But in my opinion #language: MUST be urgently fixed to not
crash when there are HTML entities in its second parameter (if this occurs, it
should handle the case gracefull as if we specified an unknown/unsupported
target language code.
Note that this critical bug of #language occurs in very important pages,
notably many Main pages of wiki ˆprojects, or one of their subpages that are
transcluding a page trying to display a list of alternate languages, using the
content language of the current page (which may be translated).
As long as this critical bug of #language:, the fix for #ifeq: or
#switch: should be delayed (or be prapared to see lots of HTTP error 500 in
server logs and many pages not rendered at all.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 113518 merged by jenkins-bot: Decode html entities before comparing strings in #ifeq: and #switch https://gerrit.wikimedia.org/r/113518 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 113518 had a related patch set uploaded by Brian Wolff: Decode html entities before comparing strings in #ifeq: and #switch https://gerrit.wikimedia.org/r/113518 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
Bug 35628 depends on bug 35746, which changed state.
Bug 35746 Summary: {{PAGENAME}} must not escape special chars, otherwise it
makes {{#ifeq:}} unusable
https://bugzilla.wikimedia.org/show_bug.cgi?id=35746
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|--- |WONTFIX
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
Bug 35628 depends on bug 35746, which changed state.
Bug 35746 Summary: {{PAGENAME}} must not escape special chars, otherwise it
makes {{#ifeq:}} unusable
https://bugzilla.wikimedia.org/show_bug.cgi?id=35746
What|Old Value |New Value
Status|RESOLVED|REOPENED
Resolution|DUPLICATE |
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628 Beta16 l.rabinelli+bugzi...@gmail.com changed: What|Removed |Added CC||l.rabinelli+bugzilla@gmail. ||com --- Comment #5 from Beta16 l.rabinelli+bugzi...@gmail.com 2012-04-06 07:26:16 UTC --- See also bug 35746 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628 Niklas Laxström niklas.laxst...@gmail.com changed: What|Removed |Added Depends on||35746 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
Mark A. Hershberger m...@everybody.org changed:
What|Removed |Added
CC||dann...@email.cz
Bug 35628 depends on bug 35746, which changed state.
Bug 35746 Summary: {{PAGENAME}} must not escape special chars, otherwise it
makes {{#ifeq:}} unusable
https://bugzilla.wikimedia.org/show_bug.cgi?id=35746
What|Old Value |New Value
Status|NEW |RESOLVED
Resolution||DUPLICATE
--- Comment #6 from Mark A. Hershberger m...@everybody.org 2012-04-06
14:30:43 UTC ---
*** Bug 35746 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
Philippe Verdy verd...@wanadoo.fr changed:
What|Removed |Added
CC||verd...@wanadoo.fr
--- Comment #7 from Philippe Verdy verd...@wanadoo.fr 2012-04-06 19:25:39 UTC
---
a swtich should not make the difference between a character that is represented
by a numeric character reference of natively.
so if a templace is encoded like this:
{{#switch:{{{1|}}}|#x40;=yes|#default=no}}
or like this:
{{#switch:{{{1|}}}|@=yes|#default=no}}
this should work equally when passing it the parameter 1=@ or 1=#x40; or
1=#64;
All numeric character references (plus some wellknown named character
references that are warrantied to be suppoorted everywhere in XML and HTML;
i.e. the 5 standard ones: amp; lt; gt; quot; pos;) should be treated
everywhere as counting for 1 Unicode character (excactly like the UTF-8
sequences of bytes represening this character). All valid syntaxes for numeric
character references should be accepted (decimal and hexadecimal), as long as
they designate a valid Unicode code point (in the valid numeric range from
U+ to U+10), and that code point is assigned to a valid character
(excluding codepoints assigned to surrogates, and codepoints assigned to
non-characters like U+FFFE), and that character can be part of a valid HTML
document (so, excluding most C0 and C1 controls, and converting all the few
acceptable controls only as SPACE U+0020 or LINEFEED U+000A after unification
of CR+LF into a single linefeed).
This should be a simple way to escape every character, deprecating the use of
nowiki, ecept as an esay way that avoids using character references in the
source.
But character references should be usable EVERYWHERE a valid UTF-8 sequence
representing a single character is usable and not absolutely needed by the
syntaxic lexer/parser (so including in the name of parser functions and magic
keywords, meaning that {{##75;f:x|y}} will be treated equivalently to
{{#if:x|y}}. This would make the wiki syntax more compatible with various
character encodings, including via imports/exports to external files.
This also means that only a few characters should NOT be representable as
character references, these are:
{ }
only where they are used as separators for the recognized wiki template call
and parameters syntax, and:
| =
only within template (or parserfunction) parameters in the wiki syntax, and:
: ; *
only where they are recognized at the begining of lines for lists in the wiki
syntax, and:
| !
where they are recognized within wiki tables for delimiting cells/rows, and:
'
where they are used as separators for the recognized markup syntax of HTML
elements or special elements like nowiki ... /, includeonly ... / and
gallery ... /.
In this later case, character entities should be usable as the universal way of
escaping the special handling given by the wiki syntax parser.
To make things simple, the lexer used in MEdiaWiki should uniformize all input
characters (whever they are encoded as UTF-8 sequences or as numeric or named
character entities) into a single format, even before staring to parse the
content: only the special characters needed for one step should be treated
specially, and kept in their syntaxic format, all others will be uniformized by
NOT using any of these special characters (if they remain present in the
source, the uniformized format should be the smallest decimal numeric character
reference). This would also avoid the unnecessary complexity caused by
nowiki. All parser functions should be revisited to make sure they use this
character uniformizer...
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628
Mark A. Hershberger m...@everybody.org changed:
What|Removed |Added
Summary|#switch or #ifeq: |#switch or #ifeq: checks
|{{PAGENAME}} doesn't work |should be HTML escaped
|with title containing |
|apostrophe |
Severity|normal |enhancement
--- Comment #3 from Mark A. Hershberger m...@everybody.org 2012-04-04
14:20:53 UTC ---
Thinking about this, I'm not sure if it would make sense to fix this -- it
might cause problems for others.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35628] #switch or #ifeq: checks should be HTML escaped
https://bugzilla.wikimedia.org/show_bug.cgi?id=35628 --- Comment #4 from Mark A. Hershberger m...@everybody.org 2012-04-04 15:10:11 UTC --- See also bug 16474 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
