https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |ASSIGNED
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Chris Steipp cste...@wikimedia.org changed:
What|Removed |Added
Priority|Highest |Normal
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #35 from Chris Steipp cste...@wikimedia.org ---
The only remaining thing would be to (very carefully) return a cached response
from Varnish for loginwiki's /checkLoggedIn, if the user doesn't have any
loggin cookies, since we return
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #34 from Faidon Liambotis fai...@wikimedia.org ---
These were all deployed and the effect is nicely visualized here:
https://ganglia.wikimedia.org/latest/stacked.php?c=Application+servers+eqiadhost_regex=m=ap_rpsr=yearst=1388322880
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #30 from Chris Steipp cste...@wikimedia.org ---
(In reply to comment #29)
It's very odd that /createSession is more popular than /checkLoggedIn, since
/checkLoggedIn redirecting to /createSession is the only way /createSession
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #31 from Faidon Liambotis fai...@wikimedia.org ---
On a sample of 100k requests, /createSession matched 3650 times, while
/checkLoggedIn 3679 times (this is literally greps, not filtered per domain
or query params). I tried 3
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #32 from Chris Steipp cste...@wikimedia.org ---
Thanks Faidon, that is exactly what I was expecting. Just wanted to confirm.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #33 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 100508 merged by jenkins-bot:
Don't redirects anons to /createSession
https://gerrit.wikimedia.org/r/100508
--
You are receiving this mail because:
You are on
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #27 from Chris Steipp cste...@wikimedia.org ---
I updated 1.23wmf5 (including enwiki) to include the patch that removes calls
to /start for anons. After that, Faidon was looking at the logs and observed:
paravoid
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #28 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 100508 had a related patch set uploaded by CSteipp:
Don't redirects anons to /createSession
https://gerrit.wikimedia.org/r/100508
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #29 from Brad Jorsch bjor...@wikimedia.org ---
(In reply to comment #27)
paravoid
/wiki/Special:CentralAutoLogin/createSession?gu_id=0type=scriptproto=http
is
first
paravoid
/wiki/Special:CentralAutoLogin/
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #26 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 98461 merged by jenkins-bot:
Don't localize Special:CentralAutoLogin
https://gerrit.wikimedia.org/r/98461
--
You are receiving this mail because:
You are on
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #25 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 98461 had a related patch set uploaded by Anomie:
Don't localize Special:CentralAutoLogin
https://gerrit.wikimedia.org/r/98461
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Bug 54195 depends on bug 57223, which changed state.
Bug 57223 Summary: CentralAuth $wgSecureLogin redirect is uncacheable
https://bugzilla.wikimedia.org/show_bug.cgi?id=57223
What|Removed |Added
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #24 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 95609 merged by jenkins-bot:
Skip Special:CentralAutoLogin/start for JS anons
https://gerrit.wikimedia.org/r/95609
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Tim Starling tstarl...@wikimedia.org changed:
What|Removed |Added
Depends on||57223
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Faidon Liambotis fai...@wikimedia.org changed:
What|Removed |Added
Priority|High|Highest
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #21 from Faidon Liambotis fai...@wikimedia.org ---
Oh, and the for the record, the top 5 from Varnish backends, i.e. frontend
misses, which filters out cacheable hotspots:
6964.24 RxURL
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #22 from Brad Jorsch bjor...@wikimedia.org ---
Unless the client lacks/blocks localStorage and cookies, it should be one
pageview per client per site visited per day that is hitting
/start?type=script,
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #23 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 95609 had a related patch set uploaded by Anomie:
Skip Special:CentralAutoLogin/start for JS anons
https://gerrit.wikimedia.org/r/95609
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #19 from Chris Steipp cste...@wikimedia.org ---
Any updates Faidon? I'm curious to know if you found anything, so we can make
sure this is as minimal load on the apaches as possible.
--
You are receiving this mail because:
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #18 from Faidon Liambotis fai...@wikimedia.org ---
Yes, the redirects should vary on XFP, but right now it won't have any effect,
since these redirects also come with Cache-Control: private so they're not
cached anyway.
I guess
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #16 from Faidon Liambotis fai...@wikimedia.org ---
What do you mean on the user being logged in? Is it a preference (Cookie?),
geolocation data for the IP or something else? We could likely enforce some
logic with Vary/XVO/Varnish
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #17 from Brad Jorsch bjor...@wikimedia.org ---
(In reply to comment #15)
Faidon also mentioned on irc that he was seeing http-https redirects. We
wouldn't want to cache those, since those are based on the user being logged
in.
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Faidon Liambotis fai...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #15 from Chris Steipp cste...@wikimedia.org ---
This looks like another issue, since the user is just being redirected to a
translated page name. That seems like it would be a safe redirect for mediawiki
to cache, and we probably
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 86265 had a related patch set uploaded by Anomie:
For caching, avoid passing returnto to Special:CentralAutoLogin
https://gerrit.wikimedia.org/r/86265
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 86265 merged by jenkins-bot:
For caching, avoid passing returnto to Special:CentralAutoLogin
https://gerrit.wikimedia.org/r/86265
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #5 from Faidon Liambotis fai...@wikimedia.org ---
CentralAutoLogin traffic is still 50% of all Apache traffic, so no huge
effect there.
CentralAutoLogin/start is 27.5% in my small sample, however this has little to
do with
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Chris Steipp cste...@wikimedia.org changed:
What|Removed |Added
Status|RESOLVED|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 86207 had a related patch set uploaded by CSteipp:
Remove returnto for basic login test
https://gerrit.wikimedia.org/r/86207
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #8 from Brad Jorsch bjor...@wikimedia.org ---
(In reply to comment #6)
Brad, do remember why we add returnto and returntoquery in
centralautologin.js
for non-login pages? It's not used except when we get to the /setCookies
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 86207 abandoned by CSteipp:
Remove returnto for basic login test
Reason:
We'll find a better solution
https://gerrit.wikimedia.org/r/86207
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #10 from Chris Steipp cste...@wikimedia.org ---
(In reply to comment #8)
(In reply to comment #6)
Brad, do remember why we add returnto and returntoquery in
centralautologin.js
for non-login pages? It's not used except when
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Brad Jorsch bjor...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
--- Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Chris Steipp cste...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85036 had a related patch set uploaded by CSteipp:
Set Squid maxage so proxies will cache
https://gerrit.wikimedia.org/r/85036
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85036 merged by jenkins-bot:
Set Squid maxage so proxies will cache
https://gerrit.wikimedia.org/r/85036
--
You are receiving this mail because:
You are on the
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
--- Comment #3 from Chris Steipp cste...@wikimedia.org ---
Faidon, Tim, or Mark, it would be good if you guys could take a look at gerrit
85036 too, and just make sure Brad and my assumptions about squid / varnish are
correct. If anything
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Keywords||performance
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195
Chris Steipp cste...@wikimedia.org changed:
What|Removed |Added
Priority|Unprioritized |High
--
You are
46 matches
Mail list logo
