[Bug 56402] Exit lightbox when clicking on backdrop

2014-08-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

--- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 118667 abandoned by MarkTraceur:
Exit Lightbox when clicked on Backdrop

Reason:
We tried doing this once before, it was just confusing and overall interfered
with other actions in the viewer.

https://gerrit.wikimedia.org/r/118667

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2014-03-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

Mark Holmquist mtrac...@member.fsf.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #11 from Mark Holmquist mtrac...@member.fsf.org ---
For good reason.

We decided that this causes way too many accidental lightbox close events, and
reverted.

WONTFIXing for now - we may revisit this later, but it won't be for the next
few months.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2014-03-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

Tony Thomas 01tonytho...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #9 from Tony Thomas 01tonytho...@gmail.com ---
Looks like the patch was lost after 
https://gerrit.wikimedia.org/r/#/c/116921/
Reverting bug to open

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2014-03-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|REOPENED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2014-03-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

--- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 118667 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on Backdrop

https://gerrit.wikimedia.org/r/118667

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2014-02-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

--- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 108317 merged by jenkins-bot:
Exit Lightbox when clicked on backdrop

https://gerrit.wikimedia.org/r/108317

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2014-02-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

Tony Thomas 01tonytho...@gmail.com changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2014-01-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 108317 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on backdrop

https://gerrit.wikimedia.org/r/108317

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2014-01-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 103902 abandoned by 01tonythomas:
Exit Lightbox when clicked on backdrop

Reason:
persistent rebase errors 
Continued in 
https://gerrit.wikimedia.org/r/#/c/108317/

https://gerrit.wikimedia.org/r/103902

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2013-12-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

--- Comment #3 from Tony Thomas 01tonytho...@gmail.com ---
@Mark: Please elaborate the same so that someone can work on it please.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2013-12-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

--- Comment #4 from Mark Holmquist mtrac...@member.fsf.org ---
Sorry! The idea is, if someone clicks on the black area behind the image, the
lightbox should close. There are already close methods that are fairly general,
so the only work involved *should* be adding an event listener in the right
spot, and clearing it properly.

Let me know if you need any help :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2013-12-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

Tony Thomas 01tonytho...@gmail.com changed:

   What|Removed |Added

   Assignee|wikibugs-l@lists.wikimedia. |01tonytho...@gmail.com
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2013-12-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 103902 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on backdrop

https://gerrit.wikimedia.org/r/103902

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2013-12-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2013-12-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

MZMcBride b...@mzmcbride.com changed:

   What|Removed |Added

   Keywords||easy
 CC||b...@mzmcbride.com

--- Comment #2 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #0)
 Suggestion from legoktm - should be fairly easy.

Please use comment 0, also known as the bug description, to describe the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2013-11-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

Mark Holmquist mtrac...@member.fsf.org changed:

   What|Removed |Added

   Priority|Normal  |Low
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2013-10-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

--- Comment #1 from Quiddity pandiculat...@gmail.com ---
Suggestion from moi!  ;p   3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56402] Exit lightbox when clicking on backdrop

2013-10-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56402

Fabrice Florin fflo...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l