[Bug 58086] mw.MwEmbedSupport.style should only load on the pages that need it
https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com --- Comment #6 from Bartosz Dziewoński matma@gmail.com --- This was resolved by the fixes for bug 0, no? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58086] mw.MwEmbedSupport.style should only load on the pages that need it
https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Matthew Flaschen mflasc...@wikimedia.org --- It looks like it's no longer being loaded unconditionally; see https://gerrit.wikimedia.org/r/#/c/145584/2/MwEmbedSupport.hooks.php -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58086] mw.MwEmbedSupport.style should only load on the pages that need it
https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 Nemo federicol...@tiscali.it changed: What|Removed |Added CC||federicol...@tiscali.it --- Comment #4 from Nemo federicol...@tiscali.it --- (In reply to Ori Livneh from comment #2) My preference -- for this and for the JavaScript payload which accompanies it -- would be to expose them by reverting the load-everywhere workaround, and then wait for the bugs to trickle in. Sounds sensible. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58086] mw.MwEmbedSupport.style should only load on the pages that need it
https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58086] mw.MwEmbedSupport.style should only load on the pages that need it
https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 --- Comment #3 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to comment #2) (In reply to comment #1) Given ResourceLoader, this should be pretty easy, right? The difficulty is correctly identified in a comment in TimedMediaHandler.hooks.php: // We should probably move this script output to a parser function but not working correctly in // dynamic contexts ( for example in special upload, when there is an existing file warning. ) In other words, it's trivial to only include the stylesheet on article pages that contain timed media, but that doesn't cover cases in which a page's content is loaded via AJAX and injected into the current page. There are probably only a few such dynamic cases. My preference -- for this and for the JavaScript payload which accompanies it -- would be to expose them by reverting the load-everywhere workaround, and then wait for the bugs to trickle in. Special:upload would be the main example. Also possible when fetching file desc from commons on a foreign image (if for example desc includes video but image isn't one) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58086] mw.MwEmbedSupport.style should only load on the pages that need it
https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 MZMcBride b...@mzmcbride.com changed: What|Removed |Added Keywords||easy, performance --- Comment #1 from MZMcBride b...@mzmcbride.com --- Given ResourceLoader, this should be pretty easy, right? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58086] mw.MwEmbedSupport.style should only load on the pages that need it
https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 --- Comment #2 from Ori Livneh o...@wikimedia.org --- (In reply to comment #1) Given ResourceLoader, this should be pretty easy, right? The difficulty is correctly identified in a comment in TimedMediaHandler.hooks.php: // We should probably move this script output to a parser function but not working correctly in // dynamic contexts ( for example in special upload, when there is an existing file warning. ) In other words, it's trivial to only include the stylesheet on article pages that contain timed media, but that doesn't cover cases in which a page's content is loaded via AJAX and injected into the current page. There are probably only a few such dynamic cases. My preference -- for this and for the JavaScript payload which accompanies it -- would be to expose them by reverting the load-everywhere workaround, and then wait for the bugs to trickle in. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58086] mw.MwEmbedSupport.style should only load on the pages that need it
https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 Ori Livneh o...@wikimedia.org changed: What|Removed |Added CC||o...@wikimedia.org Blocks||0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
