[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2014-02-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

Maryana Pinchuk mpinc...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2014-01-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 105123 merged by jenkins-bot:
Fix issues on clicking x comments link

https://gerrit.wikimedia.org/r/105123

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2014-01-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2014-01-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 105123 had a related patch set uploaded by Bsitu:
Fix issues on clicking x comments link

https://gerrit.wikimedia.org/r/105123

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2013-12-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

--- Comment #4 from Andrew Garrett agarr...@wikimedia.org ---
Yeah, my impression here was wrong. Looking at it now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2013-12-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

Andrew Garrett agarr...@wikimedia.org changed:

   What|Removed |Added

 CC||agarr...@wikimedia.org,
   ||mmul...@wikimedia.org

--- Comment #3 from Andrew Garrett agarr...@wikimedia.org ---
I'm quite confused by this bug.

It's happening directly because of the don't let users submit until the
textbox has something in it feature. For some reason it thinks that the
textbox is always empty.

When you set a breakpoint on the appropriate spot in ext.flow.editor.none.js,
you find that this.$node is a whole bunch of different textareas.

Further investigation indicates that the node that an editor is responsible for
is stored inside the editor itself, which is fine until you realise that that
editor is reused for all of the nodes. So how does the editor know which of the
nodes to check for text in?

Yet, when you open a number of different editors across the page, they all seem
to work correctly. So clearly it's working *somehow*.

Adding Matthias to CC, since he wrote most of the editor code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2013-12-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

--- Comment #2 from Oliver Keyes oke...@wikimedia.org ---
Oh no :/. Browser/OS?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2013-12-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

Oliver Keyes oke...@wikimedia.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2013-12-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

Oliver Keyes oke...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High
   Severity|minor   |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58372] Flow: Can't reply to a thread after clicking the Comment(4) link in header.

2013-12-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58372

--- Comment #1 from Bingle bingle-ad...@wikimedia.org ---
The WMF core features team tracks this bug on Mingle card
https://mingle.corp.wikimedia.org/projects/flow/cards/614, but people from the
community are welcome to contribute here and in Gerrit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l