[Bug 60372] Redirects to oldid URI sometimes to wrong wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=60372 --- Comment #7 from Marek Blahuš wikipe...@blahus.cz --- This seems fixed now, or at least the issue does not reappear in my case. Thank you, Gabriel, for taking care of this! -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60372] Redirects to oldid URI sometimes to wrong wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=60372 --- Comment #2 from Marek Blahuš wikipe...@blahus.cz --- A user has announced a new occurence of this bug and my new debugging code has logged additional data. Here's what I have: On Wed, 29 Jan 2014 at 14:07:05 UTC, the following URL was requested: http://parsoid-lb.eqiad.wikimedia.org/skwiki/Hrabovka%20%28okres%20Tren%C4%8D%C3%ADn%29 The response from the server, however, included the following incorrect header (change of wiki): Location: /itwiki/Hrabovka_(okres_Tren%C4%8D%C3%ADn)?oldid=5594963 Therefore, the returned content (the redirect was automatically followed) from that new URI was an article from itwiki with the oldid of the intented article on skwiki, i.e. this article: https://it.wikipedia.org/w/index.php?title=Discussioni_utente:Kynoppyoldid=5594963 Indeed, apart from the different PAGENAME (the provided title Hrabovka (okres Trenčín) was used during the rendering and this modified the output of the welcome template on that particular user talk page), the returned content is the same as received by calling http://parsoid.wmflabs.org/itwiki/Discussioni%20utente:Kynoppy?oldid=5594963 Therefore, I can confirm that the bug occurs already when constructing the redirect header or earlier. As a work-around, I can check the Location header and repeat the request if it was redirected off-wiki. This could prevent the user from receiving incorrect output and let us know whether the issue is completely accidental or persists across several timely close requests. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60372] Redirects to oldid URI sometimes to wrong wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=60372 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Gabriel Wicke gwi...@wikimedia.org --- Thanks for investigating this. So it is indeed the redirect that is at fault here. I'll look into it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60372] Redirects to oldid URI sometimes to wrong wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=60372 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 110233 had a related patch set uploaded by GWicke: Bug 60372: Work around express bug that clobbered res.locals https://gerrit.wikimedia.org/r/110233 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60372] Redirects to oldid URI sometimes to wrong wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=60372 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60372] Redirects to oldid URI sometimes to wrong wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=60372 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 110233 merged by jenkins-bot: Bug 60372: Fix use of res.local function https://gerrit.wikimedia.org/r/110233 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60372] Redirects to oldid URI sometimes to wrong wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=60372 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Gabriel Wicke gwi...@wikimedia.org --- This is now fixed in master. The fix will likely be deployed to production next week. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60372] Redirects to oldid URI sometimes to wrong wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=60372 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60372] Redirects to oldid URI sometimes to wrong wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=60372 --- Comment #1 from Gabriel Wicke gwi...@wikimedia.org --- The redirect response itself is never cached, and requesting the correct URL with oldid seems to work fine. That leads me to believe that Parsoid sometimes redirects to the wrong full URI (e.g. /plwiki/Dolný Vadičov?oldid=5594681). Interestingly, http://parsoid-lb.eqiad.wikimedia.org/plwiki/Doln%C3%BD_Vadi%C4%8Dov?oldid=5594681 was in cache: X-Cache:cp1045 hit (1), cp1058 frontend miss (0) So somebody requested that page and version recently. Since that is a very old revision and the title is actually from skwiki it seem unlikely that this happened by chance. The oldid always wins over the title, which explains why the article with a different name is returned. A possible work-around is to pass in the oldid explicitly. That avoids the redirect altogether. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
