[Bug 62540] Media Viewer: Possible to bypass the Media Viewer and go to file description page if page is not fully loaded
https://bugzilla.wikimedia.org/show_bug.cgi?id=62540 Gilles Dubuc gdu...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Gilles Dubuc gdu...@wikimedia.org --- https://gerrit.wikimedia.org/r/#/c/121629/ https://gerrit.wikimedia.org/r/#/c/122446/ -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62540] Media Viewer: Possible to bypass the Media Viewer and go to file description page if page is not fully loaded
https://bugzilla.wikimedia.org/show_bug.cgi?id=62540 Gilles Dubuc gdu...@wikimedia.org changed: What|Removed |Added CC||gdu...@wikimedia.org --- Comment #6 from Gilles Dubuc gdu...@wikimedia.org --- There is a foolproof technical solution for this: an inline onclick handler defined in the HTML that replays the click when the DOM is loaded. Shoving all the mmv bootstrap code in the head is inefficient and it wouldn't solve the problem: on a cold cache it still takes time to download the JS file, and you might see the DOM appear on the page before the JS is actually loade executed. So there would still be a chance to trigger this situation. The window would be smaller, but it could still happen. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62540] Media Viewer: Possible to bypass the Media Viewer and go to file description page if page is not fully loaded
https://bugzilla.wikimedia.org/show_bug.cgi?id=62540 --- Comment #7 from Gilles Dubuc gdu...@wikimedia.org --- And by replay I mean that it would of course swallow the original click that happens before the DOM is ready and replay it on DOM readiness. I didn't mean having the event twice for a single click. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62540] Media Viewer: Possible to bypass the Media Viewer and go to file description page if page is not fully loaded
https://bugzilla.wikimedia.org/show_bug.cgi?id=62540 --- Comment #5 from Mark Holmquist mtrac...@member.fsf.org --- Actually, I may have been thinking about this wrong - we *do* change visual things above the fold when a hash fragment is detected, so maybe we should actually be top-loading. We will talk about this tomorrow at the planning meeting, I think. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62540] Media Viewer: Possible to bypass the Media Viewer and go to file description page if page is not fully loaded
https://bugzilla.wikimedia.org/show_bug.cgi?id=62540 --- Comment #1 from Mark Holmquist mtrac...@member.fsf.org --- I don't think we can do anything currently to make the loading any faster, but Gilles may beg to differ. FWIW I asked Krinkle about loading MMV top-side and he said it wasn't necessary, so that's not our path forward. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62540] Media Viewer: Possible to bypass the Media Viewer and go to file description page if page is not fully loaded
https://bugzilla.wikimedia.org/show_bug.cgi?id=62540 Dan Garry dga...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low Severity|normal |minor --- Comment #2 from Dan Garry dga...@wikimedia.org --- I've set the priorities on this based on Mark's comments. Anyone involved in the development of Media Viewer should feel free to revise as necessary. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62540] Media Viewer: Possible to bypass the Media Viewer and go to file description page if page is not fully loaded
https://bugzilla.wikimedia.org/show_bug.cgi?id=62540 --- Comment #3 from Tisza Gergő gti...@wikimedia.org --- MMV is just a 16K bootstrap file now, so top-loading it does not sound that bad to me. I don't see other options apart from wontfixing this - until it is not loaded, we cannot interfere in any way with what an image click does. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62540] Media Viewer: Possible to bypass the Media Viewer and go to file description page if page is not fully loaded
https://bugzilla.wikimedia.org/show_bug.cgi?id=62540 Dan Garry dga...@wikimedia.org changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #4 from Dan Garry dga...@wikimedia.org --- (In reply to Tisza Gergő from comment #3) MMV is just a 16K bootstrap file now, so top-loading it does not sound that bad to me. I don't see other options apart from wontfixing this - until it is not loaded, we cannot interfere in any way with what an image click does. The bug itself is relatively minor, but on the other hand the inconsistency of user experience this causes is relatively severe. I was left wondering whether Media Viewer was broken, whether I'd forgotten to enable it on my account (I had to check that), and then I cleared my cache and tried again which actually caused the problem to happen again. CCing Krinkle to get his input on fixing this. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
