[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 --- Comment #37 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158087 abandoned by TheDJ: [Do not merge] HTML5: Use header element to wrap our headings. Reason: Abandoning, since I don't have time for big changes like this. But SOMEONE PLEASE DO IT. https://gerrit.wikimedia.org/r/158087 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Keywords|patch, patch-reviewed | Status|PATCH_TO_REVIEW |NEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Assignee|matma@gmail.com |wikibugs-l@lists.wikimedia. ||org -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 --- Comment #36 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158087 had a related patch set uploaded by TheDJ: [Do not merge] HTML5: Use header element to wrap our headings. https://gerrit.wikimedia.org/r/158087 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 Rezonansowy lukas.ce...@gmail.com changed: What|Removed |Added CC||lukas.ce...@gmail.com --- Comment #33 from Rezonansowy lukas.ce...@gmail.com --- (In reply to Daniel Friesen from comment #32) That doesn't look like proper use of the header element to me. No, it is a very good use. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header and http://www.w3schools.com/tags/tag_header.asp So: header h2Heading 2/h2 span[edit section]/span /header -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 --- Comment #34 from Michael Zajac mich...@zajac.ca --- (In reply to Daniel Friesen from comment #32) That doesn't look like proper use of the header element to me. It looks like a valid use to me. Does header break anything on MSIE 7 or 8? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 --- Comment #35 from S. McCandlish smccandl...@gmail.com --- (In reply to Michael Zajac from comment #34) (In reply to Daniel Friesen from comment #32) That doesn't look like proper use of the header element to me. It looks like a valid use to me. Does header break anything on MSIE 7 or 8? Perfectly valid, even exemplary, use of header, but I'm not sure it buys us anything toward resolution of #11555. I'm unaware of any effect this would have on the accessibility or usability problems of the [edit section] links not being part of the h# headINGS. Unless I've missed something, header is not a semantically required element to put around h# headings, nor even a useful one unless there's a specific purpose in mind for doing so, and that purpose is supported by user agents or likely to become supported by them. I would side with the argument that use of header in this case would actually at least be semantically useful for server coders and site implementors, though probably not at all for end users (readers, wikicode editors). Regardless, it won't resolve this bug. That said, I have not been keeping up with what screen readers are doing with HTML5. Their support for would-be-accessibility-useful features of HTML 4/XHTML 1 and CSS 2 was so awful, I'm not sure I can bear to go see what the developers of such projects are willfully ignoring this time around... But maybe I'm wrong and HTML5 headings are all the rage in screen readers and other agents. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 Sumana Harihareswara suma...@wikimedia.org changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |matma@gmail.com |org | --- Comment #27 from Sumana Harihareswara suma...@wikimedia.org --- MatmaRex, would you mind taking a look at this? Please feel free to de-assign if you'd rather not make the attempt. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 --- Comment #28 from Bartosz Dziewoński matma@gmail.com --- (In reply to comment #0) For users of screenreaders (and textbrowsers) it takes quite long to walk throught the headlines. At every single headline they hear [edit] first instead of the real section title. This could easily be changed by let the edit-section-link come second in the rendered page and let the section title come first. I have done it while fixing bug 41729, as Daniel points out in comment 24. So the situation is slightly better now (but clearly not perfect). I'm not sure how feasible would changing the format again be. But anyway there's apparently a lot more bugs about those links that are not consistently tracked than I thought, so some more careful research would be in order. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Blocks||48717 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Blocks|367 | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 --- Comment #29 from Bartosz Dziewoński matma@gmail.com --- I've created tracking bug 48717 and connected some bugs to it, including this one. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 S. McCandlish smccandl...@gmail.com changed: What|Removed |Added CC||smccandl...@gmail.com --- Comment #26 from S. McCandlish smccandl...@gmail.com --- (In reply to comment #25) (In reply to comment #24) Is this bug relevant anymore? [edit] links are now placed after the header text. Still relevant. The edit link is still in the heading, saying that, e.g., “References [Edit]” is the title of an article section. Definitely. I'm surprised that this hasn't been fixed yet, given that patches have been submitted, CSS tweaks gives, and it's been reviewed. This should have been fixed years ago. PS: Krinkle is correct that the .mw-headline should come after the span.editsection for page flow logic reasons, no matter how CSS is used to visually place things (which is ultimately subject to the user agent's local CSS anyway). Not having them in this order will be a major usability problem because people will naturally click on a section's Edit link to make changes to the section's heading, and will wax sorely confounded if that heading is not actually within the section. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed: What|Removed |Added CC||mediawiki-bugs@nadir-seen-f ||ire.com --- Comment #24 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com --- Is this bug relevant anymore? [edit] links are now placed after the header text. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 --- Comment #25 from Michael Zajac mich...@zajac.ca --- (In reply to comment #24) Is this bug relevant anymore? [edit] links are now placed after the header text. Still relevant. The edit link is still in the heading, saying that, e.g., “References [Edit]” is the title of an article section. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 Krinkle krinklem...@gmail.com changed: What|Removed |Added Target Milestone|--- |Future release Summary|Editsection Links should|.editsection links should |come after Section |not be part of the h# |Headlines |element --- Comment #22 from Krinkle krinklem...@gmail.com 2012-06-03 15:42:34 UTC --- Rephrasing bug to reflect original request as well as to address some disagreement regarding the implementation. The original request was to not put the span.editsection inside the h#. In which order is a different matter and one could even argue that putting it before the .mw-headline is better because the section edit page actually contains the heading itself. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 11555] .editsection links should not be part of the h# element
https://bugzilla.wikimedia.org/show_bug.cgi?id=11555 --- Comment #23 from Krinkle krinklem...@gmail.com 2012-06-03 15:42:51 UTC --- Note that this part may be fixed as part of bug 31932. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
