[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853
Bawolff (Brian Wolff) bawolff...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Bawolff (Brian Wolff) bawolff...@gmail.com ---
(In reply to Technical 13 from comment #7)
(In reply to Bawolff (Brian Wolff) from comment #5)
preload=Template:Foo^param=bar^one
I know pipes are a pain for wiki syntax, but if we're going to do this, I
would still prefer we used them instead of using other characters (What if
you want to use ^ in a parameter name, what if you have a template named
Foo^. Using |'s doesn't cause any more confusion, and its already a reserved
character). Users can always use %7C instead of {{!}} in urls.
Per [[gerrit:116482]] the syntax will be:
action=editpreload=Foopreloadparams[]=firstpreloadparams[]=second
Where first will be available as $1 and second will be available as $2
in the preload template of Foo if my understanding is correct. Does this
address your issue/question Brian?
I'm fine with that syntax. I object to suddenly treating ^ as magic divider.
---
Anyways, patch merged. As has been stated above you can do things like
action=editpreload=Foopreloadparams[]=firstpreloadparams[]=second and have
$1 replaced with first, $2 replaced with second, etc. $* will output all
parameters, plus a colon (Consider the $* a side effect, which would probably
not change, but we make no guarantees that it won't some far off day in the
future). It should probably be available on Wikipedia by April 17.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 116482 merged by Brian Wolff: Allow passing parameters to preload https://gerrit.wikimedia.org/r/116482 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853
--- Comment #7 from Technical 13 technical...@yahoo.com ---
(In reply to Bawolff (Brian Wolff) from comment #5)
preload=Template:Foo^param=bar^one
I know pipes are a pain for wiki syntax, but if we're going to do this, I
would still prefer we used them instead of using other characters (What if
you want to use ^ in a parameter name, what if you have a template named
Foo^. Using |'s doesn't cause any more confusion, and its already a reserved
character). Users can always use %7C instead of {{!}} in urls.
Per [[gerrit:116482]] the syntax will be:
action=editpreload=Foopreloadparams[]=firstpreloadparams[]=second
Where first will be available as $1 and second will be available as $2 in
the preload template of Foo if my understanding is correct. Does this
address your issue/question Brian?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 116482 had a related patch set uploaded by Jackmcbarn: Allow passing parameters to preload https://gerrit.wikimedia.org/r/116482 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853 Technical 13 technical...@yahoo.com changed: What|Removed |Added CC||jackmcbarn+w...@gmail.com --- Comment #4 from Technical 13 technical...@yahoo.com --- Bump and add Jackmcbarn to the CC list as he mentioned he could try and write a patch for this on my enwp talk page. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853
--- Comment #5 from Bawolff (Brian Wolff) bawolff...@gmail.com ---
preload=Template:Foo^param=bar^one
I know pipes are a pain for wiki syntax, but if we're going to do this, I would
still prefer we used them instead of using other characters (What if you want
to use ^ in a parameter name, what if you have a template named Foo^. Using |'s
doesn't cause any more confusion, and its already a reserved character). Users
can always use %7C instead of {{!}} in urls.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853
ShoeMaker technical...@yahoo.com changed:
What|Removed |Added
CC||technical...@yahoo.com
--- Comment #3 from ShoeMaker technical...@yahoo.com ---
Was this ability ever implemented? I would like to create a template that has
some parameters passed to it from a linked image. As a note, using pipes in the
url would not be ideal if the link was called from
[[File:example.jpg|link=url]] Using a pipe would force users to {{!}} the url.
An alternative might be preload=Template:Foo^param=bar^one. See
[[User:Technical_13/Templates/NFCC9]] which is just a shell of what I would
like to do based on implementation of some kind of ability to pass preload
templates arguments. See [[User:Technical 13/SandBox/NFCC]] for full
description of what I would like to be able to do with this feature.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853 Bawolff bawolff...@gmail.com changed: What|Removed |Added Keywords|need-review |reviewed CC||bawolff...@gmail.com --- Comment #1 from Bawolff bawolff...@gmail.com 2012-01-05 13:49:48 UTC --- Thanks for the patch. However, I'm not entirely sure that allowing to specify params via url is something needed. If it is really needed though, we should be using the actual parser to do it, not str_replace'ing the parameters (which is actually much easier now that processing preload text now lives in Parser::getPreloadText ) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853
--- Comment #2 from Bawolff bawolff...@gmail.com 2012-01-05 13:51:23 UTC ---
Additionally, if we did that, we'd probably want to process {{{param|foo}}}
into foo to be like normal, but then what if someone wants to use preload in
order to create a template, and they want their {{{param|foo}}} in the preload
source text to be untouched.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12853] Allow triple brace substitution on preload templates
https://bugzilla.wikimedia.org/show_bug.cgi?id=12853 church.of.emacs...@gmail.com changed: What|Removed |Added CC||church.of.emacs...@gmail.com Keywords||need-review -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
