[Bug 18247] Allowing per page filters
https://bugzilla.wikimedia.org/show_bug.cgi?id=18247 John Mark Vandenberg jay...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||jay...@gmail.com Resolution||WORKSFORME --- Comment #10 from John Mark Vandenberg jay...@gmail.com 2011-04-28 16:16:55 UTC --- We already have article_articleid article_text. This bug is requesting optimisation of those variables specifically without giving evidence it is needed or cost efficient (another table lookup vs putting the article_articleid condition first and/or improving the execute plan). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18247] Allowing per page filters
https://bugzilla.wikimedia.org/show_bug.cgi?id=18247 Andrew Garrett agarr...@wikimedia.org changed: What|Removed |Added CC||king.of.hearts.w...@gmail.co ||m --- Comment #9 from Andrew Garrett agarr...@wikimedia.org 2009-08-09 20:25:42 UTC --- *** Bug 20147 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18247] Allowing per page filters
https://bugzilla.wikimedia.org/show_bug.cgi?id=18247 --- Comment #6 from FT2 ft2.w...@gmail.com 2009-06-05 16:06:46 UTC --- A substring search should not be necessary. The table of per article filters would be indexed by pageID, allowing a direct lookup of all filters applicable to a given page (ie those with the specified PageID, or those applicable to all pages). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18247] Allowing per page filters
https://bugzilla.wikimedia.org/show_bug.cgi?id=18247 --- Comment #7 from Andrew Garrett agarr...@wikimedia.org 2009-06-05 16:11:27 UTC --- (In reply to comment #6) A substring search should not be necessary. The table of per article filters would be indexed by pageID, allowing a direct lookup of all filters applicable to a given page (ie those with the specified PageID, or those applicable to all pages). That isn't how you suggested storing it, you suggested putting it in a pipe-separated list. If implemented, there would be a 'global' flag on the filters themselves, and a separate table for associating filters with pages. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18247] Allowing per page filters
https://bugzilla.wikimedia.org/show_bug.cgi?id=18247 --- Comment #5 from Andrew Garrett agarr...@wikimedia.org 2009-06-03 15:16:57 UTC --- Minor technical quibble: It isn't computationally trivial to search for a substring in thousands of rows. It requires an expensive row scan. If implemented, it would be done differently. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18247] Allowing per page filters
https://bugzilla.wikimedia.org/show_bug.cgi?id=18247 FT2 ft2.w...@gmail.com changed: What|Removed |Added CC||ft2.w...@gmail.com --- Comment #1 from FT2 ft2.w...@gmail.com 2009-04-01 17:48:41 UTC --- Examples where this is already being used, and could be extended and optimized by per page filters: eg, 36, 100, 101 Rather than have many filters which apply to one article only (but are included in general filters) it makes sense to have a table of those filters that are page specific and only trigger on one (or a few) specific article title matches, because any number of these can be created and applied without significant server lag, since almost all of them will be completely skipped if not on an applicable page. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18247] Allowing per page filters
https://bugzilla.wikimedia.org/show_bug.cgi?id=18247 --- Comment #3 from FT2 ft2.w...@gmail.com 2009-04-01 22:40:14 UTC --- Disagree, though I take the point you're making. The difference is this: A bare handful of days into AbuseFilter, we have filters for specific vandals and/or specific articles or modus. Imagine a scenario where we have not 3 or 4 of these, but many thousands of them. Suppose there are 200 global filters, and 10,000 article-based filters of which 3 apply to this article being edited. (This many filters need not be a control problem provided that all filters are set up following on-wiki review as with other issues. It could well be the future of first-line repeat abuse detection and handling once we get the hang of using filters effectively.) Under the present system, the edit would get matched to all 10,200 filters, HOWEVER OPTIMIZED. Even if the article match were checked very first thing, the edit is still tested against each filter, however briefly. The proposal here would skip that. The edit is tested not against 10,200 filters, but only 203 (200 global filters and the 3 article-specific filters that are indexed/applicable to that article). The other 9997 filters are simply not seen, because they are indexed/attached to other articles. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18247] Allowing per page filters
https://bugzilla.wikimedia.org/show_bug.cgi?id=18247 --- Comment #4 from FT2 ft2.w...@gmail.com 2009-04-01 22:51:27 UTC --- In brief, every filter would have an extra field of the form article_name must match... parameter_list where parameter_list is one or more page titles with an appropriate separator such as the pipe symbol. Then edits to any article would be tested only against those filters selected via pseudocode: SELECT FilterID.* FROM Filters WHERE ((filterID.parameter IS Null OR article_name IS IN filterID.parameter_list) AND filterID.enabled IS True) Computationally that's trivial, and also an immense time-saver. Hope that makes sense :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18247] Allowing per page filters
https://bugzilla.wikimedia.org/show_bug.cgi?id=18247 Bug 18247 depends on bug 18246, which changed state. Bug 18246 Summary: Expiry time option, on filters https://bugzilla.wikimedia.org/show_bug.cgi?id=18246 What|Old Value |New Value Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
