[Bug 23137] no diff when click show changes by section=new on non existing page
https://bugzilla.wikimedia.org/show_bug.cgi?id=23137 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords|patch, patch-need-review| -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23137] no diff when click show changes by section=new on non existing page
https://bugzilla.wikimedia.org/show_bug.cgi?id=23137 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Attachment #9007|0 |1 is obsolete|| --- Comment #4 from Umherirrender umherirrender_de...@web.de 2012-04-05 19:20:59 UTC --- Comment on attachment 9007 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9007 remove bogus page check Patch is obsolete because with r107319 some things changed, which makes that patch useless. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23137] no diff when click show changes by section=new on non existing page
https://bugzilla.wikimedia.org/show_bug.cgi?id=23137 --- Comment #3 from Umherirrender umherirrender_de...@web.de 2011-09-02 20:53:36 UTC --- Created attachment 9007 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9007 remove bogus page check The patch removed a bogus page check in WikiPage::replaceSection, because this fails on non-existing pages. Feel free to modify the patch. Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23137] no diff when click show changes by section=new on non existing page
https://bugzilla.wikimedia.org/show_bug.cgi?id=23137 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Keywords||need-review, patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23137] no diff when click show changes by section=new on non existing page
https://bugzilla.wikimedia.org/show_bug.cgi?id=23137 --- Comment #2 from Umherirrender umherirrender_de...@web.de 2010-04-16 21:03:44 UTC --- The inconsistency is that the show changes button give a diff, when not create a new section on an non-existing page. The button is helpful to detect/prevent edit conflicts, because the function diffs always against the new version of a page and so changes is shown in the diff. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23137] no diff when click show changes by section=new on non existing page
https://bugzilla.wikimedia.org/show_bug.cgi?id=23137 Church of emacs church.of.emacs...@gmail.com changed: What|Removed |Added CC||church.of.emacs...@gmail.co ||m --- Comment #1 from Church of emacs church.of.emacs...@gmail.com 2010-04-15 21:36:03 UTC --- I suppose that one could be fixed quite easily, but the question is if show changes really makes sense. The diff will be just the new text, which is also in the text field. We really should think about just omitting the show changes button/tab when section=new. Although we might keep it for UI consistency. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
