[Bug 26224] Deadlock in FlaggedRevision::insertOn on edit autoreview

2011-05-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26224

Aaron Schulz jschulz_4...@msn.com changed:

   What|Removed |Added

 Resolution|FIXED   |DUPLICATE

--- Comment #11 from Aaron Schulz jschulz_4...@msn.com 2011-05-08 22:41:35 
UTC ---
Folding into (a bit) more general bug 28598.

*** This bug has been marked as a duplicate of bug 28598 ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26224] Deadlock in FlaggedRevision::insertOn on edit autoreview

2010-12-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26224

Aaron Schulz jschulz_4...@msn.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #10 from Aaron Schulz jschulz_4...@msn.com 2010-12-22 22:13:51 
UTC ---
Marking closed. r78052 should reduce this, and I haven't heard of new reports
(this kind of thing isn't a problem unless it is frequent).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26224] Deadlock in FlaggedRevision::insertOn on edit autoreview

2010-12-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26224

--- Comment #8 from Aaron Schulz jschulz_4...@msn.com 2010-12-08 19:19:17 UTC 
---
Tweaked the insertOn() function to be less deadlock prone in r78052. Synced.
I'll wait to see if other tweaks are needed.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26224] Deadlock in FlaggedRevision::insertOn on edit autoreview

2010-12-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26224

--- Comment #9 from Aaron Schulz jschulz_4...@msn.com 2010-12-08 19:56:06 UTC 
---
Is this still occurring often?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26224] Deadlock in FlaggedRevision::insertOn on edit autoreview

2010-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26224

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

 AssignedTo|ro...@wikimedia.org |wikibug...@lists.wikimedia.
   ||org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26224] Deadlock in FlaggedRevision::insertOn on edit autoreview

2010-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26224

--- Comment #6 from Aaron Schulz jschulz_4...@msn.com 2010-12-06 21:18:56 UTC 
---
(In reply to comment #5)
 I am running a script using api on dewiki this evening i'll used many times
 before without any problems. But i got this error three times within 10
 minutes.
How are you using the review API? It might help to know the usage patterns,
though these things can be tricky to track either way.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26224] Deadlock in FlaggedRevision::insertOn on edit autoreview

2010-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26224

--- Comment #7 from Aaron Schulz jschulz_4...@msn.com 2010-12-06 23:06:52 UTC 
---
(In reply to comment #6)
 (In reply to comment #5)
  I am running a script using api on dewiki this evening i'll used many times
  before without any problems. But i got this error three times within 10
  minutes.
 How are you using the review API? It might help to know the usage patterns,
 though these things can be tricky to track either way.

Bitten again...edit API, not review. At least that narrows it down to
autoReviewEdit() function area.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26224] Deadlock in FlaggedRevision::insertOn on edit autoreview

2010-12-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26224

Aaron Schulz jschulz_4...@msn.com changed:

   What|Removed |Added

Summary|Deadlock in |Deadlock in
   |FlaggedRevision::insertOn   |FlaggedRevision::insertOn
   ||on edit autoreview

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26224] Deadlock in FlaggedRevision::insertOn on edit autoreview

2010-12-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26224

merl bugrepor...@to.mabomuja.de changed:

   What|Removed |Added

 CC||bugrepor...@to.mabomuja.de

--- Comment #5 from merl bugrepor...@to.mabomuja.de 2010-12-04 22:10:10 UTC 
---
I am running a script using api on dewiki this evening i'll used many times
before without any problems. But i got this error three times within 10
minutes. The last one:

editing de:Izumi Sakai using api with action=editappendtext=...

?xml version=1.0?apierror code=internal_api_error_DBQueryError
info=Database query error xml:space=preserve

#0 /usr/local/apache/common-local/wmf-deployment/includes/db/Database.php(541):
DatabaseBase-gt;reportQueryError('Deadlock found ...', 1213, 'INSERT IGNORE
I...', 'FlaggedRevision...', false)
#1
/usr/local/apache/common-local/wmf-deployment/includes/db/Database.php(1174):
DatabaseBase-gt;query('INSERT IGNORE I...', 'FlaggedRevision...')
#2
/usr/local/apache/common-local/wmf-deployment/extensions/FlaggedRevs/FlaggedRevision.php(324):
DatabaseBase-gt;insert('flaggedtemplate...', Array, 'FlaggedRevision...',
'IGNORE')
#3
/usr/local/apache/common-local/wmf-deployment/extensions/FlaggedRevs/FlaggedRevs.class.php(1353):
FlaggedRevision-gt;insertOn(true)
#4
/usr/local/apache/common-local/wmf-deployment/extensions/FlaggedRevs/FlaggedRevs.hooks.php(726):
FlaggedRevs::autoReviewEdit(Object(Article), Object(User), Object(Revision),
NULL)
#5 [internal function]:
FlaggedRevsHooks::maybeMakeEditReviewed(Object(Article), Object(Revision),
false, Object(User))
#6 /usr/local/apache/common-local/wmf-deployment/includes/Hooks.php(133):
call_user_func_array(Array, Array)
#7 /usr/local/apache/common-local/wmf-deployment/includes/Article.php(1982):
wfRunHooks('NewRevisionFrom...', Array)
#8 /usr/local/apache/common-local/wmf-deployment/includes/Article.php(1791):
Article-gt;doEdit('[[Bild:Entertai...', '+[[fi:Izumi Sak...', 102)
#9 /usr/local/apache/common-local/wmf-deployment/includes/EditPage.php(1047):
Article-gt;updateArticle('[[Bild:Entertai...', '+[[fi:Izumi Sak...', true,
true, false, '')
#10
/usr/local/apache/common-local/wmf-deployment/includes/api/ApiEditPage.php(238):
EditPage-gt;internalAttemptSave(NULL, false)
#11
/usr/local/apache/common-local/wmf-deployment/includes/api/ApiMain.php(595):
ApiEditPage-gt;execute()
#12
/usr/local/apache/common-local/wmf-deployment/includes/api/ApiMain.php(338):
ApiMain-gt;executeAction()
#13
/usr/local/apache/common-local/wmf-deployment/includes/api/ApiMain.php(322):
ApiMain-gt;executeActionWithErrorHandling()
#14 /usr/local/apache/common-local/wmf-deployment/api.php(116):
ApiMain-gt;execute()
#15 /usr/local/apache/common-local/live-1.5/api.php(3):
require('/usr/local/apac...')
#16 {main}

/error/api

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l