[Bug 26612] Regression: Postgres cannot install
https://bugzilla.wikimedia.org/show_bug.cgi?id=26612 --- Comment #7 from Chad H. innocentkil...@gmail.com 2011-02-23 16:06:50 UTC --- See trunk as of r82674. All of the $wgDBuser-specific settings have been cleaned up and are taken care of in open() and the pre-8.3 compat stuff has been dropped. I implemented a form of selectDB() (which works how you'd expect really) which resolves the upgrade issue. Haven't handled the admin user might not be able to use pg_catalog, much less template1 case yet. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26612] Regression: Postgres cannot install
https://bugzilla.wikimedia.org/show_bug.cgi?id=26612 Tim Starling tstarl...@wikimedia.org changed: What|Removed |Added CC||tstarl...@wikimedia.org --- Comment #6 from Tim Starling tstarl...@wikimedia.org 2011-01-27 02:33:19 UTC --- One problem is that DatabaseBase::selectDB() does not work for SQLite or PostgreSQL, so it should not be used in DBMS-independent code. In particular, needsUpgrade() is broken because it depends on selectDB() returning false if the database does not exist. I think PostgresqlInstaller should check for the existence of the database by attempting to connect to it with the administrative credentials, and checking the resulting error message for FATAL: database ... does not exist. There's no guarantee that the administrative user will be able to connect to the template1 database, or any other specific database, so you can't use the pg_database catalog. If the database doesn't exist, I think it's fair to assume that you need to be able to connect to the postgres administrative database in order to create one. The old installer relied on creation of a special user to ensure that the session settings were correct: $SQL = ALTER USER $safeuser SET timezone = 'GMT'; $SQL = ALTER USER $safeuser SET datestyle = 'ISO, YMD'; This is missing from the new installer, which is good, but DatabasePostgres::open() should make sure the correct settings are set in the session. Dropping support for full text search before PostgreSQL 8.3 (released 2008) would allow the setup code to be substantially simpler. The schema for tsearch2 ($wgDBts2schema) setting could be dropped, currently it does nothing in PostgreSQL 8.3 or later. SearchPostgres.php would be slightly simpler. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26612] Regression: Postgres cannot install
https://bugzilla.wikimedia.org/show_bug.cgi?id=26612 Rob Lanphier ro...@wikimedia.org changed: What|Removed |Added CC||ro...@wikimedia.org Blocks|26611 |26676 --- Comment #5 from Rob Lanphier ro...@wikimedia.org 2011-01-11 23:02:07 UTC --- Changing dependency from bug 26611 to bug 26676. We don't need to fix this for deployment, but we do need to fix this before releasing the tarball -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26612] Regression: Postgres cannot install
https://bugzilla.wikimedia.org/show_bug.cgi?id=26612 --- Comment #4 from Chad H. innocentkil...@gmail.com 2011-01-10 19:19:47 UTC --- Also r79950. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26612] Regression: Postgres cannot install
https://bugzilla.wikimedia.org/show_bug.cgi?id=26612 --- Comment #3 from Chad H. innocentkil...@gmail.com 2011-01-07 18:27:47 UTC --- That myriad of function calls is way clearer than the bowl of mush sitting in DatabasePostgres. Suit yourself, I suppose. Needs review: r79828. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26612] Regression: Postgres cannot install
https://bugzilla.wikimedia.org/show_bug.cgi?id=26612 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Priority|Normal |High -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26612] Regression: Postgres cannot install
https://bugzilla.wikimedia.org/show_bug.cgi?id=26612 --- Comment #1 from Reedy s...@reedyboy.net 2011-01-06 23:06:28 UTC --- http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78925#c12332 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26612] Regression: Postgres cannot install
https://bugzilla.wikimedia.org/show_bug.cgi?id=26612 --- Comment #2 from OverlordQ overlo...@gmail.com 2011-01-07 07:28:56 UTC --- If you have specific How do I do foo questions I'd be more then willing to answer. I'd just rather not have to trace the myriad of function calls and new templating thats done. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
