https://bugzilla.wikimedia.org/show_bug.cgi?id=27161
Summary: Check if Status::isGood() and Status::isOk() are used appropriately in FileRepo Product: MediaWiki Version: wikimedia-deployment Platform: All OS/Version: All Status: NEW Severity: normal Priority: Normal Component: Images and files AssignedTo: bryan.tongm...@gmail.com ReportedBy: bryan.tongm...@gmail.com CC: gpaum...@wikimedia.org, bryan.tongm...@gmail.com Almost always you want Status::isGood() not Status::isOk(). Each use of those functions needs to be checked in FileRepo, because I have found cases where I believe isGood() is more appropriate than isOk(). In addition in some cases the member variable $ok is accessed directly. This should be fixed to use one of the accessor methods. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l