[Bug 27652] [jQuery.client] versionBase is wrong for Opera 10.x and higher

2011-03-02 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27652

--- Comment #2 from Krinkle krinklem...@gmail.com 2011-03-02 09:51:42 UTC ---
Untested, will test/commit when I get home:



   var version = ...;
 + var versionNumber = parseFloat( version, 10 ) || 0.0;

   /* Caching */

   profile = {
   'name': name,
   'layout': layout,
   'layoutVersion': layoutversion,
   'platform': platform,
   'version': version,
 - 'versionBase': ( version !== x ? new String( 
 version ).substr( 0, 1 ) : x ),
 - 'versionNumber': ( parseFloat( version, 10 ) || 
 0.0 )
 + 'versionBase': ( version !== x ? Math.floor( 
 versionNumber ).toString() : x ),
 + 'versionNumber': versionNumber
   };
   }

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27652] [jQuery.client] versionBase is wrong for Opera 10.x and higher

2011-02-27 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27652

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #1 from Krinkle krinklem...@gmail.com 2011-02-27 20:26:18 UTC ---
The problem is on line 129

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.client.js?view=markuppathrev=81276#l129
   'versionBase': ( version !== x ? new String( 
 version ).substr( 0, 1 ) : x ),

Instead of rounding downwards without digets, it's slicing the first number.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l