[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 --- Comment #13 from Vitaliy Filippov vita...@yourcmc.ru 2011-11-07 12:17:46 UTC --- Created attachment 9370 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9370 Check preload to recache -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Domas Mituzas domas.mitu...@gmail.com changed: What|Removed |Added CC||domas.mitu...@gmail.com --- Comment #14 from Domas Mituzas domas.mitu...@gmail.com 2011-11-07 12:20:25 UTC --- back in the day I livehacked in APC-based cache for languages in mediawiki, it definitely makes sense to keep this data in memory ;) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 --- Comment #15 from Mark A. Hershberger m...@everybody.org 2011-11-07 17:51:31 UTC --- New patch applied r102304 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 --- Comment #12 from Vitaliy Filippov vita...@yourcmc.ru 2011-11-03 11:15:29 UTC --- In the meantime I've found another bug with the implementation - it also relies on the presence of key '...:preload' and doesn't check it when checking for the expired cache, which can lead to Invalid or missing localisation cache exceptions. I'll fix it soon. About the comments to r101507: Maybe LCStore_Accel should force disable manualRecache itself? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 --- Comment #10 from Vitaliy Filippov vita...@yourcmc.ru 2011-11-02 14:27:43 UTC --- Thanks! So, wfGetCache doesn't return FakeMemCachedClients anymore? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #11 from Roan Kattouw roan.katt...@gmail.com 2011-11-02 14:30:06 UTC --- (In reply to comment #10) Thanks! So, wfGetCache doesn't return FakeMemCachedClients anymore? I don't know whether it ever did, I'm not familiar with wfGetCache(). But I can tell you what it did on my install :) . I do recall that Tim refactored wfGetCache() and the whole ecosystem around it a while ago, perhaps that's when this change in behavior was introduced. See ObjectCache::newAccelerator() in includes/objectcache/ObjectCache.php -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Reedy s...@reedyboy.net changed: What|Removed |Added Keywords|reviewed|need-review --- Comment #7 from Reedy s...@reedyboy.net 2011-11-01 07:18:16 UTC --- Minor thing, we don't capitalise null -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Status|NEW |RESOLVED CC||m...@everybody.org Resolution||FIXED --- Comment #8 from Mark A. Hershberger m...@everybody.org 2011-11-01 16:11:29 UTC --- r101492 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 --- Comment #9 from Mark A. Hershberger m...@everybody.org 2011-11-01 18:34:19 UTC --- re-applied at r101507 with way to make it work if there is no APC cache installed -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Vitaliy Filippov vita...@yourcmc.ru changed: What|Removed |Added Attachment #8625|0 |1 is obsolete|| --- Comment #6 from Vitaliy Filippov vita...@yourcmc.ru 2011-10-31 12:09:12 UTC --- Created attachment 9322 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9322 Updated patch for r101353 Why it's not properly targetting a file? Do you mean the path must be 'phase3/includes/LocalisationCache.php' instead of just 'includes/LocalisationCache.php'? If so, see the updated patch. I've also corrected the code style, added an AutoLoader entry and removed require_once ObjectCache.php, although I remember it didn't work in 1.16 without it :) Also, there was an issue with accel store - sometimes 'list:messages' expired in XCache while 'deps' didn't, which leaded to warnings on the top of page. I've fixed it - now it checks both keys to determine if the cache is missing. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 John Du Hart j...@compwhizii.net changed: What|Removed |Added Keywords|need-review |reviewed CC||j...@compwhizii.net --- Comment #5 from John Du Hart j...@compwhizii.net 2011-10-26 15:51:06 UTC --- -needs-review Per the above the diff isn't properly targetting a file and needs an Autoloader entry. Also if you could make it confirm to our Coding Conventions it would be appreciated. https://www.mediawiki.org/wiki/Manual:Coding_conventions Let me know on #mediawiki if you'd like some help :) +reviewed -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added Priority|Unprioritized |Lowest -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added CC||s.mazel...@xs4all.nl --- Comment #4 from Siebrand s.mazel...@xs4all.nl 2011-09-03 16:01:32 UTC --- Core devs don't see the use or find things wrong with the patch. This issue will not progress until the reported updates the patch so that it can be applied properly to trunk. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added Keywords||i18n -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Niklas Laxström niklas.laxst...@gmail.com changed: What|Removed |Added Attachment #8625|0 |1 is patch|| Attachment #8625|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Niklas Laxström niklas.laxst...@gmail.com changed: What|Removed |Added CC||niklas.laxst...@gmail.com --- Comment #1 from Niklas Laxström niklas.laxst...@gmail.com 2011-06-06 14:53:32 UTC --- Seems waste of memory to me, but I think Tim should comment. The patch has some code style issues. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 Reedy s...@reedyboy.net changed: What|Removed |Added Keywords||need-review, patch Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 --- Comment #2 from Reedy s...@reedyboy.net 2011-06-06 15:37:52 UTC --- It's also missing an AutoLoader entry Also, the require_once 'ObjectCache.php'; shouldn't be needed The patch is also not properly targetting a file -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29283] Localisation Cache ACCEL store
https://bugzilla.wikimedia.org/show_bug.cgi?id=29283 --- Comment #3 from Vitaliy Filippov vita...@yourcmc.ru 2011-06-06 19:57:49 UTC --- (In reply to comment #1) Seems waste of memory to me, but I think Tim should comment. Can you explain it a little? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
