[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=61577 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693
--- Comment #21 from Rainer Rillke @commons.wikimedia
rainerril...@hotmail.com ---
I can't discover more than one style definition applied to some elements
targeted by Commons' Common.js (so it seems to be fixed?); however gadgets are
still loading their CSS trough both, JS ( mw.loader.implement( ... {css:[ /*
CSS here */ ]}) ) and a separate CSS.
--
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 Krinkle krinklem...@gmail.com changed: What|Removed |Added Priority|Normal |Low Status|NEW |RESOLVED Resolution|--- |WORKSFORME Severity|major |enhancement --- Comment #18 from Krinkle krinklem...@gmail.com --- This bug is either fixed (if the reporter saw css being loaded twice by a bug). Or it is a wontfix (if the reporter saw css being loaded once by only=styles and once by a regular load request), because that's only possible if the code using resourceloader is incorrectly adding the module to the load queue. e.g. by calling addModuleStyles() and then addModules() for the same module. Closing as worksforme, feel free to change to fixed or wontfix respectively. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #19 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com --- (In reply to comment #18) Or it is a wontfix (if the reporter saw css being loaded once by only=styles and once by a regular load request), because that's only possible if the code using resourceloader is incorrectly adding the module to the load queue. e.g. by calling addModuleStyles() and then addModules() for the same module. I wouldn't call that a wontfix. Making the server side loader smarter and not adding css that's already in the page will probably actually be a part of fixing other bugs we have related to RL that we need to fix. This bug would just end up depending on them instead of being WONTFIXED. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #20 from Krinkle krinklem...@gmail.com --- (In reply to comment #19) (In reply to comment #18) Or it is a wontfix (if the reporter saw css being loaded once by only=styles and once by a regular load request), because that's only possible if the code using resourceloader is incorrectly adding the module to the load queue. e.g. by calling addModuleStyles() and then addModules() for the same module. I wouldn't call that a wontfix. Making the server side loader smarter and not adding css that's already in the page will probably actually be a part of fixing other bugs we have related to RL that we need to fix. This bug would just end up depending on them instead of being WONTFIXED. I doubt that this will fit into any refactoring (planned or imaginary). -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed: What|Removed |Added CC||mediawiki-bugs@nadir-seen-f ||ire.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added CC||aklap...@wikimedia.org --- Comment #17 from Andre Klapper aklap...@wikimedia.org 2012-11-26 13:38:53 UTC --- (In reply to comment #4) (In reply to comment #3) It doesn't happen in MW 1.18a though. So it doesn't happen in trunk, and I don't believe it happens in stock 1.17.0 either. Perhaps you have modules depending on user or site? So there is currently no evidence at all that this problem still happens in a currently supported version of MediaWiki? (Note that CSS of gadgets is bug 40284 and still open.) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com Summary|Resource Loader loads CSS |ResourceLoader should not |multiple times |load CSS again if it was ||already included with ||only=styles -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #12 from Subfader subfa...@gmail.com 2012-09-24 17:55:34 UTC --- The fucked up Ressource Loader (sorry for the strong language) is the reason why I still cannot upgrade from MW 1.16. I wait for RL 2. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #13 from Roan Kattouw roan.katt...@gmail.com 2012-09-24 17:56:55 UTC --- (In reply to comment #12) The fucked up Ressource Loader (sorry for the strong language) is the reason why I still cannot upgrade from MW 1.16. I wait for RL 2. 1.17 was buggy because some fixes that made it into production accidentally didn't make it into the tarball, but have you tried using 1.19? Did you encounter any RL-related problems with 1.19? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #14 from Subfader subfa...@gmail.com 2012-09-24 18:01:31 UTC --- No I havent't but reading that CSS is adding CSS twice to fix a problem RL created itself makes RL look a bad and not very trustworthy. My wiki is extremely customized. Upgrading means lot of manual adjustment to core code and testing. I won't upgrade now when RL will be fixed in RL 2 soon after I upgraded. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #15 from Krinkle krinklem...@gmail.com 2012-09-24 18:09:39 UTC --- (In reply to comment #12) The fucked up Ressource Loader (sorry for the strong language) is the reason why I still cannot upgrade from MW 1.16. I wait for RL 2. RL2 is Gadgets 2.0, this has nothing to do with ResourceLoader in MediaWiki core. There were a few bugs in MediaWiki core that blocked Gadgets 2.0, but those have already been resolved and were released in MediaWiki 1.19 and are now in MediaWiki 1.20alpha as well. So in a way you could say that as far as MediaWiki core is concerned RL2 is ready and released. Can you be more specific what you were waiting for RL-related? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] ResourceLoader should not load CSS again if it was already included with only=styles
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #16 from Krinkle krinklem...@gmail.com 2012-09-24 18:12:36 UTC --- (In reply to comment #14) No I havent't but reading that CSS is adding CSS twice to fix a problem RL created itself makes RL look a bad and not very trustworthy. It doesn't just load it twice, that's non-sense. The way this happens is by design but there are a few modules that have not been converted correctly and as such get their css applied twice. Its minimal. As for stability, speed and efficiency for the client side (users using a web browser) I believe, ResourceLoader is most definitely an improvement over how it was in MediaWiki 1.16. So unless you actually tried upgrading and have a tangible problem, I'd say, upgrade and enjoy. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
