https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #27 from Roan Kattouw roan.katt...@gmail.com 2011-09-09 13:41:59
UTC ---
(In reply to comment #25)
Another is to do the string replacement directly and not use the selection at
all... except on IE, it looks like
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #28 from Santhosh Thottingal santhosh.thottin...@gmail.com
2011-09-09 14:31:25 UTC ---
(In reply to comment #24)
I didn't apply your Narayam patch yet, and adding the selectionStart and
selectionEnd params to jquery.textSelection
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #29 from Roan Kattouw roan.katt...@gmail.com 2011-09-09 18:35:24
UTC ---
(In reply to comment #28)
The patch tries to correct the selection by correcting startPos using the
passed selectionStart when it detects a problem. It does
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #30 from Santhosh Thottingal santhosh.thottin...@gmail.com
2011-09-10 05:20:54 UTC ---
(In reply to comment #29)
So what you're saying is that, if selectionStart is not passed, textSelection
will have to obtain it from
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #22 from Roan Kattouw roan.katt...@gmail.com 2011-09-08 16:06:22
UTC ---
Committed Santosh's core patch in r96579. Will review and apply the Narayam
patch after I eat.
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #23 from Santhosh Thottingal santhosh.thottin...@gmail.com
2011-09-08 16:10:40 UTC ---
(In reply to comment #22)
Committed Santosh's core patch in r96579. Will review and apply the Narayam
patch after I eat.
Oops, that patch
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #24 from Roan Kattouw roan.katt...@gmail.com 2011-09-08 18:01:08
UTC ---
(In reply to comment #23)
(In reply to comment #22)
Committed Santosh's core patch in r96579. Will review and apply the Narayam
patch after I eat.
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #25 from Brion Vibber br...@wikimedia.org 2011-09-08 18:26:39 UTC
---
Background on the selection bug:
Unicode text may include sequences composed of a base character followed by one
or more combining characters:
[lowercase latin
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #26 from Junaid junu.pv+pub...@gmail.com 2011-09-08 18:35:39 UTC
---
(In reply to comment #24)
r96415 fixes it, but in a hacky and slow way. What is the caret position
problem exactly?
Example:
Consider म्, it is a combined
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
Junaid junu.pv+pub...@gmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
Siebrand s.mazel...@xs4all.nl changed:
What|Removed |Added
CC||s.mazel...@xs4all.nl
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #16 from Santhosh Thottingal santhosh.thottin...@gmail.com
2011-08-21 09:46:59 UTC ---
Created attachment 8953
-- https://bugzilla.wikimedia.org/attachment.cgi?id=8953
correct the selectionStart postition problem with chrome.
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #17 from Santhosh Thottingal santhosh.thottin...@gmail.com
2011-08-21 09:51:00 UTC ---
Created attachment 8954
-- https://bugzilla.wikimedia.org/attachment.cgi?id=8954
Use encapsulateSelection with selection range
Pass extra
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
Santhosh Thottingal santhosh.thottin...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #19 from Santhosh Thottingal santhosh.thottin...@gmail.com
2011-08-21 11:56:25 UTC ---
WebKit bug report - https://bugs.webkit.org/show_bug.cgi?id=66630
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
Mark A. Hershberger m...@everybody.org changed:
What|Removed |Added
Priority|Unprioritized |High
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #3 from Brion Vibber br...@wikimedia.org 2011-08-02 07:12:20 UTC
---
Ok, here's what it looks like is happening:
* user types m
** select (0, 0] (empty selection)
** insert म् (two characters: m and no-vowel placeholder)
* user
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #4 from Brion Vibber br...@wikimedia.org 2011-08-02 07:14:46 UTC
---
Make that [0, 0), [1, 2), and [2, 2). Set notation. bah!
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #5 from Brion Vibber br...@wikimedia.org 2011-08-02 07:23:30 UTC
---
Manually selecting [0, 1) ends up selecting [0, 2) so it's definitely trying to
select whole groups of base+combining characters.
HTML 5 spec doesn't say
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
Brion Vibber br...@wikimedia.org changed:
What|Removed |Added
Blocks||29798
--
Configure
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #6 from Brion Vibber br...@wikimedia.org 2011-08-02 08:05:05 UTC
---
Created attachment 8869
-- https://bugzilla.wikimedia.org/attachment.cgi?id=8869
Provisional testing patch
It looks like if we select replace the entire
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #7 from Brion Vibber br...@wikimedia.org 2011-08-02 08:06:26 UTC
---
Created attachment 8870
-- https://bugzilla.wikimedia.org/attachment.cgi?id=8870
quickhack.php -- extracts combining chars list from UnicodeData.txt
used to
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
Srikanth srik@gmail.com changed:
What|Removed |Added
CC||srik@gmail.com
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #9 from Brion Vibber br...@wikimedia.org 2011-08-02 08:09:41 UTC
---
Yeah, looks like that's probably the same bug.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #10 from Junaid junu...@gmail.com 2011-08-02 11:03:24 UTC ---
@Brion,
I personally keep a standalone version of this tool that is independent of any
external js library (usually jQuery as we do here). It implements its own text
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #11 from Brion Vibber br...@wikimedia.org 2011-08-02 11:15:57 UTC
---
I don't see code in your version to overwrite entire words explicitly; offhand
it seems to have the exact same firstDivergence() func etc. How/where exactly
do
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #12 from Junaid junu...@gmail.com 2011-08-02 11:46:08 UTC ---
I didn't say the code overwrite entire word :(
The magic is happening in replaceString(). The function splits the string in
the field to three parts (not considering
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #13 from Brion Vibber br...@wikimedia.org 2011-08-02 12:02:04 UTC
---
Hmmm... that seems to work by replacing the *entire text* of the input area.
Won't this be fairly inefficient for interactive typing on article-sized
textareas?
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #14 from Brion Vibber br...@wikimedia.org 2011-08-02 12:30:20 UTC
---
Urgh, unfortunately the set-entire-huge-text-value seems to be the only
portable API for replacing the selection contents. Nice. $.textSelection at
least is
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #15 from Junaid junu...@gmail.com 2011-08-02 13:21:56 UTC ---
That is a nice idea. Hope people will edit long article by sections.
If I remember correctly, scrolling problem only appears in Firefox on windows
platforms. isn't it?
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #2 from Junaid junu...@gmail.com 2011-07-31 19:42:34 UTC ---
(In reply to comment #1)
I can see some apparently incorrect behavior...
'ma me mi mo mu' on Firefox 5.0.1 gives
'म मॆ मि मॊ मु' which looks right to me.
on Chrome
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
Junaid junu...@gmail.com changed:
What|Removed |Added
CC||br...@wikimedia.org,
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
Junaid junu...@gmail.com changed:
What|Removed |Added
AssignedTo|wikibugs-l@lists.wikimedia. |junu...@gmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=30130
--- Comment #1 from Brion Vibber br...@wikimedia.org 2011-07-31 01:19:07 UTC
---
I can see some apparently incorrect behavior...
'ma me mi mo mu' on Firefox 5.0.1 gives
'म मॆ मि मॊ मु' which looks right to me.
on Chrome 12.0.742.122 it
34 matches
Mail list logo
