[Bug 30149] Handling of parentheses for Korean, Chinese and Japanese

2011-08-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30149

--- Comment #4 from yes0s...@paran.com 2011-08-01 16:31:06 UTC ---
I'm not a developer, I can't test it. Sorry. Somebody test it, please.

I think [[Foo(bar), baz|]] - [[Foo(bar), baz|Foo]] is not needed in East Asian
languages as I wrote above.

(In reply to comment #2)
 [[Foo(bar)|]] appears to correctly parse to [[Foo(bar)|Foo]] in latest 
 SVN.
 However, [[Foo(bar)|]] parses to [[Foo(bar)|Foo(bar)]]. I have attached a
 patch which should correct that, but the machine I wrote it on isn't actually
 running a wiki, so I have to pop over to linux to test it. This patch also 
 adds
 two parsertests, one to test that the full width parens work, and one to test
 that standard parens with no space will also work. I have not added anything
 regarding the comma, since as the reporter said, they are used differently in
 those languages. I wasn't sure what to do with the [[Foo (bar), baz|]] option,
 should [[Foo(bar), baz|]] be allowed?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30149] Handling of parentheses for Korean, Chinese and Japanese

2011-08-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30149

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||m...@everybody.org
 Resolution||FIXED

--- Comment #5 from Mark A. Hershberger m...@everybody.org 2011-08-01 
17:38:41 UTC ---
r93633

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30149] Handling of parentheses for Korean, Chinese and Japanese

2011-07-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30149

--- Comment #1 from Dan Collins en.wp.s...@gmail.com 2011-07-31 17:27:25 UTC 
---
Created attachment 8856
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8856
A patch to make the space before the parens in the pipe trick optional.
Parsertests included, patch against /phase3/

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30149] Handling of parentheses for Korean, Chinese and Japanese

2011-07-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30149

Dan Collins en.wp.s...@gmail.com changed:

   What|Removed |Added

   Keywords||i18n, need-review, patch
 CC||en.wp.s...@gmail.com
  Component|Internationalization|Parser
Version|unspecified |1.19-svn

--- Comment #2 from Dan Collins en.wp.s...@gmail.com 2011-07-31 17:29:47 UTC 
---
[[Foo(bar)|]] appears to correctly parse to [[Foo(bar)|Foo]] in latest SVN.
However, [[Foo(bar)|]] parses to [[Foo(bar)|Foo(bar)]]. I have attached a
patch which should correct that, but the machine I wrote it on isn't actually
running a wiki, so I have to pop over to linux to test it. This patch also adds
two parsertests, one to test that the full width parens work, and one to test
that standard parens with no space will also work. I have not added anything
regarding the comma, since as the reporter said, they are used differently in
those languages. I wasn't sure what to do with the [[Foo (bar), baz|]] option,
should [[Foo(bar), baz|]] be allowed?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30149] Handling of parentheses for Korean, Chinese and Japanese

2011-07-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30149

Dan Collins en.wp.s...@gmail.com changed:

   What|Removed |Added

   Attachment #8856|0   |1
is obsolete||

--- Comment #3 from Dan Collins en.wp.s...@gmail.com 2011-07-31 18:04:49 UTC 
---
Created attachment 8857
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8857
First one had unicode mangled, trying from a different PC

For some reason my patch got mangled on upload. Trying again. Also, fixing some
space in the parsertests, and making it legal to have [[Foo (bar)|]] (full
width parens with space). This is tested, parsertests pass and looks good on my
test wiki.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l