[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

--- Comment #13 from Platonides platoni...@gmail.com 2011-09-17 14:01:50 UTC 
---
r97638 is a future revision. It is r97368.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

--- Comment #11 from Neil Kandalgaonkar ne...@wikimedia.org 2011-09-17 
04:54:59 UTC ---
Okay I did (2) without (1), which is semi-magical, but does the right thing
IMO.

If you added .jpg, and the extension was going to be .jpg, then it's normalized
to just one.

However, if you make a filename like filename.avi, and the ultimate extension
is .ogg, then you get filename.avi.ogg. Maybe some people will want that to
represent the original filename or whatever.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

Neil Kandalgaonkar ne...@wikimedia.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #12 from Neil Kandalgaonkar ne...@wikimedia.org 2011-09-17 
04:55:29 UTC ---
that is: fixed in r97638

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

--- Comment #8 from Platonides platoni...@gmail.com 2011-09-15 19:44:41 UTC 
---
(In reply to comment #6)
 Is there any valid use case for adding an additional extension in the
 Describe step? If not, I suggest either quietly stripping redundant
 extensions, or doing it as part of the interactive flow and notifying the 
 user.
 But I don't see a need for the UI clutter of confirm/yes/no/cancel.

Maybe the user wants to keep the original filename (eg. downloaded from
somewhere else)?
What's the difference between interactive flow and showing a dialog?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

--- Comment #9 from Neil Kandalgaonkar ne...@wikimedia.org 2011-09-15 
20:25:23 UTC ---
This was noted by some previous testers (who were familiar with MediaWiki
already).

Probably the right answer is twofold:

1) add the extension to the interface, in non-editable text at the right end of
the title input.

2) silently remove an extension in the filename, if it matches the existing
extension case-insensitively.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

--- Comment #10 from Platonides platoni...@gmail.com 2011-09-15 21:45:46 UTC 
---
I'm not sure (1) turns out to be pretty. A text below the title saying Will be
saved as $1.jpg that updates as you write looks nicer imho but that may have
its own issues (silly browsers, the change disturbing the user...).

I personally find uglier extensions with a different case than the main part of
the filename. Maybe not adding instead of removing the user part?
(that's still a magic behavior for the users, though)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

Erik Moeller e...@wikimedia.org changed:

   What|Removed |Added

 CC||e...@wikimedia.org

--- Comment #6 from Erik Moeller e...@wikimedia.org 2011-09-07 08:21:29 UTC 
---
Is there any valid use case for adding an additional extension in the
Describe step? If not, I suggest either quietly stripping redundant
extensions, or doing it as part of the interactive flow and notifying the user.
But I don't see a need for the UI clutter of confirm/yes/no/cancel.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

Erik Moeller e...@wikimedia.org changed:

   What|Removed |Added

   Priority|High|Normal
   Severity|major   |normal

--- Comment #7 from Erik Moeller e...@wikimedia.org 2011-09-07 08:25:15 UTC 
---
Reducing severity and importance which is IMO appropriate unless 1) the
original bug description can be reproduced, or 2) we see evidence that this is
a major issue affecting many users.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

--- Comment #5 from Platonides platoni...@gmail.com 2011-09-04 13:27:50 UTC 
---
I'd just show the warning all the time.

User clicks on Upload, and gets the following window;

The provided title 'Modern monument 5.jpg' seems to include a filename
extension.
As the extension is automatically added, the final would be 'Modern monument
5.jpg.jpg' Are you sure you want to proceed?


Yes, upload  - No, strip .jpg and upload - Cancel

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 CC||asha...@wikimedia.org,
   ||ne...@wikimedia.org
  Component|General/Unknown |UploadWizard
Version|unspecified |any
Product|Wikimedia   |MediaWiki extensions

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

Siebrand s.mazel...@xs4all.nl changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||s.mazel...@xs4all.nl
   Severity|normal  |major

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

Jeroen De Dauw jeroen_ded...@yahoo.com changed:

   What|Removed |Added

 CC||jeroen_ded...@yahoo.com

--- Comment #1 from Jeroen De Dauw jeroen_ded...@yahoo.com 2011-09-01 
12:29:01 UTC ---
I tried this locally and could not reproduce the issue. When I upload a file
foobar.JPG extension, it ends up as foobar.jpg. Are you sure it's the UW that
added this extension, and not some other tool you used?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

Tomasz W. Kozłowski odder.w...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #2 from Tomasz W. Kozłowski odder.w...@gmail.com 2011-09-01 
13:19:33 UTC ---
Neither can I reproduce this issue. This has been raised in a talk with me and
I've written about it to the WLM mailing list, without checking it before. I
think this had to be an error made by the user, so closing as RESOLVED INVALID.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

Huib abigor Laurens abi...@forgotten-beauty.com changed:

   What|Removed |Added

 Resolution|INVALID |WORKSFORME

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

Platonides platoni...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||platoni...@gmail.com
 Resolution|WORKSFORME  |

--- Comment #3 from Platonides platoni...@gmail.com 2011-09-01 15:58:07 UTC 
---
The UploadWizard asks for a title (which doesn't include the extension, seems
appended later by UW). If the user gives a title with an extension, that double
extension will appear in the final page.
I think that if the user provides a title with an extension (could just compare
with a few common ones, such as /(gif|jpe?g|png|pdf|bmp|djvu)/i) it should give
a warning.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30676] UploadWizard automatically adds .jpg file extension

2011-09-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30676

--- Comment #4 from Jeroen De Dauw jeroen_ded...@yahoo.com 2011-09-01 
18:18:05 UTC ---
Ah. Could do that. But what about when the extension matches that of the file
being uploaded? Also show the warning, or is it better then to just omit it?
Like that you cannot get a destination file name like foo.png.png, but I don't
see why you'd want to do this.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l