[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 Nemo federicol...@tiscali.it changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=48133 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #14 from Chad H. innocentkil...@gmail.com 2012-01-02 14:38:36 UTC --- Done properly in r107833. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 duplicate...@googlemail.com changed: What|Removed |Added CC||duplicate...@googlemail.com --- Comment #13 from duplicate...@googlemail.com 2011-12-22 19:06:16 UTC --- See r107042 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||rlan...@gmail.com, ||roan.katt...@gmail.com --- Comment #8 from Roan Kattouw roan.katt...@gmail.com 2011-11-11 12:27:48 UTC --- (In reply to comment #7) (In reply to comment #6) I'd recommend simply using https unconditionally here -- an SSL image on a non-SSL page should be perfectly legit. I'm not opposed to this, as long as ops says the https setup can take the load :) Ryan, what are your thoughts on this? It's proposed that starting with MW 1.19 (or 1.20 as the case may be), 3rd-party wikis using InstantCommons will load metadata (api.php on Commons), thumbnails and images (upload.wm.o) over HTTPS unconditionally (right now they're always loaded over HTTP). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 --- Comment #9 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-11-11 13:58:24 UTC --- What is exactly the usefulness of this? As far as I know thumbnails are cached on the local server, and passed by it to the user. So regardless whether $wgInstantCommons fetches thumbnails over http or https, the user will still get the images over the same protocol as the the rest of the page. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 --- Comment #10 from Roan Kattouw roan.katt...@gmail.com 2011-11-11 13:59:55 UTC --- (In reply to comment #9) What is exactly the usefulness of this? As far as I know thumbnails are cached on the local server, and passed by it to the user. So regardless whether $wgInstantCommons fetches thumbnails over http or https, the user will still get the images over the same protocol as the the rest of the page. Hmm, true. This would be useful for direct thumbnail fetches but you're right that it would not be useful for direct server-to-server requests. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 --- Comment #11 from Chad H. innocentkil...@gmail.com 2011-11-11 20:52:09 UTC --- (In reply to comment #10) (In reply to comment #9) What is exactly the usefulness of this? As far as I know thumbnails are cached on the local server, and passed by it to the user. So regardless whether $wgInstantCommons fetches thumbnails over http or https, the user will still get the images over the same protocol as the the rest of the page. Hmm, true. This would be useful for direct thumbnail fetches but you're right that it would not be useful for direct server-to-server requests. Right, assuming you're using $wgUseInstantCommons and not configuring $wgForeignFileRepos yourself, the direct thumb fetches won't happen (hence my comment above about it only affecting the description urls). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 --- Comment #12 from Ryan Lane rlan...@gmail.com 2011-11-11 21:04:31 UTC --- Well, it should be configurable, at least. If a site is using instant commons, and is https-only, then it's possible the http connection between the site and commons could be used as an attack vector. From a load perspective, I think it'll be totally fine. The ssl servers are completely bored right now. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 --- Comment #7 from Chad H. innocentkil...@gmail.com 2011-11-10 17:00:18 UTC --- (In reply to comment #6) I'd recommend simply using https unconditionally here -- an SSL image on a non-SSL page should be perfectly legit. I'm not opposed to this, as long as ops says the https setup can take the load :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Normal Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 --- Comment #6 from Brion Vibber br...@wikimedia.org 2011-11-07 18:31:42 UTC --- I'd recommend simply using https unconditionally here -- an SSL image on a non-SSL page should be perfectly legit. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com, ||bryan.tongm...@gmail.com Component|Installation|Images and files --- Comment #1 from Chad H. innocentkil...@gmail.com 2011-11-05 22:34:04 UTC --- Tweaking component, has nothing to do with installation. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 --- Comment #2 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-11-05 22:36:16 UTC --- This just requires a small tweak in Setup.php. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219 Bryan Tong Minh bryan.tongm...@gmail.com changed: What|Removed |Added Keywords||easy -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219
--- Comment #3 from Chad H. innocentkil...@gmail.com 2011-11-05 22:39:56 UTC
---
(In reply to comment #2)
This just requires a small tweak in Setup.php.
Right now we use apibase with an http:// url. I'm not quite sure how curl/fopen
will react to using that when we're getting the metadata.
There should be a way to configure the This description is from {foo url} bit
without changing the API calls.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219
--- Comment #4 from Umherirrender umherirrender_de...@web.de 2011-11-06
00:33:30 UTC ---
(In reply to comment #3)
There should be a way to configure the This description is from {foo url}
bit
without changing the API calls.
It is not alone the link to the description. With a https apibase the images
are also loaded with https. The images should load also with a protocol
relative url, but prop=imageinfoiiprop=url is giving a explicit protocol.
Maybe add an other iiprop which returns a protocol relative url, if the repo
wiki support that.
Maybe this can also corrupt the internal cache of api calls.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32219] Make $wgUseInstantCommons protocol relative
https://bugzilla.wikimedia.org/show_bug.cgi?id=32219
--- Comment #5 from Chad H. innocentkil...@gmail.com 2011-11-06 01:19:30 UTC
---
(In reply to comment #4)
(In reply to comment #3)
There should be a way to configure the This description is from {foo url}
bit
without changing the API calls.
It is not alone the link to the description. With a https apibase the images
are also loaded with https. The images should load also with a protocol
relative url, but prop=imageinfoiiprop=url is giving a explicit protocol.
Maybe add an other iiprop which returns a protocol relative url, if the repo
wiki support that.
Maybe this can also corrupt the internal cache of api calls.
The thumbnails are requested by the server, not by the client (unless you're
manually configuring $wgForeignFileRepos, but the bug says
$wgUseInstantCommons).
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
