[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 Lupo lupo.bugzi...@gmail.com changed: What|Removed |Added CC||yyairr...@gmail.com --- Comment #16 from Lupo lupo.bugzi...@gmail.com 2012-05-03 10:41:06 UTC --- *** Bug 29359 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 Lupo lupo.bugzi...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED AssignedTo|wikibugs-l@lists.wikimedia. |lupo.bugzi...@gmail.com |org | Target Milestone|--- |1.20.0 release --- Comment #15 from Lupo lupo.bugzi...@gmail.com 2012-05-01 06:02:53 UTC --- Follow-up change https://gerrit.wikimedia.org/r/5929 (whitespace and a typo in a comment). See also bug 35240: if a wiki has site or user modules disabled altogether, they'll now end up with state missing in the client-side loader. However, the state machine in mw.loader is incomplete and doesn't handle failing modules correctly. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 Max Semenik maxsem.w...@gmail.com changed: What|Removed |Added Keywords|need-review | CC||maxsem.w...@gmail.com --- Comment #14 from Max Semenik maxsem.w...@gmail.com 2012-04-19 15:27:47 UTC --- Rm need-review as it's in Git now. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 --- Comment #13 from Lupo lupo.bugzi...@gmail.com 2012-04-05 11:10:38 UTC --- https://gerrit.wikimedia.org/r/4326 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added CC||suma...@panix.com --- Comment #12 from Sumana Harihareswara suma...@panix.com 2012-04-03 16:03:40 UTC --- Lupo, could you put this patch in Gerrit to make it easier to review? https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch Thanks! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 --- Comment #10 from Lupo lupo.bugzi...@gmail.com 2012-04-02 21:18:51 UTC --- Created attachment 10367 -- https://bugzilla.wikimedia.org/attachment.cgi?id=10367 Patch implementing the proposed solution: pre-register default modules with state 'loading' This patch does prevent the double loading of the default modules if they're used as explicit dependencies (or if someone tries to load them explicitly). Please note the FIXME in the patch; it appears to me that this is an issue that exists in the current code and which is not fixed by this patch. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 Lupo lupo.bugzi...@gmail.com changed: What|Removed |Added Keywords||need-review, patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 Lupo lupo.bugzi...@gmail.com changed: What|Removed |Added Attachment #10367|0 |1 is obsolete|| --- Comment #11 from Lupo lupo.bugzi...@gmail.com 2012-04-02 21:24:16 UTC --- Created attachment 10368 -- https://bugzilla.wikimedia.org/attachment.cgi?id=10368 Patch implementing the proposed solution: pre-register default modules with state 'loading' Fixes a typo. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 --- Comment #9 from Lupo lupo.bugzi...@gmail.com 2012-03-26 06:05:03 UTC --- (In reply to comment #1) Also, what kind of extension module would load 'site' or 'user'? That sounds evil to me. Not evil at all. Use cases from the Commons: Common.js implements some cookie-based preference mechanism called JSconfig for gadgets and other scripts. (The code for this is in Common.js because that used to be loaded also on Special:Preferences, so the script could add UI elements allowing the user to comfortably set these preferences. I just noticed that Common.js isn't loaded anymore on Special:Preferences, so that doesn't work anymore. However, I notice that the user.groups module is loaded on Special:Preferences...) Gadgets who want to query these JSconfig settings have a dependency on the site module. Another way to define settings for gadgets that is widely employed is by letting users configure gadget behavior through flags and variables set in their user JS. That, however, means that gadgets using this mechanism have a dependency on the user module. Both mechanisms used to work fine, because user JS and site scripts were loaded before gadgets executed. Sine MW 1.19 (or maybe already 1.18), that is no longer true. So, in summary, we need: * A way to set gadget preferences. Maybe by having some JS loaded and executed also on Special:Preferences. Or give us a new page Special:GadgetPreferences where JS can run and add prefs. Or some way to specify declaratively which preferences a certain gadget has. * A way of specifying dependencies on the default-loaded modules without causing them to be loaded multiple times. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537
Lupo lupo.bugzi...@gmail.com changed:
What|Removed |Added
CC||lupo.bugzi...@gmail.com
--- Comment #6 from Lupo lupo.bugzi...@gmail.com 2012-03-25 21:42:28 UTC ---
Ran into this problem at the Commons now.
Site module is loaded by default and does a mw.loader.state('site', 'ready') at
the end. However, a gadget used mw.loader.using(['site, 'user'], ...) and got
executed earlier. mw.loader.using didn't know about 'site' being in transit,
and issued a second request. (Ditto for 'user'.) That second request even
arrived and executed before the default request. Because it ran the site module
in a closure, we indeed hit an undefined variable exception later on in the
gadget.
This particular error has been fixed by replacing a var Foo = {...} in the
Commons' Common.js by window.Foo = {...}, but still loading this module twice
may have arbitrary side-effects.
mw.loader.using really should special-case the default loaded modules site,
user, user.groups. It is evidently useful to be able to specify them as
dependencies in mw.loader.using(), but we don't want to load them a second
time.
So why not simply adapt mw.loader to have the default-loaded modules
pre-registered with a 'loading' state?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537
--- Comment #7 from Lupo lupo.bugzi...@gmail.com 2012-03-25 21:43:07 UTC ---
As a temporary work-around for the site module, I think wrapping the whole
Common.js into
if( mw.loader.getState( 'site' ) !== 'ready' ) {
...
}
should work. Roan, is this correct?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 Lupo lupo.bugzi...@gmail.com changed: What|Removed |Added Severity|enhancement |normal --- Comment #8 from Lupo lupo.bugzi...@gmail.com 2012-03-25 21:46:53 UTC --- This work-around won't work for the user module, though. mw.loader.using requests the user module without the user= parameter and thus gets back an empty module. If that arrives first, mw.loader may consider the dependency to be fulfilled although the real user module hasn't been loaded/executed yet. Now that is a bug, and therefore I'm elevating this from enhancement to normal. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 --- Comment #3 from Roan Kattouw roan.katt...@gmail.com 2011-11-24 10:02:01 UTC --- To fix the problem you had on zhwiki, I suggest putting ULS in a hidden gadget (are hidden gadgets supported on the live site? I forgeT) so you can use mw.loader.using( 'ext.gadgets.uls', ... ) as appropriate. Re the actual bug, maybe we should disallow calling load() on site and user somehow. They're weird modules because they're loaded raw, which means the usual guards against double-loading fail; however, they're also loaded on every page, so calling load() on them is always unnecessary. So there the good news is your load() call would stop working (which fixes the double-loading bug), and the bad news is your load() call would stop working (which breaks your hack). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537
--- Comment #4 from Liangent liang...@gmail.com 2011-11-24 10:18:14 UTC ---
(In reply to comment #3)
To fix the problem you had on zhwiki, I suggest putting ULS in a hidden gadget
(are hidden gadgets supported on the live site? I forgeT) so you can use
mw.loader.using( 'ext.gadgets.uls', ... ) as appropriate.
That's exactly what I did at
http://zh.wikipedia.org/wiki/MediaWiki:Gadget-site-lib.js . I set the
description text to a blank string and hid the checkbox with site CSS. I cannot
find an option to set a gadget as hidden, even in trunk.
Re the actual bug, maybe we should disallow calling load() on site and user
somehow. They're weird modules because they're loaded raw, which means the
usual guards against double-loading fail; however, they're also loaded on
every
page, so calling load() on them is always unnecessary. So there the good news
is your load() call would stop working (which fixes the double-loading bug),
and the bad news is your load() call would stop working (which breaks your
hack).
Why do we have to load them raw? or can we wrap the whole content with an
if(){} of loading state check.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537
--- Comment #5 from Roan Kattouw roan.katt...@gmail.com 2011-11-24 10:41:58
UTC ---
(In reply to comment #4)
Why do we have to load them raw? or can we wrap the whole content with an
if(){} of loading state check.
We didn't want to load them in a closure like normal modules, because that
could break function definitions that are expected to be global etc. It should
be OK to wrap them in an if statement or do anything else that doesn't involve
wrapping them in a closure, though.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 --- Comment #1 from Roan Kattouw roan.katt...@gmail.com 2011-11-23 10:44:56 UTC --- How could we possibly detect this case? The script tag is produced server-side. Also, what kind of extension module would load 'site' or 'user'? That sounds evil to me. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537
--- Comment #2 from Liangent liang...@gmail.com 2011-11-23 15:17:01 UTC ---
On zhwiki, there were a bunch of JavaScript tools depending on wgULS which is a
converter for zh variants and was defined in Common.js and those tools worked
fine. After some time they don't work anymore because wgULS is not defined. I
tried to add mw.loader.using('site', to them and found the site JS run twice
and filed this bug.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32537] Don't load some (default) modules if they've been loaded before
https://bugzilla.wikimedia.org/show_bug.cgi?id=32537 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Normal Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
