https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #38 from DieBuche diebu...@gmail.com 2010-12-13 19:35:56 UTC ---
Created attachment 7907
-- https://bugzilla.wikimedia.org/attachment.cgi?id=7907
Tests
I can't seem to remember why I made the ul inline-block, seems to work this
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #39 from DieBuche diebu...@gmail.com 2010-12-13 19:37:59 UTC ---
Created attachment 7908
-- https://bugzilla.wikimedia.org/attachment.cgi?id=7908
Cite
cite test patch as well
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #36 from foma...@googlemail.com 2010-12-11 19:44:25 UTC ---
full-width as default is good, but a clear for floating objects is not good.
With
ul.gallery { display: block }
its possible to have full-width without a clear for
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
Aryeh Gregor simetrical+wikib...@gmail.com changed:
What|Removed |Added
Status|REOPENED|RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #35 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-12-09
17:02:36 UTC ---
I think it should be full-width by default. If it interferes with floats in
particular cases, those can be fixed manually. Surely it's pretty rare to
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #34 from Derk-Jan Hartman hart...@videolan.org 2010-12-09
00:21:37 UTC ---
@Diebuche, can you fix the parser tests please ? I looked at them, but I can't
figure out what the desired behavior should be.
@fomafix this behavior is
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
foma...@googlemail.com changed:
What|Removed |Added
Status|RESOLVED|REOPENED
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
Derk-Jan Hartman hart...@videolan.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #32 from Derk-Jan Hartman hart...@videolan.org 2010-12-05
22:42:04 UTC ---
committed in r77836
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #30 from DieBuche diebu...@gmail.com 2010-11-30 19:34:48 UTC ---
Created attachment 7877
-- https://bugzilla.wikimedia.org/attachment.cgi?id=7877
Followup
Here's a follow-up. It does three things:
1. Adds a line css to actually
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #26 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-11-28
19:20:00 UTC ---
It's caused by $wgUseTidy = true;. It seems like a Tidy bug -- I don't know
what objection it had to your original markup, it validates just fine. A
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
DieBuche diebu...@gmail.com changed:
What|Removed |Added
Blocks||2542
--
Configure
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #27 from DieBuche diebu...@gmail.com 2010-11-28 23:19:10 UTC ---
Ah, ok, I'll file a bug for that later on.
Regarding the space between images: one margin got duplicated. remove margin:
2px; in shared.css, line 794 it should look
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
P.Copp paul.copper...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
Aryeh Gregor simetrical+wikib...@gmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #24 from DieBuche diebu...@gmail.com 2010-11-26 09:13:23 UTC ---
weird, something in your install is causing the generation of empty li before
each image li (li style=list-style: none/li) These are by default
display:block, so they
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #25 from DieBuche diebu...@gmail.com 2010-11-26 18:52:55 UTC ---
Created attachment 7871
-- https://bugzilla.wikimedia.org/attachment.cgi?id=7871
Fix empty list elements
I greped through the trunk all extensions, but couldn't
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #23 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-11-26
00:05:42 UTC ---
Created attachment 7869
-- https://bugzilla.wikimedia.org/attachment.cgi?id=7869
Before and after HTML output with patch applied
I'm running trunk,
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #22 from DieBuche diebu...@gmail.com 2010-11-23 19:51:19 UTC ---
Weird, I can't reproduce that (in neither chrome nor ff4). You applied it to
the trunk, right?
I just tried again with a clean install from svn it behaves as expected.
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #21 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-11-22
20:36:38 UTC ---
Created attachment 7849
-- https://bugzilla.wikimedia.org/attachment.cgi?id=7849
Screenshot with patch applied, incorrect results
Testing the patch
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
DieBuche diebu...@gmail.com changed:
What|Removed |Added
Attachment #7803|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #18 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-11-19
00:36:55 UTC ---
Your patch is broken, the line numbers are missing:
@@ -%ld,%ld +%ld,%ld @@
Could you generate a correct patch using svn diff? (Or is this broken one
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #19 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-11-19
00:45:21 UTC ---
(Sorry for the slow response, by the way. I'll try to be more prompt for
future iterations if I can manage it.)
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
DieBuche diebu...@gmail.com changed:
What|Removed |Added
Attachment #7792|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
DieBuche diebu...@gmail.com changed:
What|Removed |Added
Blocks||3770
--
Configure
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
DieBuche diebu...@gmail.com changed:
What|Removed |Added
Keywords||patch
--
Configure
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
Aryeh Gregor simetrical+wikib...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #12 from DieBuche diebu...@gmail.com 2010-11-07 18:08:22 UTC ---
zoom: 1 makes an element get hasLayout in IE.
For some reasons a block element that hasLayout and has display:inline
explicitely set, is treated as inline-block in
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #13 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-11-07
18:57:28 UTC ---
If you're willing to provide a comprehensive test case and test it in all
important browsers, I'd be okay with committing this. The test case should
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #14 from DieBuche diebu...@gmail.com 2010-11-07 23:06:56 UTC ---
Here's a testpage I build (using li's now, I'll update the patch later..).
Looks good for me in Webkit and Firefox and Opera. I'll test IE6-8 tomorrow at
work.
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #15 from DieBuche diebu...@gmail.com 2010-11-07 23:07:49 UTC ---
sry for the double post, forgot the link:
http://dl.dropbox.com/u/442163/fluidGallery.html
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
Aryeh Gregor simetrical+wikib...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
DieBuche diebu...@gmail.com changed:
What|Removed |Added
CC||diebu...@gmail.com
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #10 from DieBuche diebu...@gmail.com 2010-11-05 15:23:34 UTC ---
Created attachment 7792
-- https://bugzilla.wikimedia.org/attachment.cgi?id=7792
Basic, working patch
here's a quick patch perrow is not yet refactored, best way imo
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
--- Comment #8 from Subfader subfa...@gmail.com 2009-04-01 16:10:05 UTC ---
As of now ResizeGalleries.js breaks the manual Gallery's perrow=. If set
manually it shouldn't be overridden.
https://bugzilla.wikimedia.org/show_bug.cgi?id=3276
P.Copp paul.copper...@googlemail.com changed:
What|Removed |Added
CC|
36 matches
Mail list logo
