[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 --- Comment #14 from Peter Bena benap...@gmail.com --- (In reply to comment #12) I think this small (~30 lines) obscure templating feature should just be in the core. I would prefer to have core as small as possible and as fast as possible. But given the amount of mess that is already in core, I think that inserting some 30 lines more wouldn't hurt. So... I don't have problem with that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Tim Starling tstarl...@wikimedia.org changed: What|Removed |Added CC||tstarl...@wikimedia.org --- Comment #12 from Tim Starling tstarl...@wikimedia.org --- I think this small (~30 lines) obscure templating feature should just be in the core. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Krenair kren...@gmail.com changed: What|Removed |Added CC||kren...@gmail.com --- Comment #13 from Krenair kren...@gmail.com --- (In reply to comment #10) Petr: Could you comment on comment 3 please? https://www.mediawiki.org/wiki/Extension:InteractiveBlockMessage links to SVN (not converted to using Git yet so likely not actively developed?). Looks like it is in Git: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/InteractiveBlockMessage.git;a=summary -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords|patch-need-review | Priority|Unprioritized |Lowest --- Comment #10 from Andre Klapper aklap...@wikimedia.org --- Petr: Could you comment on comment 3 please? https://www.mediawiki.org/wiki/Extension:InteractiveBlockMessage links to SVN (not converted to using Git yet so likely not actively developed?). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 --- Comment #11 from MZMcBride b...@mzmcbride.com --- (In reply to comment #10) Petr: Could you comment on comment 3 please? Comment 7 as well. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 --- Comment #9 from Sumana Harihareswara suma...@wikimedia.org 2012-11-16 22:34:55 UTC --- Petr, just pinging to see whether you have had time to look at the code critique. Thanks! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Sam Reed (reedy) s...@reedyboy.net changed: What|Removed |Added Keywords|shell | --- Comment #8 from Sam Reed (reedy) s...@reedyboy.net 2012-04-17 14:43:42 UTC --- -shell as it's not ready for deploy -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||need-review CC||suma...@panix.com Blocks||31235 --- Comment #6 from Sumana Harihareswara suma...@panix.com 2012-04-04 13:50:00 UTC --- Petr, please respond to these criticisms from bawolff. Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 MZMcBride b...@mzmcbride.com changed: What|Removed |Added URL||https://www.mediawiki.org/w ||iki/Extension:InteractiveBl ||ockMessage CC||b...@mzmcbride.com --- Comment #7 from MZMcBride b...@mzmcbride.com 2012-04-05 05:53:25 UTC --- English Wikipedia templates are copied to other wikis very often. I'm not sure adding an extension dependency is a good idea here. Is there a reason an extension was chosen rather than implementing this magic word in core? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Bugmeister Bot mhershber...@wikimedia.org changed: What|Removed |Added CC||mhershber...@wikimedia.org --- Comment #4 from Bugmeister Bot mhershber...@wikimedia.org 2011-12-15 15:11:18 UTC --- Baowolff, you missed Bug 32128 which this bug should depend on. I've pointed to your review there. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Bugmeister Bot mhershber...@wikimedia.org changed: What|Removed |Added Depends on||32128 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Bugmeister Bot mhershber...@wikimedia.org changed: What|Removed |Added Depends on|32128 | --- Comment #5 from Bugmeister Bot mhershber...@wikimedia.org 2011-12-15 15:20:16 UTC --- (In reply to comment #4) Baowolff, you missed Bug 32128 which this bug should depend on. I've pointed to your review there. bleh. Forget this. I screwed up. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Bawolff bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #3 from Bawolff bawolff...@gmail.com 2011-12-15 06:56:57 UTC --- Thought I'd look over this extension and give some thoughts: Line 28 of InteractiveBlockedMessage.php: $wgAutoloadClasses['InteractiveBlockMessage'] = $dir/InteractiveBlockMessage.php; I'm not sure what that's about (It won't hurt anything, but there is no such class, so it probably shouldn't be there) *LanguageGetMagic hook usage - That's probably ok, but if you use a .magic.i18n.php file, the magic word name can be translated at translatewiki (I think anyways) *MagicWord id being all capitalized - Doesn't really matter, but the magic word id (not the actual magic word, just its internal id) are all lowercase for all the magic words in core *$user-isBlocked() call - should perhaps pass a true to explicitly ask the result to come from slave (doesn't really matter though, since slave is default, but good to be explicit) *Doesn't work on anon user pages (not sure if intentional or not. if it's wanted, all that needs to be done is pass false as second argument to user::newFromName) if it did work for anons, there might be security implications in revealing auto-blocks (As mentioned on the en wp page, although given the number of autoblocks in place at one time, it'd be difficult to glean much from this, but still not a good thing) *If the user causes their own user page to be rendered, the magic word will report true if the user is blocked via auto-blocks, proxy auto-blocker, or DNSBL block (although I don't think the last two are used by wikimedia). This is inconsistent (Compared to other people rendering the page), and probably a bad thing (Although not horrible). Perhaps better to use Block::newFromTarget directly, in which case it would only look at explicit blocks (and could also be used on anon user pages without leaking auto-blocks). *We should perhaps add a hook to SpecialUnblock::processUnblock so that this extension could explicitly purge user pages on an explicit unblock. -- Cheers --- btw, does this extension still need review by the senior dev cabal? (I know there is a mailing list thread about that) if so, it should have the keyword need-review and be blocking bug 31235. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 --- Comment #2 from Peter Bena benap...@gmail.com 2011-12-12 12:56:19 UTC --- it's closed now so you can deploy it. Thanks! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 --- Comment #1 from Reedy s...@reedyboy.net 2011-12-06 15:33:53 UTC --- Note, said discussion hasn't concluded/been closed -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Ian Baker iba...@wikimedia.org changed: What|Removed |Added Keywords||shell -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32819] Deploy InteractiveBlockMessage on enwiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 Ian Baker iba...@wikimedia.org changed: What|Removed |Added Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
