[Bug 37382] Gerrit doesn't show links to diff pictures a consistent way
https://bugzilla.wikimedia.org/show_bug.cgi?id=37382 --- Comment #5 from Chad H. innocentkil...@gmail.com --- This is for cleaning up the links to diffs. Which seems to be fixed (although the bug was never closed upstream). The other bug (about image diffs not showing) is bug 47519 (which is now fixed too). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37382] Gerrit doesn't show links to diff pictures a consistent way
https://bugzilla.wikimedia.org/show_bug.cgi?id=37382 --- Comment #4 from Andre Klapper aklap...@wikimedia.org --- Wondering which behavior is requested in this bug report. Dereckson, could you clarify? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37382] Gerrit doesn't show links to diff pictures a consistent way
https://bugzilla.wikimedia.org/show_bug.cgi?id=37382 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added URL|http://code.google.com/p/ge |https://gerrit.wikimedia.or |rrit/issues/detail?id=1426 |g/r/#/c/9591 CC||aklap...@wikimedia.org See Also||http://code.google.com/p/ge ||rrit/issues/detail?id=1426 --- Comment #3 from Andre Klapper aklap...@wikimedia.org --- (In reply to comment #0) When a git commit contains changes to a picture file, the Gerrit UI interface prints: * two links to see the old and the now pictures in the Side-by-side column * a link to see both logos side by side in the unified column This isn't intuitive nor ergonomic and could mislead a reviewer. This has changed in the meantime. On https://gerrit.wikimedia.org/r/#/c/9591 I only get Binary files differ now when trying to view the diff. Wondering which behavior is requested in this bug report. Dereckson, could you clarify? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37382] Gerrit doesn't show links to diff pictures a consistent way
https://bugzilla.wikimedia.org/show_bug.cgi?id=37382 --- Comment #1 from Dereckson dereck...@espace-win.org 2012-06-06 21:40:25 UTC --- Created attachment 10697 -- https://bugzilla.wikimedia.org/attachment.cgi?id=10697 Gerrit change 9591 - an image diff Image diff links -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37382] Gerrit doesn't show links to diff pictures a consistent way
https://bugzilla.wikimedia.org/show_bug.cgi?id=37382 Dereckson dereck...@espace-win.org changed: What|Removed |Added Keywords||upstream Priority|Unprioritized |Normal URL||http://code.google.com/p/ge ||rrit/issues/detail?id=1426 --- Comment #2 from Dereckson dereck...@espace-win.org 2012-06-06 21:55:21 UTC --- Adding upstream keyword. Upstream bug: http://code.google.com/p/gerrit/issues/detail?id=1426 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l