[Bug 37564] html lang= attribute should always be set to an invalid language code

2014-04-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37564

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

Summary|html lang= attribute|html lang= attribute
   |shouldn't be set to an  |should always be set to an
   |invalid language code   |invalid language code

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37564] html lang= attribute should always be set to an invalid language code

2014-04-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37564

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Krinkle krinklem...@gmail.com ---
(In reply to Krinkle from comment #0)
 So urls like:
 * https://en.wikipedia.org/wiki/Main_Page?uselang=a%27%20onmouseover
 * https://en.wikipedia.org/wiki/Main_Page?uselang=krinkle
 
 should have html lang=en

The first one now has html lang=en.

The latter doesn't, but that seems to be in intentional hack in MediaWiki for
the purpose of allowing {{int:}} hack customisation.

See implementation of Language::isValidCode, which explicitly doesn't check
whether a language exists, in order to allow {{int:}} hacks such as
historically used on Wikimedia Commons to provide an extra dimension of
interface customisation:

-
https://commons.wikimedia.org/w/index.php?title=Special:Uploaduselang=ownwork
-
https://commons.wikimedia.org/w/index.php?title=Special:Uploaduselang=fromflickr
-
https://commons.wikimedia.org/w/index.php?title=Special:Uploaduselang=fromgov

So until we decide do no longer support that, it makes sense to have this
consistently reflected throughout and not make a weird exception just for html
lang but not anywhere else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37564] html lang= attribute should always be set to an invalid language code

2014-04-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37564

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com
   Target Milestone|Future release  |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37564] html lang= attribute should always be set to an invalid language code

2014-04-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37564

--- Comment #5 from Liangent liang...@gmail.com ---
The new summary, .. should always be set to an invalid .. ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l