[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2014-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |NEW
 CC||aklap...@wikimedia.org

--- Comment #22 from Andre Klapper aklap...@wikimedia.org ---
All patches mentioned in this report were merged or abandoned - I'm resetting
the ticket status.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2014-11-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

[[kgh]] mediaw...@kghoffmeyer.de changed:

   What|Removed |Added

 CC||mediaw...@kghoffmeyer.de

--- Comment #21 from [[kgh]] mediaw...@kghoffmeyer.de ---
(In reply to Gerrit Notification Bot from comment #18)
 Change 154523 merged by jenkins-bot:
 Fix “Incorrect error: You must select at least one namespace.”
 
 https://gerrit.wikimedia.org/r/154523

May this bug be considered fix in conjunction with change [1]? If yes it might
also by time to do a new release since a couple of other fixes were done in the
meantime.

[1]
https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FReplaceText.git/eb819cd4b07e70fbadfe2334d55205e5c9aaa959

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2014-08-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 CC||legoktm.wikipe...@gmail.com

--- Comment #19 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
Is a backport planned for this? If not, the target milestone should be
adjusted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2014-08-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

Yaron Koren yaro...@gmail.com changed:

   What|Removed |Added

   Target Milestone|MW 1.19 version |---

--- Comment #20 from Yaron Koren yaro...@gmail.com ---
Good point - I just removed the target milestone; I don't know why it was set
in the first place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2014-08-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 154523 merged by jenkins-bot:
Fix “Incorrect error: You must select at least one namespace.”

https://gerrit.wikimedia.org/r/154523

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2014-08-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||m...@everybody.org
 Resolution|WONTFIX |---

--- Comment #16 from Mark A. Hershberger m...@everybody.org ---
I've run into this exact problem running the latest from gerrit + a 1.19
MediaWiki.

The problem is that edit_pages, move_pages and selected namespaces aren't
passed in the pageListForm() method.

About to submit a patch to fix this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2014-08-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|REOPENED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2014-08-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 154523 had a related patch set uploaded by MarkAHershberger:
Fix “Incorrect error: You must select at least one namespace.”

https://gerrit.wikimedia.org/r/154523

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2013-01-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

badon fastgoldf...@gmail.com changed:

   What|Removed |Added

  Attachment #11566|0   |1
is obsolete||

--- Comment #14 from badon fastgoldf...@gmail.com ---
Created attachment 11669
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=11669action=edit
A patch for Woozle's edits with minor edits by badon

I tested Woozle's modification, and they work with Replace Text 0.9.6, but
there are some smaller problems. 

The descriptive text was confusing, so I clarified it a little. I also found
that using the exact value reported for max_input_vars did not work. In my test
case, max_input_vars was 1000, but I had to reduce the maximum to 995 to get it
work. The new descriptive text addresses that possibility.

Even though the limit is approximately 1000, the search results are not also
limited. That means if there are millions of search results, the entire result
set must be downloaded before the replace operation can proceed. So, Woozle's
fix solves part of the problem, but Replace Text is still practically unusable
on very large wikis.

Woozle's solution is a good starting place for working around the limitations
of Replace Text, so I produced a patch for it with my edits. I will also upload
the actual file. That should be sufficient for most people to resume using it
until a more polished fix can be implemented.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2013-01-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #15 from badon fastgoldf...@gmail.com ---
Created attachment 11670
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=11670action=edit
The patched file, for Replace Text users that need a fix immediately

Wiki admins can use this file instead of the patch, as a matter of convenience
to resume using ReplaceText immediately.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-12-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #12 from Andre Klapper aklap...@wikimedia.org ---
[This bug report is resolved/closed as WONTFIX, hence adding further comments
or even attachments doesn't make much sense without changing the status again.]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-12-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #13 from badon fastgoldf...@gmail.com ---
I think we're trying to make the case that the status should be changed to
FIXED, if you know what I mean.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-12-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #11 from Woozle woo...@hypertwins.com ---
Created attachment 11566
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=11566action=edit
modifications to deal with form-size bug

Attached is a modified version of the SpecialReplaceText.php file which deals
with the form-size limitation (allows user to limit how many results to
display). I also added a couple of code comments as I figured out how things
worked.

The modification was done on 12/1, so there may have been additional changes to
the main file since then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-12-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

Woozle woo...@hypertwins.com changed:

   What|Removed |Added

  Attachment #11566|application/opensearchdescr |text/php
  mime type|iption+xml  |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-12-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

badon fastgoldf...@gmail.com changed:

   What|Removed |Added

   Severity|normal  |critical

--- Comment #10 from badon fastgoldf...@gmail.com ---
It looks like the default value for max_input_vars is 1000, so ReplaceText
could detect when there are more than 1000 search results, and automatically
use that as a default limit value, and then deliver a different error message
that prompts the user to proceed with that limit, or enter another limit and
run the search again.

It appears that the max_input_vars parameter in PHP exists for the purpose of
reducing the effectiveness of some types of DoS attacks. As such, this bug
report and bug 43472 are relevant for security, so leaving a user with only a
workaround that requires access to the server configuration AND compromising
security, should be discouraged.

So, I'm elevating both bug reports to critical severity. I decided against
major severity because the known issues section on the extension page:

https://www.mediawiki.org/wiki/Extension:Replace_Text#Known_issues

mentions the possibility that some replacements may not actually be done, which
constitutes a loss of data that may or may not be recoverable after a partial
replace has been done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-12-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

badon fastgoldf...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=43472

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-12-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

badon fastgoldf...@gmail.com changed:

   What|Removed |Added

 Resolution|INVALID |WONTFIX

--- Comment #9 from badon fastgoldf...@gmail.com ---
I changed the status of this to WONTFIX, since the report was for an
incorrect error message that is still incorrect. This could be resolved as
FIXED if ReplaceText at least detected when large numbers of pages were being
returned, and it could give a different error message that explains what is
likely actually occurring with a server limitation. Then, the user could be
directed to use the feature enhancement I proposed here:

https://bugzilla.wikimedia.org/show_bug.cgi?id=43472

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-08-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

Yaron Koren yaro...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #8 from Yaron Koren yaro...@gmail.com 2012-08-31 17:39:31 UTC ---
Thanks to everyone for their contributions. I'm marking this bug as invalid,
since it didn't require any code changes. I added more info about the problem
to the Replace Text extension page.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-08-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

antony.seedho...@gmail.com changed:

   What|Removed |Added

 CC||antony.seedho...@gmail.com

--- Comment #4 from antony.seedho...@gmail.com 2012-08-30 13:48:57 UTC ---
http://php.net/manual/en/info.configuration.php

max_input_vars 1000 PHP_INI_PERDIR Available since PHP 5.3.9.

Increase to something much higher

Also, if your PHP has suhosin, 

suhosin.post.max_vars
suhosin.request.max_vars

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-08-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #5 from Jerry Pank jer...@connected-uk.com 2012-08-30 15:17:05 
UTC ---
Hi Anthony

Thanks for your input.

From the ReplaceText page, before even running a search, if I click the 'Check:
All' button, I immediately get a fatal Javascript error:

Timestamp: 30/08/2012 16:13:53
Error: ReferenceError: mwToggleSearchCheckboxes is not defined
Source File: http://www.cookipedia.co.uk/recipes_wiki/Special:ReplaceText
Line: 1

I can't see how changing the above php config var would have an effect upon
Javascript. Perhaps you can enlighten me?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-08-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #6 from antony.seedho...@gmail.com 2012-08-30 15:27:18 UTC ---
Hi, sorry, my solution is for the main bug.

When checking my firefox web console I also get the ReferenceError when
clicking the check all/none buttons, but they still work and nothing stops me
using the page.

Have you tried in another browser and/or with all browser plugins/addons
disabled?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-08-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #7 from Yaron Koren yaro...@gmail.com 2012-08-30 16:57:41 UTC ---
Antony - thanks for that discovery! I bet that was the issue.

Jerry - I think your bug is totally unrelated. Actually, I think that issue is
one that was fixed in the most recent version of Replace Text, 0.9.3.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-08-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

Jerry Pank jer...@connected-uk.com changed:

   What|Removed |Added

 CC||jer...@connected-uk.com

--- Comment #3 from Jerry Pank jer...@connected-uk.com 2012-08-10 16:54:45 
UTC ---
Have the same problem - no solution but maybe a few pointers:

MediaWiki1.18.1
PHP5.3.3 (apache2handler)
MySQL5.1.61
Replace Text (Version 0.9.1)

Other installed extensions here:
http://www.cookipedia.co.uk/recipes_wiki/Special:Version

Replace text was working - now fails with You must select at least one
namespaceerror on a huge replace (2000 pages)

The namespace checkbox info is not being passed by Javascript hence unchecked
ns error.

This is the javascript error generated 

Timestamp: 10/08/2012 17:29:40
Error: ReferenceError: mwToggleSearchCheckboxes is not defined
Source File: http://www.cookipedia.co.uk/recipes_wiki/Special:ReplaceText

From the system error log I see:

[Fri Aug 10 17:29:38 2012] [error] [client nnn.nnn.nnn.nnn] File does not
exist:
/home/httpd/vhosts/cookipedia.co.uk/httpdocs/wiki/skins/common/search.js,
referer: http://www.cookipedia.co.uk/recipes_wiki/Special:ReplaceText

probably called from line 330 SpecialReplaceText.php : 

// add javascript specific to special:search
$wgOut-addScriptFile( 'search.js' );

No search.js anywhere in my wiki dir tree
No search.js in a fresh test install of the mw repo
No search.js in the ReplaceText repo

I'm not sure where to look now?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-08-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

Woozle woo...@hypertwins.com changed:

   What|Removed |Added

   Priority|Unprioritized   |High
URL||http://www.issuepedia.org/S
   ||pecial:ReplaceText
 CC||woo...@hypertwins.com
   Platform|All |PC
Version|unspecified |REL1_19 branch
   Target Milestone|--- |MW 1.19 version
 OS/Version|All |Linux

--- Comment #1 from Woozle woo...@hypertwins.com 2012-08-03 02:39:34 UTC ---
I'm having this same problem, but also the Invert selections button isn't
working for me so I can't easily confirm that the not-really-a-workaround works
(hundreds of checkboxes to toggle manually).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38170] [ReplaceText] Incorrect error: You must select at least one namespace.

2012-08-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38170

--- Comment #2 from Yaron Koren yaro...@gmail.com 2012-08-03 03:05:12 UTC ---
Woozle - my guess is that there's some unrelated Javascript problem that's
causing invert selection to not work - and maybe the other issue as well. I
would recommend looking in the Javascript console in either Chrome or Firefox
to see if any error messages appear.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l