[Bug 38827] thumb should be preselected as format in the dialog to insert an image

2012-08-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38827

--- Comment #5 from kipod fur.hew...@gmail.com 2012-08-31 15:08:27 UTC ---
(In reply to comment #4)
 kipod, thumb is used almost always, in most languages and most projects so I
 don't see any real need for supporting configuration for changing it other 
 than
 thumb. 
 
 Supporting such configurations aren't common in JS, and isn't needed as you 
 may
 always hack the toolbar with something like:
 $('textarea').bind('wikiEditor-dialogs-loaded-insert-file',function(e){
 //setting default for insert dialog (get by id the needed element and set
 it's properties)
 });
 In such a way you can always set default for any field.

Thanks for the override code snippet.
My comment was meant not just for the thumb selection, but for all defaults.
e.g., some wikis may want to define specific size as default, while others may
not (Same goes for alignment). 
Also, please remember that as part of media wiki code, this goes not just to
wikimedia-foundation wikis, but to any other wiki using the media wiki code.

peace.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38827] thumb should be preselected as format in the dialog to insert an image

2012-08-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38827

--- Comment #4 from Eran Roz en...@walla.co.il 2012-08-26 17:04:23 UTC ---
kipod, thumb is used almost always, in most languages and most projects so I
don't see any real need for supporting configuration for changing it other than
thumb. 

Supporting such configurations aren't common in JS, and isn't needed as you may
always hack the toolbar with something like:
$('textarea').bind('wikiEditor-dialogs-loaded-insert-file',function(e){
//setting default for insert dialog (get by id the needed element and set
it's properties)
});
In such a way you can always set default for any field.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38827] thumb should be preselected as format in the dialog to insert an image

2012-08-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38827

Liron Dorfman ldorf...@nana.co.il changed:

   What|Removed |Added

 CC||ldorf...@nana.co.il
   Severity|normal  |major

--- Comment #3 from Liron Dorfman ldorf...@nana.co.il 2012-08-25 19:38:37 UTC 
---
Please make the change Kipod wrote about usable as soon as possible.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38827] thumb should be preselected as format in the dialog to insert an image

2012-08-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38827

kipod fur.hew...@gmail.com changed:

   What|Removed |Added

 CC||fur.hew...@gmail.com

--- Comment #2 from kipod fur.hew...@gmail.com 2012-08-21 12:42:31 UTC ---
(sorry for joining late). IMO, it will be best if the defaults can be set
per-project, overriding those hardcoded in the code itself.

as to implementation: Personally, i would prefer setting the defaults through
variables in common.js, rather than LocalSettings.php, so sysops can change it
when community decides (this would also allow, possibly, for users to set
different defaults for themselves, though it is not clear how valuable this
is).

peace.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38827] thumb should be preselected as format in the dialog to insert an image

2012-08-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38827

--- Comment #1 from Eran Roz en...@walla.co.il 2012-08-19 19:12:13 UTC ---
See patch: gerrit change 20654

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l