https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
--- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 145517 abandoned by Krinkle:
Set $wgUseTwoButtonsSearchForm false by default
Reason:
The bug is still under consideration. As it this, this feature would not be
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Trevor Parscal tpars...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
--- Comment #12 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com ---
(In reply to Trevor Parscal from comment #11)
2. We drop the advanced search button, since we have it through the
suggestions. If we must keep it, it needs to actually
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
--- Comment #6 from Krinkle krinklem...@gmail.com ---
Note: This is no longer used by MonoBook and not used by Vector either. Only
used by mediawiki/skins/Nostalgia. Perhaps we should subst Nostalgia's two
button form and rid the varirable?
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
--- Comment #7 from Krinkle krinklem...@gmail.com ---
Ah, Config class made it harder to find. Looked for $?wgUseTwoButtonsSearchForm
instead of UseTwoButtonsSearchForm.
Both MonoBook and CologneBlue actually still use it.
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
--- Comment #8
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
--- Comment #10 from Krinkle krinklem...@gmail.com ---
Created attachment 16343
-- https://bugzilla.wikimedia.org/attachment.cgi?id=16343action=edit
Proposed behaviour (UseTwoButtonsSearchForm=false)
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
--- Comment #9 from Krinkle krinklem...@gmail.com ---
Created attachment 16342
-- https://bugzilla.wikimedia.org/attachment.cgi?id=16342action=edit
Current behaviour (UseTwoButtonsSearchForm=true)
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 145517 had a related patch set uploaded by Rohan013:
$wgUseTwoButtonForm is set to false by default
https://gerrit.wikimedia.org/r/145517
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Priority|Normal |Low
--- Comment #4
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Assignee|krinklem...@gmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Summary|Set |Set
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Blocks||50039
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
--- Comment #3 from Krinkle krinklem...@gmail.com ---
(In reply to comment #2)
fwiw I agree. Who decides?
The decision shall be made by those who are to blame[1] for the effect the
decision will cause.
[1]
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Assignee|wikibugs-l@lists.wikimedia. |krinklem...@gmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Quim Gil q...@wikimedia.org changed:
What|Removed |Added
Keywords||design
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
--- Comment #1 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com
2012-09-30 15:00:40 UTC ---
We may also want to consider making it so that the go button in the
single-button form says Search not Go. Go is a bad name for a search
button.
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed:
What|Removed |Added
Blocks|
https://bugzilla.wikimedia.org/show_bug.cgi?id=40622
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Priority|Unprioritized |Normal
Target
20 matches
Mail list logo