[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 denny vrandecic denny.vrande...@wikimedia.de changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #13 from denny vrandecic denny.vrande...@wikimedia.de --- Closed older resolved bugs as verified. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 Daniel Kinzler daniel.kinz...@wikimedia.de changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 --- Comment #12 from Daniel Kinzler daniel.kinz...@wikimedia.de 2012-10-30 10:22:09 UTC --- THIMC: As Liangent points out, the above patch does not restore the previous behavior of getText() to return false on failure. However, that was never documented behavior, and getText() itself is now deprecated. Because of this, I think it's fine not to try to restore that behavior (and return an empty string instead). The problem with returning fdalse on failure is that now, getText() calls getContent(), and getContent() will return null if the content failed to load or was not available to the desired audient - you can't tell which. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 Daniel Kinzler daniel.kinz...@wikimedia.de changed: What|Removed |Added Status|NEW |ASSIGNED CC||daniel.kinz...@wikimedia.de --- Comment #11 from Daniel Kinzler daniel.kinz...@wikimedia.de 2012-10-29 17:50:14 UTC --- Fix for master in I1e13de14. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 Daniel Kinzler daniel.kinz...@wikimedia.de changed: What|Removed |Added Keywords||patch-in-gerrit -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 --- Comment #9 from Aude aude.w...@gmail.com 2012-10-24 06:33:56 UTC --- I'll let Daniel take a look at that and see how we can handle these cases in a nicer way. He will be back next week. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 --- Comment #10 from Sumana Harihareswara suma...@wikimedia.org 2012-10-25 03:57:38 UTC --- Reversion patchset https://gerrit.wikimedia.org/r/#/c/29800/ -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 Jeroen De Dauw jeroen_ded...@yahoo.com changed: What|Removed |Added CC||jeroen_ded...@yahoo.com --- Comment #2 from Jeroen De Dauw jeroen_ded...@yahoo.com 2012-10-23 12:22:05 UTC --- Liangent: thanks for pointing this out. This looks like something that should be fixed but is at the same time not high priority, as it is about the nice handling of a failure case which should not happen to begin with. (Unless I misunderstand the issue, which is quite possible, as I did not look at it that much.) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 --- Comment #3 from Liangent liang...@gmail.com 2012-10-23 12:53:17 UTC --- (In reply to comment #2) Liangent: thanks for pointing this out. This looks like something that should be fixed but is at the same time not high priority, as it is about the nice handling of a failure case which should not happen to begin with. (Unless I misunderstand the issue, which is quite possible, as I did not look at it that much.) I'm running a bot using MediaWiki as a framework on Toolserver with replicated DB. Since text is not available in DB, when $rev-getText() is called, text is loaded from my modified Revision::loadText() via network to WMF server which has a higher chance to fail. In past, $rev-getText() returns false and my bot code can ignore that. Now my bot process is just killed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 --- Comment #4 from Liangent liang...@gmail.com 2012-10-23 12:56:42 UTC --- It's possible to catch the exception and check for the string TextContent expects a string in the constructor. (because I don't want to ignore other kinds of exceptions) but determining error type by looking at the human-readable error message sounds nasty. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 Aude aude.w...@gmail.com changed: What|Removed |Added CC||aude.w...@gmail.com --- Comment #5 from Aude aude.w...@gmail.com 2012-10-23 16:17:38 UTC --- https://gerrit.wikimedia.org/r/#/c/29597/ -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 --- Comment #6 from Liangent liang...@gmail.com 2012-10-24 00:19:46 UTC --- (In reply to comment #5) https://gerrit.wikimedia.org/r/#/c/29597/ This makes the caller unable to distinguish loading failure or success with really blank content. See my use case above. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 --- Comment #7 from Sumana Harihareswara suma...@wikimedia.org 2012-10-24 05:47:30 UTC --- https://gerrit.wikimedia.org/r/#/c/29597/ has been merged. Close bug as Fixed? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 --- Comment #8 from Liangent liang...@gmail.com 2012-10-24 05:48:52 UTC --- (In reply to comment #7) https://gerrit.wikimedia.org/r/#/c/29597/ has been merged. Close bug as Fixed? Not so satisfied with this resolution... see my comment above. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41244] Revision::getContentInternal() is not handling text load failure properly
https://bugzilla.wikimedia.org/show_bug.cgi?id=41244 Sumana Harihareswara suma...@wikimedia.org changed: What|Removed |Added CC||suma...@wikimedia.org --- Comment #1 from Sumana Harihareswara suma...@wikimedia.org 2012-10-22 19:14:32 UTC --- Liangent, about how often does this affect the end user, and under what circumstances? Thanks for the report. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
