[Bug 41267] mediawiki.action.edit.preview is not loaded at Commons despite Use live preview (wpuselivepreview) is activated in [[Special:Preferences]]

2012-10-23 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=41267

Sam Reed (reedy) s...@reedyboy.net changed:

   What|Removed |Added

 Blocks||41298

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 41267] mediawiki.action.edit.preview is not loaded at Commons despite Use live preview (wpuselivepreview) is activated in [[Special:Preferences]]

2012-10-22 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=41267

--- Comment #1 from Rainer Rillke @commons.wikimedia rainerril...@hotmail.com 
2012-10-22 09:32:45 UTC ---
Commons runs 1.21wmf2

Also tested at dw.wp which runs 1.21wmf1 and there it works. So my guess is
that the bug slipped-in between the two versions.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 41267] mediawiki.action.edit.preview is not loaded at Commons despite Use live preview (wpuselivepreview) is activated in [[Special:Preferences]]

2012-10-22 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=41267

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Keywords||code-update-regression
   Priority|Unprioritized   |High
 CC||aklap...@wikimedia.org
Summary|[REGRESSION]|mediawiki.action.edit.previ
   |mediawiki.action.edit.previ |ew is not loaded at Commons
   |ew is not loaded at Commons |despite Use live preview
   |despite Use live preview  |(wpuselivepreview) is
   |(wpuselivepreview) is   |activated in
   |activated in|[[Special:Preferences]]
   |[[Special:Preferences]] |

--- Comment #3 from Andre Klapper aklap...@wikimedia.org 2012-10-22 16:28:36 
UTC ---
(Regression = keyword code-update-regression)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 41267] mediawiki.action.edit.preview is not loaded at Commons despite Use live preview (wpuselivepreview) is activated in [[Special:Preferences]]

2012-10-22 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=41267

Sam Reed (reedy) s...@reedyboy.net changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #4 from Sam Reed (reedy) s...@reedyboy.net 2012-10-22 16:50:43 
UTC ---
In the 1.20 release-notes:

* Live preview functionality has been improved and moved into the
 'mediawiki.action.edit.preview' module. The old 'mediawiki.legacy.preview'
module
  has been removed.

Looking at core, the only usage of 'mediawiki.action.edit.preview' is in the
resource definition

Original commit:
https://github.com/mediawiki/core/commit/4d4bfc27a1bedf6b0d1670707ac812fe36fe85ad

EditPage.php now:

if ( $wgUser-getOption( 'uselivepreview', false ) ) {
$wgOut-addModules( 'mediawiki.legacy.preview' );
}

It got killed by
https://github.com/mediawiki/core/commit/bb51a58e575b13eb8b6c496482f7066a7081f676

https://gerrit.wikimedia.org/r/29339

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l