[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Assignee|innocentkil...@gmail.com|wikibugs-l@lists.wikimedia. ||org -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 MZMcBride b...@mzmcbride.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #26 from MZMcBride b...@mzmcbride.com --- https://www.mediawiki.org/w/index.php?title=Manual:$wgEnableMWSuggestoldid=717172 contains... https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commitdiff;h=52c1739f721ec6cc34cd764e6c002cc0188ac346#patch2 This redirects to https://git.wikimedia.org/summary/mediawiki%2fcore%2egit/HEAD which isn't the expected behavior. Tentatively re-opening this bug as I'm not sure this it's resolved/fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #23 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 82044 merged by Ottomata: Fix double encoded characters in gitweb - gitblit forwards https://gerrit.wikimedia.org/r/82044 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 sp...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #24 from sp...@wikimedia.org --- The test cases at https://git.wikimedia.org/blob/operations%2Fpuppet.git/3c9c28f2c869c3eee471d9bf4aced12c3de9a039/templates%2Fapache%2Fsites%2Fgerrit.wikimedia.org.erb#L98 all work again, yay! In reply to comment #18 http://git.wikimedia.org/summary/?r=mediawiki/core.git That's probably simpler to implement in an Apache mod_rewrite rule rather than this fragile setup of URL-encoding exactly once. Until we figure out if there's also a simpler query string URL for linking to project files, we should stick to this complex but consistent approach. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #25 from Nemo federicol...@tiscali.it --- For the records, the LinkSearch queries of comment 1 now find only 463+8 links. I've not counted how many work. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #22 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 82044 had a related patch set uploaded by QChris: Fix double encoded characters in gitweb - gitblit forwards https://gerrit.wikimedia.org/r/82044 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 sp...@wikimedia.org changed: What|Removed |Added CC||christ...@quelltextlich.at --- Comment #18 from sp...@wikimedia.org --- (In reply to comment #17) gitblit required '/' in project paths be changed to %2F, so my Apache mod_rewrite rules triggered URL-encoding. This worked for a while, but now the %2F is getting URL-encoded a second time which turns the '%' into %25, and gitblit chokes on the resulting %25%2f. I suspect Christian Aistleitner's puppet commit f5a3b40b on Jun 29, which changed AllowEncodedSlashes from NoDecode to On, probably caused the break. (Despite my copious comments as to why it needs to be that way :-) .) I notice gitblit's own URLs to summaries are much simpler now, instead of the URL-encoded slashes after summary it is just http://git.wikimedia.org/summary/?r=mediawiki/core.git That's probably simpler to implement in an Apache mod_rewrite rule rather than this fragile setup of URL-encoding exactly once. I don't know if there's a simpler format for linking to a file within a project, the same rewrite rules also used to rewrite to https://git.wikimedia.org/raw/mediawiki%2fextensions%2fexamples.git/HEAD/BoilerPlate%2fREADME which now has %25%2f s and is likewise broken. Chad, are gitblit URLs documented anywhere? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #19 from Chad H. innocentkil...@gmail.com --- Not to my knowledge -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #20 from sp...@wikimedia.org --- Christian Aistleitner points out his check-in long predated mine (d'oh, sorry), so that isn't what changed; but while testing on my local Apache I did have to set AllowEncodedSlashes to NoDecode even though it was never in my patch. Someone could try this in the config, I don't know what else it would break. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #21 from Matthew Flaschen mflasc...@wikimedia.org --- The confusion was caused by the rebase. In patch set 1 of S's patch (https://gerrit.wikimedia.org/r/#/c/70370/1/templates/apache/sites/gerrit.wikimedia.org.erb), NoDecode was on in both sides. In patch set 2 (after rebase), it was AllowEncodedSlashes On on both sides (https://gerrit.wikimedia.org/r/#/c/70370/2/templates/apache/sites/gerrit.wikimedia.org.erb). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #17 from Matthew Flaschen mflasc...@wikimedia.org --- https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git is pretty simple and currently broken. It redirects: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git = https://git.wikimedia.org/summary/mediawiki%252fcore%252egit/HEAD = http://git.wikimedia.org/ It would be nice to get that working. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #16 from Andre Klapper aklap...@wikimedia.org --- FYI, Redirect rules: https://git.wikimedia.org/blob/operations%2Fpuppet.git/3c9c28f2c869c3eee471d9bf4aced12c3de9a039/templates%2Fapache%2Fsites%2Fgerrit.wikimedia.org.erb -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #13 from Nemo federicol...@tiscali.it --- Thanks indeed, do we have an estimate of how many of those mediawiki.org links are still broken? I see several which either don't redirect or redirect to the git.wm.o root; some can't be replaced (like grepping URLs) but most potentially could IIRC. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #14 from Chad H. innocentkil...@gmail.com --- Only links I still see are: https://www.mediawiki.org/w/index.php?title=Special%3ALinkSearchtarget=gerrit.wikimedia.org%2Fr%2Fgitweb They can probably be fixed manually. Are there others you're seeing? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #15 from Nemo federicol...@tiscali.it --- See the links in comment 1 for 753+8 links as of now (they were about 1500 after the first template fixes IIRC). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 70370 merged by Ryan Lane: Rewrite gerrit gitweb URLs to new gitblit https://gerrit.wikimedia.org/r/70370 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Chad H. innocentkil...@gmail.com --- Yay :D Thanks S for the patch, and thanks Ryan for the merge. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added CC||rainerril...@hotmail.com --- Comment #8 from Andre Klapper aklap...@wikimedia.org --- *** Bug 50398 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Liangent liang...@gmail.com changed: What|Removed |Added CC||liang...@gmail.com --- Comment #9 from Liangent liang...@gmail.com --- Can we write a small redirector at https://gerrit.wikimedia.org/r/gitweb instead of a bunch of adhoc rewrite rules? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #10 from Nemo federicol...@tiscali.it --- (In reply to comment #9) Can we write a small redirector at https://gerrit.wikimedia.org/r/gitweb instead of a bunch of adhoc rewrite rules? It can be added after all the other redirects to catch the URLs which didn't match previous rewrites, I suppose. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Blocks||50184 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/70370 (Gerrit Change If02ce0fe0ddd8a9b692a0d2526bdbed27a762fc4) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Nemo federicol...@tiscali.it changed: What|Removed |Added CC||aschulz4...@gmail.com, ||muta...@s23.org --- Comment #6 from Nemo federicol...@tiscali.it --- https://gerrit.wikimedia.org/r/#/c/68110/ for LocalisationUpdate MediaWiki core was done. For the rest, I understand some help would be needed with regex rules. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Nemo federicol...@tiscali.it changed: What|Removed |Added Blocks||49521 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Nemo federicol...@tiscali.it changed: What|Removed |Added CC||b...@mzmcbride.com --- Comment #2 from Nemo federicol...@tiscali.it --- Also the [[m:Interwiki map]] of course: MZ, can you update it? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #3 from MZMcBride b...@mzmcbride.com --- (In reply to comment #2) Also the [[m:Interwiki map]] of course: MZ, can you update it? I'd be happy to, I'm just not sure exactly what should be changed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #4 from Chad H. innocentkil...@gmail.com --- Swap the Git entry from: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/$1;a=log;h=refs/heads/master To something like: https://git.wikimedia.org/log/mediawiki%2Fextensions.git Perhaps? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 --- Comment #5 from Chad H. innocentkil...@gmail.com --- (In reply to comment #0) Ideally, also rewrite (some) old SVN URLs to deprecated/deleted directories: perhaps with GitBlit it will be easier, as I hear it has tree views to which we could at least fallback if there's not the specific thing one was looking for/has been redirected to. Wasn't planning to rewrite the SVN urls, since SVN is going to still exist as r/o. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Nemo federicol...@tiscali.it changed: What|Removed |Added Priority|Normal |High Assignee|wikibugs-l@lists.wikimedia. |innocentkil...@gmail.com |org | --- Comment #1 from Nemo federicol...@tiscali.it --- Chad said on bug 38383 that he's working on this. I've updated links on the most important templates: https://www.mediawiki.org/w/index.php?title=Special:Contributions/Nemo_bisdir=prevoffset=20130605202439limit=4target=Nemo+bis Example patterns to cover, from current links: https://www.mediawiki.org/w/index.php?title=Special%3ALinkSearchtarget=https%3A%2F%2Fgerrit.wikimedia.org%2Fr%2Fgitweblimit=5000 https://www.mediawiki.org/w/index.php?title=Special%3ALinkSearchtarget=http%3A%2F%2Fgerrit.wikimedia.org%2Fr%2Fgitweblimit=5000 http://markmail.org/search/?q=gitweb+list%3Aorg.wikimedia -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Nemo federicol...@tiscali.it changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Priority|High|Normal Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41961] Write redirect rules for GitBlit
https://bugzilla.wikimedia.org/show_bug.cgi?id=41961 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
