[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added Blocks||70819 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Blocks||69417 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Blocks||28397 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Blocks||35378 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #15 from Bartosz Dziewoński matma@gmail.com --- Reedy has just refurbished https://gerrit.wikimedia.org/r/#/c/87288/ which cherry-picks the first commit from the branch onto master, and I think he's working on the following patches. Tim, any chance of technical/performance review from you? :) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 250055655 250055...@qq.com changed: What|Removed |Added CC||250055...@qq.com Flags||Backport_WMF? --- Comment #14 from 250055655 250055...@qq.com --- 11 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Siebrand Mazeland siebr...@kitano.nl changed: What|Removed |Added Flags|Backport_WMF? | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #13 from Bartosz Dziewoński matma@gmail.com --- What's the progress on this? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #8 from Bawolff (Brian Wolff) bawolff...@gmail.com --- I took a quick look through the code (I was using it to make a prototype of a feature idea: http://tools.wmflabs.org/bawolff/whichisbetter ). It works well. A couple things I noticed though (Note I did not read the code in depth): *In Title::moveTo, the code seems to assume the cl_sortkey_prefix is the same for all collations. I do not think this is the case. *When running update.php, the script runs updateCollation.php before doing the schema changes from your code, instead of after. (Really I think it should run it after all extension schema change, in case someone abuses the Collation framework, to make a collation that depends on a schema change). Arguably this issue was here before your code. *From a language perspective, I think using the phrase Sorting method instead of collation for the message 'category-collation' would be better and less jargony. Some of the collation names ( 'Identity' ) are a bit jargony as well, but I guess that can't really be helped. We can't exactly use the word 'alphabetical', since they're all alphabetical. *On category pages, label for=mw-collation-selectSorting method:/label should have an id or class attribute so people could style it easily. Additionally I think it might look better with the css vertical-align: bottom. I'd submit gerrit patches for some of these, but I'm kind of unclear how to do that/should I do that given I don't really understand how long-term feature branches in gerrit are supposed to work. Should I just submit new patches to the chinese-collation branch? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #9 from Bawolff (Brian Wolff) bawolff...@gmail.com --- *On category pages, label for=mw-collation-selectSorting method:/label should have an id or class attribute so people could style it easily. Actually, I guess its pretty easy to style via #mw-collation-selector label -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #10 from Greg Grossmeier g...@wikimedia.org --- For completeness's sake: Liangent will be meeting up with the WMF Language team at Wikimania this year to go over what needs to be done/etc for this to go out. Please feel free to continue working on this before then, but there is no set deploy target date until after Wikimania. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added CC||pgi...@wikimedia.org --- Comment #11 from Siebrand s.mazel...@xs4all.nl --- Pasting feedback that was given by Pau Giner on 2013-05-24 after a request from Tim Starling. I made a review of the UI and provided some design ideas to solve potential issues. I'm not familiar with Chinese nor Chinese collation methods, so feel free to correct me if I made any wrong assumption in my analysis: * The use of technical linguistic term such as collation although correct may be confusing to regular users. Sorting seems a more common term that will allow to unify sorting-related options (more on this later). * The control breaks the heading layout in the current position. The line of the heading appears broken. To avoid this, I would move the selector below the heading line since the action affects the elements below the header. * Current ordering is communicated by the list itself, so we may consider making the selector more compact (e.g., using an icon with a clarification tooltip). * Not sure if this was considered, but if there is a collation method that is most commonly used it should be the default. It may be also interesting to remember which is the collation method the user selected last and use it as the default for the user. I know that the specific purpose of the extension is to support Chinese collation, but my concern is that when combining many different extensions the resulting UI gets inconsistently crowded, making it hard to access the great functionality provided by each individual extension. To avoid this, I would propose to create a unified entry point for sorting-like functionality that can be used consistently at different parts of the UI. I made a quick mockup to illustrate the idea: http://i.imgur.com/1uZD8nF.png -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667
--- Comment #12 from Bawolff (Brian Wolff) bawolff...@gmail.com ---
* The control breaks the heading layout in the current position. The line of
the heading appears broken. To avoid this, I would move the selector below the
heading line since the action affects the elements below the header.
Just as a note, it affects the elements below the next 3 headings, not just the
heading it is beside.
Not sure if this was considered, but if there is a collation method that is
most commonly used it should be the default. It may be also interesting to
remember which is the collation method the user selected last and use it as the
default for the user.
Given that Liangent added a user preference for preferred sorting, this seems
like a good idea to maybe make altering which sorting method was used change
that preference. The only possible worry I would have is in the case of
{{DEFAULTCOLLATION:...}} being specified, the interaction between remembering
the user's last choice, and the collation being overridden on a per-page basis,
might be unclear to the user. But I think that's a minor concern.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org changed: What|Removed |Added CC||jared.zimmerman@wikimedia.o ||rg Assignee|wikibugs-l@lists.wikimedia. |pgi...@wikimedia.org |org | -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #6 from Sam Reed (reedy) s...@reedyboy.net --- We have libicu48 version 4.8.1.1-3, so presumably nothing else needs doing to that extent. (In reply to comment #5) Would love to know what needs to be prioritized. The merge commit needs the various merge conflicts fixing, and also rebasing again onto core, as it's at least 10 weeks old, if not 18 weeks or so -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org changed: What|Removed |Added Keywords|design | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #5 from Greg Grossmeier g...@wikimedia.org --- (In reply to comment #4) (In reply to comment #3) According to Jared Zimmerman this morning, Pau did a design review of this recently and everything seemed ok (or, was going to be ok, or similar). Is that right, Liangent? Right Great, thanks for confirming, Liangent. I'd like this bug to have the needed next steps in it; could you tell me what you think they are from your end, Liangent (and anyone else who sees this bug mail). Would love to know what needs to be prioritized. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #3 from Greg Grossmeier g...@wikimedia.org --- According to Jared Zimmerman this morning, Pau did a design review of this recently and everything seemed ok (or, was going to be ok, or similar). Is that right, Liangent? -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #4 from Liangent liang...@gmail.com --- (In reply to comment #3) According to Jared Zimmerman this morning, Pau did a design review of this recently and everything seemed ok (or, was going to be ok, or similar). Is that right, Liangent? Right -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Rob Lanphier ro...@wikimedia.org changed: What|Removed |Added Keywords||design CC||ro...@wikimedia.org --- Comment #2 from Rob Lanphier ro...@wikimedia.org --- Tagging with design keyword, since there's a small dropdown that might use a little love. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com Blocks||30673, 30996 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Greg Grossmeier g...@wikimedia.org changed: What|Removed |Added CC||g...@wikimedia.org -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=43799 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 --- Comment #1 from Liangent liang...@gmail.com --- I94056ca2 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Blocks||30672 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Phillip Patriakeas dragonlordofxant...@gmail.com changed: What|Removed |Added CC||dragonlordofxanther@gmail.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 44667] Review, merge and deploy chinese-collation branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 Sam Reed (reedy) s...@reedyboy.net changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
