[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482
--- Comment #2 from Tony Thomas 01tonytho...@gmail.com ---
Is DIRECTORY_PATH variable an already defined one ?
should changing GitInfo.php#L53
$this-basedir = $isAbsolute ? $path : {$dir}/{$path};
to
$this-basedir = $isAbsolute ? $path : {$dir}.DIRECTORY_PATH.{$path};
or sth similar do the trick ?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482 --- Comment #3 from T. Gries m...@tgries.de --- (In reply to comment #2) Is DIRECTORY_PATH variable an already defined one ? What I meant was: use the PHP-built-in constant DIRECTORY_SEPARATOR (string) see http://us3.php.net/manual/dir.constants.php -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added Assignee|01tonytho...@gmail.com |wikibugs-l@lists.wikimedia. ||org -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added CC||01tonytho...@gmail.com Assignee|wikibugs-l@lists.wikimedia. |01tonytho...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Blocks||700 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482 T. Gries m...@tgries.de changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482 T. Gries m...@tgries.de changed: What|Removed |Added Keywords||easy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482 Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed: What|Removed |Added CC||mediawiki-bugs@nadir-seen-f ||ire.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482 --- Comment #1 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com --- You might want to make a general bug about that. Practically the entirety of core hardcodes /s. For all the path stuff we do we have a grand total of 12 uses of DIRECTORY_PATH inside of core. And 9 of them are in GlobalSettings. The last three files only use it once. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46482] GitInfo.php (used by Special:Version) should use DIRECTORY_PATH instead of hardcoded /
https://bugzilla.wikimedia.org/show_bug.cgi?id=46482 MZMcBride b...@mzmcbride.com changed: What|Removed |Added CC||b...@mzmcbride.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
