[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Andre Klapper changed: What|Removed |Added Whiteboard|gci2013 |gci2014 |https://www.mediawiki.org/w | |iki/Google_Code-In#Candidat | |e_tasks | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Andre Klapper changed: What|Removed |Added Priority|Unprioritized |Low -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #20 from Chris McMahon --- We can keep this open. I actually just added a sleep to a test because I needed to get on with other things, and I should return to fix it at some point. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Tony Thomas <01tonytho...@gmail.com> changed: What|Removed |Added Assignee|01tonytho...@gmail.com |wikibugs-l@lists.wikimedia. ||org -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #19 from Tony Thomas <01tonytho...@gmail.com> --- (In reply to Andre Klapper from comment #18) > Are there more tests containing sleep or is this fixed? > > Tony: Are you still working on this or should the assignee be reset to > default? I think there are a few more sleep keywords to be removed. Sorry, but I dont think I will be able to continue on this right now. Resetting to default assignee for the time being. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #18 from Andre Klapper --- Are there more tests containing sleep or is this fixed? Tony: Are you still working on this or should the assignee be reset to default? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Andre Klapper changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #17 from Andre Klapper --- All patches merged => resetting status from PATCH_TO_REVIEW to NEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #16 from Gerrit Notification Bot --- Change 109471 merged by jenkins-bot: Removed sleep variable from TwnMainPage tests https://gerrit.wikimedia.org/r/109471 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Nik Everett changed: What|Removed |Added CC||neverett+bugzilla@wikimedia ||.org --- Comment #15 from Nik Everett --- Cirrus has two sleeps: 1. It waits for some suggestions not to appear. Without reworking the error handling in the javascript I can't remove this. I don't feel up to reworking that right now. 2. It sleeps between the creation of two pages that it uses to test searches that prefer pages with recent edits. If I could backdate edit times then I wouldn't need it but I can't at this point. In total Cirrus sleeps 35 seconds because each of the above is executed once. It could be better but it could be worse. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #14 from Gerrit Notification Bot --- Change 109471 had a related patch set uploaded by 01tonythomas: Removed sleep variable from TwnMainPage tests https://gerrit.wikimedia.org/r/109471 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #13 from Gerrit Notification Bot --- Change 108916 merged by Cmcmahon: Replaced sleep with page-object gem waiting API https://gerrit.wikimedia.org/r/108916 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #12 from Gerrit Notification Bot --- Change 108918 merged by jenkins-bot: Removed sleep with waiting API in browsertests https://gerrit.wikimedia.org/r/108918 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #11 from Gerrit Notification Bot --- Change 108918 had a related patch set uploaded by 01tonythomas: Removed sleep with waiting API in browsertests https://gerrit.wikimedia.org/r/108918 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #10 from Gerrit Notification Bot --- Change 108916 had a related patch set uploaded by Zfilipin: Replaced sleep with page-object gem waiting API https://gerrit.wikimedia.org/r/108916 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Gerrit Notification Bot changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Tony Thomas <01tonytho...@gmail.com> changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |01tonytho...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #9 from Tony Thomas <01tonytho...@gmail.com> --- (In reply to comment #8) > Tony and I have paired on getting his environment set up to work on this. I will put my status in [QA] once I have made my environment ready. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Tony Thomas <01tonytho...@gmail.com> changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #8 from Željko Filipin --- Tony and I have paired on getting his environment set up to work on this. Tony, if you still are interested in working on this, feel free to assign the bug to yourself. Let me know if you need help. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #7 from Željko Filipin --- Tony, if you need help getting started apply for Pair programming Friday for fun and profit: https://www.mediawiki.org/wiki/Pair_programming_Friday_for_fun_and_profit -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #6 from Chris McMahon --- Tony Thomas: just removing the code is not enough. The tests have to be made to wait properly for whatever it is they are waiting for. Using sleep() is either an interim step that never got completed, or else the person writing the test could not think of a better way to wait for whatever the test needs. So the tests need to be updated in a thoughtful way so that they wait correctly without using sleep() but also without failing mistakenly. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Tony Thomas <01tonytho...@gmail.com> changed: What|Removed |Added CC||01tonytho...@gmail.com --- Comment #5 from Tony Thomas <01tonytho...@gmail.com> --- (In reply to comment #3) > Sleep statements found: > Removing the code from the following places will do ? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #4 from Željko Filipin --- If you need more information (and you probably do), feel free to ask questions here, at #wikimedia-qa freenode IRC channel or at QA mailing list: https://lists.wikimedia.org/mailman/listinfo/qa -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Željko Filipin changed: What|Removed |Added Whiteboard||gci2013 ||https://www.mediawiki.org/w ||iki/Google_Code-In#Candidat ||e_tasks -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #3 from Željko Filipin --- Sleep statements found: browsertests https://github.com/wikimedia/qa-browsertests/blob/master/features/step_definitions/print_export_menu_steps.rb#L14 https://github.com/wikimedia/qa-browsertests/blob/master/features/step_definitions/print_export_menu_steps.rb#L23 https://github.com/wikimedia/qa-browsertests/blob/master/features/step_definitions/upload_wizard_steps.rb#L23 https://github.com/wikimedia/qa-browsertests/blob/master/features/step_definitions/upload_wizard_steps.rb#L77 CirrusSearch https://github.com/wikimedia/mediawiki-extensions-CirrusSearch/blob/master/tests/browser/features/step_definitions/search_steps.rb#L82 TwnMainPage https://github.com/wikimedia/mediawiki-extensions-TwnMainPage/blob/master/tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb#L66 VisualEditor https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/test/browser/features/step_definitions/bullets_steps.rb#L17 https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/test/browser/features/step_definitions/shared_steps.rb#L25 https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/test/browser/features/step_definitions/transclusion_steps.rb#L31 Wikibase https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/selenium_cuc/features/step_definitions/aliases_steps.rb#L56 https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/selenium_cuc/features/support/modules/entity_module.rb#L115 https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/selenium_cuc/features/support/modules/entity_module.rb#L117 https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/selenium_cuc/features/support/modules/reference_module.rb#L50 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #2 from Željko Filipin --- There are more robust ways to wait for something to happen than using sleep: http://watirwebdriver.com/waiting/ https://github.com/cheezy/page-object/wiki/Ajax-Calls -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #1 from Željko Filipin --- We are using "sleep" in several places. Sleep is evil. We should remove it from all places. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46887] Remove "sleep" from tests
https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Željko Filipin changed: What|Removed |Added Summary|Remove sleep from |Remove "sleep" from tests |upload_wizard_steps.rb | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
