[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 --- Comment #12 from Krinkle krinklem...@gmail.com --- (In reply to comment #11) (In reply to comment #10) pl.wiki is on 1.22wmf8 but my feedback was posted to a non-existing page with Italian title (I have Italian UI), [[pl:Wikipedia:VisualEditor/Commenti]]: https://pl.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/ Commentioldid=36959657 Confirmed, this is also happening to me. Did the code get broken somehow? Somewhere between https://gerrit.wikimedia.org/r/#/c/68216/ and its parent (I can't seem to find the commit that added it) the message was added in VisualEditor.php's resource module definition. Which caused the message from VisualEditorMessagesModule (in content-language) to be overridden at run time by the one from ResourceLoader for user language. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 74064 had a related patch set uploaded by Krinkle: Remove 'visualeditor-feedback-link' from RL module https://gerrit.wikimedia.org/r/74064 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 74064 merged by jenkins-bot: Remove 'visualeditor-feedback-link' from RL module https://gerrit.wikimedia.org/r/74064 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #14 from James Forrester jforres...@wikimedia.org --- Fixed. Sorry about this. Will be deployed this afternoon. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|REOPENED|ASSIGNED Target Milestone|VE-deploy-2013-05-27|VE-deploy-2013-07-18 --- Comment #11 from James Forrester jforres...@wikimedia.org --- (In reply to comment #10) pl.wiki is on 1.22wmf8 but my feedback was posted to a non-existing page with Italian title (I have Italian UI), [[pl:Wikipedia:VisualEditor/Commenti]]: https://pl.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/ Commentioldid=36959657 Confirmed, this is also happening to me. Did the code get broken somehow? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|esand...@wikimedia.org |krinklem...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 Nemo federicol...@tiscali.it changed: What|Removed |Added Status|RESOLVED|REOPENED CC||federicol...@tiscali.it Resolution|FIXED |--- --- Comment #10 from Nemo federicol...@tiscali.it --- pl.wiki is on 1.22wmf8 but my feedback was posted to a non-existing page with Italian title (I have Italian UI), [[pl:Wikipedia:VisualEditor/Commenti]]: https://pl.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Commentioldid=36959657 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 James Forrester jforres...@wikimedia.org changed: What|Removed |Added CC||wikipe...@se4598.eu --- Comment #8 from James Forrester jforres...@wikimedia.org --- *** Bug 48645 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #9 from James Forrester jforres...@wikimedia.org --- Merged and will go out in wmf5. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/64498 (Gerrit Change I3804e6f91015ef9b8ae5196efb37475d714cd7d5) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|krinklem...@gmail.com |esand...@wikimedia.org Target Milestone|--- |VE-deploy-2013-05-27 Summary|MediaWiki: Message |VisualEditor: Message |visualeditor-feedback-link |visualeditor-feedback-link | should be used in content | should be used in content |language|language --- Comment #1 from James Forrester jforres...@wikimedia.org --- (Is this a bug in the core MW feedback tool?) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 --- Comment #2 from Liangent liang...@gmail.com --- I'm not sure what core MW feedback tool means, but I was talking about the feedback feature for [[Wikipedia:VisualEditor/Feedback]]. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 --- Comment #3 from James Forrester jforres...@wikimedia.org --- (In reply to comment #2) I'm not sure what core MW feedback tool means, but I was talking about the feedback feature for [[Wikipedia:VisualEditor/Feedback]]. Yes, this is a core MediaWiki feature, it just happens to be used by VisualEditor: resources/mediawiki/mediawiki.feedback.js -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 --- Comment #4 from Liangent liang...@gmail.com --- But there is: modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js: 'title': new mw.Title( ve.msg( 'visualeditor-feedback-link' ) ), shouldn't something like: new mw.Title( ve.msg( 'visualeditor-feedback-link' ).inContentLanguage() ) be used? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 --- Comment #5 from James Forrester jforres...@wikimedia.org --- Yes, that would fix this particular problem; my question is more as to whether the core tool should default for target link to be in the content language. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47730] VisualEditor: Message visualeditor-feedback-link should be used in content language
https://bugzilla.wikimedia.org/show_bug.cgi?id=47730 --- Comment #6 from Liangent liang...@gmail.com --- (In reply to comment #5) Yes, that would fix this particular problem; my question is more as to whether the core tool should default for target link to be in the content language. Based on what I see in the usage given above, you're giving a Title to core feedback tool, which points to a certain page, instead of a message name to core with feedback page name in that message. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
